[Trigger] Boss area Problem

[Shendoo2]

Im making a hero arena tyep map and im adding a monster area and i need a trigger to check if they boss is dead (its a unit, not a hero) and i was wondering why these triggers won't work

• Wait until ((Number of units in (Units in Boss Area Bottom <gen> matching (((Matching unit) is A ground unit) Equal to True))) Less than or equal to 1), checking every 0.50 seconds

That won't work with a knight (As the boss) and the blade master (as the hero) but when i use the Mountain king (As the boss) and Blade Master (as the hero) it works... why does it do that? cause its a pain to make like 10 bosses over again as heroes... will +rep if helped

 

[Day-Elven]

1. Knight have a wrong classification (For ex., he's not ground)

2. There is more units with ground classification in region (like neutral passive animals), that never die, so condition don't allow trigger to run.

3. Are you sure that the problem is in this line?

 

[Shendoo2]

this is the whole trigger while im trying to get it to work

• Checking Boss Bottom
  • Events
  • Conditions
  • Actions
    • Unit Group - Pick every unit in (Units in Boss Area Bottom <gen>) and do (Actions)
      • Loop - Actions
        • Game - Display to (Player group((Owner of (Picked unit)))) the text: |cff0F6145Welcome t...
    • Wait until ((Number of units in (Units in Boss Area Bottom <gen> matching (((Matching unit) is An Ancient) Equal to True))) Less than or equal to 0), checking every 0.50 seconds
    • Game - Display to (All players) the text: 1
    • Wait 1.00 seconds
    • Wait until ((Number of units in (Units in Boss Area Bottom <gen> matching (((Matching unit) is A Hero) Equal to True))) Less than or equal to 1), checking every 0.50 seconds
    • Wait 1.00 seconds
    • Wait until ((Number of units in (Units in Boss Area Bottom <gen> matching (((Matching unit) is A Hero) Equal to True))) Less than or equal to 1), checking every 0.50 seconds
    • Wait 1.00 seconds
    • Wait until ((Number of units in (Units in Boss Area Bottom <gen> matching (((Matching unit) is A Hero) Equal to True))) Less than or equal to 1), checking every 0.50 seconds
    • Unit Group - Pick every unit in (Units in Boss Area Bottom <gen>) and do (Actions)
      • Loop - Actions
        • Game - Display to (Player group((Owner of (Picked unit)))) the text: |cff0F6145You have ...
    • Wait 5.00 seconds
    • Unit Group - Pick every unit in (Units in Boss Area Bottom <gen>) and do (Actions)
      • Loop - Actions
        • Game - Display to (Player group((Owner of (Picked unit)))) the text: |cff0F6145Thank you...
    • Unit Group - Pick every unit in (Units in Boss Area Bottom <gen>) and do (Actions)
      • Loop - Actions
        • Unit - Move (Picked unit) instantly to (Center of (Playable map area)), facing Default building facing degrees
    • Trigger - Turn on Monster Teler And Spawn Bottom <gen>

i have the checking thing alot cause if the blade master use's mirror image

 

[Day-Elven]

1. There are memory leaks in groups and location.
2. You can display message without picking units.

• Unit Group - Pick every unit in (Units in Boss Area Bottom <gen>) and do (Actions)
• Loop - Actions
• Game - Display to (Player group((Owner of (Picked unit)))) the text: |cff0F6145You have

3. Better to use loop here

• Wait until ((Number of units in (Units in Boss Area Bottom <gen> matching (((Matching unit) is A Hero) Equal to True))) Less than or equal to 1), checking every 0.50 seconds
• Wait 1.00 seconds
• Wait until ((Number of units in (Units in Boss Area Bottom <gen> matching (((Matching unit) is A Hero) Equal to True))) Less than or equal to 1), checking every 0.50 seconds
• Wait 1.00 seconds
• Wait until ((Number of units in (Units in Boss Area Bottom <gen> matching (((Matching unit) is A Hero) Equal to True))) Less than or equal to 1), checking every 0.50 seconds

4. Who are ancients? Are you sure that both bosses have this classification? And number of units can't be < 0.

• Wait until ((Number of units in (Units in Boss Area Bottom <gen> matching (((Matching unit) is An Ancient) Equal to True))) Less than or equal to 0), checking every 0.50 second

 

[Shendoo2]

the hero isn't an ancient but the boss is and when the boss dies there should be 0 Ancients in the area. and could you make the trigger without leaks?

 

[Day-Elven]

could you make the trigger without leaks?

Yes, convert it to jass and send to me.

 

[Shendoo2]

idk how to do jass so if i need to change it =/

 

[M0RT]

Instead of "wait until", you should create another trigger (it's leakless):

• Events
  • Unit - A unit dies
• Conditions
  • (Dying unit) is An Ancient) Equal to True)
  • (Boss Area Bottom <gen>) contains (Dying unit) equal to True
• Actions
  • <message, move heroes and turn on the trigger and so on....)

 

[Day-Elven]

It's easier to remove leaks in one trigger than to create another one.

 

[M0RT]

Are you sure you can remove leaks from "Wait until"? You can't run DestroyGroup() on every check.

 

[Day-Elven]

You can create a local group and check if Number of units in group <=1. It won't leak.

 

[M0RT]

But you can't use that in "wait until"

• set uGroup = units in area.....
• wait until ( |uGroup| < 1 )
• destroy uGroup

this won't leak, but it also won't work, cause the test will consider the units that were in the group when it was created, not when it is tested

 

[Shendoo2]

+rep both of you i found the problem i'm kinda retarded cause i was using Blade masters illusions to test it and its not a hero so it didn't set the variable and such but anyways thanks