Moderator
M
Moderator
12th Dec 2015
IcemanBo: For too long time as NeedsFix. Rejected.
08:35 GMT, 7th Jun 2011
Bribe:
"BigShuriken_InstanceA" should not be an array, it should be split into several variables. This will make it more readable and run faster in-game.
This line leaks a location:
"Set BigShuriken_AAngle[BigShuriken_InstanceA[1]] = (Angle from (Position of BigShuriken_ACaster[BigShuriken_InstanceA[1]]) to BigShuriken_ASpellPoint)"
This line leaks two locations:
"Unit - Create 1 Shuriken for (Owner of BigShuriken_ACaster[BigShuriken_InstanceA[1]]) at ((Position of BigShuriken_ACaster[BigShuriken_InstanceA[1]]) offset by BigShuriken_BDistance[BigShuriken_InstanceB[1]] towards BigShuriken_BAngle[BigShuriken_InstanceB[1]] degrees) facing Default building facing degrees..."
You never remove this location after you set it:
"Set BigShuriken_ACenterPoint[BigShuriken_InstanceA[1]] = (Position of BigShuriken_ACaster[BigShuriken_InstanceA[1]])"
This line leaks a location:
"Unit - Move BigShuriken_BShuriken[((BigShuriken_InstanceB[2] x BigShuriken_BSmallShurikens) - BigShuriken_InstanceA[2])] instantly to (BigShuriken_ACenterPoint[BigShuriken_InstanceA[2]] offset by BigShuriken_BDistance[BigShuriken_InstanceB[2]] towards BigShuriken_BAngle[BigShuriken_InstanceB[2]] degrees)"
This line leaks a location:
"Destructable - Pick every destructible within BigShuriken_AAreaOfEffect of (Position of BigShuriken_BShuriken[((BigShuriken_InstanceB[2] x BigShuriken_BSmallShurikens) - BigShuriken_InstanceA[2])]) and do (Actions)"
This line leaks a location and a group:
"Unit Group - Pick every unit in (Units within BigShuriken_AAreaOfEffect of (Position of BigShuriken_BShuriken[((BigShuriken_InstanceB[2] x BigShuriken_BSmallShurikens) - BigShuriken_InstanceA[2])])) and do (Actions)"
IcemanBo: For too long time as NeedsFix. Rejected.
08:35 GMT, 7th Jun 2011
Bribe:
-
-------- I know, I can set the next damage on "Big shuriken Cast" trigger... --------
- Set BigShuriken_ADamagePerSecond[BigShuriken_InstanceA[1]] = (2.00 x (Real((Level of A000 for BigShuriken_ACaster[BigShuriken_InstanceA[1]]))))
"BigShuriken_InstanceA" should not be an array, it should be split into several variables. This will make it more readable and run faster in-game.
This line leaks a location:
"Set BigShuriken_AAngle[BigShuriken_InstanceA[1]] = (Angle from (Position of BigShuriken_ACaster[BigShuriken_InstanceA[1]]) to BigShuriken_ASpellPoint)"
This line leaks two locations:
"Unit - Create 1 Shuriken for (Owner of BigShuriken_ACaster[BigShuriken_InstanceA[1]]) at ((Position of BigShuriken_ACaster[BigShuriken_InstanceA[1]]) offset by BigShuriken_BDistance[BigShuriken_InstanceB[1]] towards BigShuriken_BAngle[BigShuriken_InstanceB[1]] degrees) facing Default building facing degrees..."
You never remove this location after you set it:
"Set BigShuriken_ACenterPoint[BigShuriken_InstanceA[1]] = (Position of BigShuriken_ACaster[BigShuriken_InstanceA[1]])"
This line leaks a location:
"Unit - Move BigShuriken_BShuriken[((BigShuriken_InstanceB[2] x BigShuriken_BSmallShurikens) - BigShuriken_InstanceA[2])] instantly to (BigShuriken_ACenterPoint[BigShuriken_InstanceA[2]] offset by BigShuriken_BDistance[BigShuriken_InstanceB[2]] towards BigShuriken_BAngle[BigShuriken_InstanceB[2]] degrees)"
This line leaks a location:
"Destructable - Pick every destructible within BigShuriken_AAreaOfEffect of (Position of BigShuriken_BShuriken[((BigShuriken_InstanceB[2] x BigShuriken_BSmallShurikens) - BigShuriken_InstanceA[2])]) and do (Actions)"
This line leaks a location and a group:
"Unit Group - Pick every unit in (Units within BigShuriken_AAreaOfEffect of (Position of BigShuriken_BShuriken[((BigShuriken_InstanceB[2] x BigShuriken_BSmallShurikens) - BigShuriken_InstanceA[2])])) and do (Actions)"