Armageddon v.2.4.1

[Moderator]

Armageddon v1.0.0.0 | Reviewed by Maker | 16.01.14 [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" Concept[/COLOR]] The spell is like a non channeled Starfall and the area of effect follows the caster It might not be that original but it looks good and works well Somehow it lacks something that would really make it live up to its name Triggers[/COLOR]] You did a great job with the triggering Objects[/COLOR]] No complaints here, everything is as it should be Effects[/COLOR]] The effects are what one could expect from a spell with this theme Rating[/COLOR]] CONCEPT TRIGGERS OBJECTS EFFECTS RATING STATUS APPROVED

 

[Malhorne]

I'll say the same thing like the last thread :
Use constant function \o/ !

You're double privating :

    private struct Main extends array
        private static constant real TIMEOUT = 0.031250000//Timer timeout
        private static constant real TWO_PI  = 6.283185307//Create new meteors in any potential angle

That's not needed

Otherwise the code looks good even if it needs tons of things xD!
I'll see the map later and rate

 

[BPower]

I just changed both.

Otherwise the code looks good even if it needs tons of things xD!

I could list Alloc as optional resource, the rest is mandatory.

But in the long run Table, RegisterPlayerUnitEvent, UnitIndexer, WorldBounds and maybe even CTL can be found in nearly any map, which is not completly written in GUI.

 

[Malhorne]

I don't know ^^
I'm a guy who prefer use the less things as possible but maybe you're right on that one xD

 

[BPower]

Alloc is now an optional requirement.

I'm a guy who prefer use the less things as possible

Me too, but to provide a measure of quality, I have to use at least a Dummy resource and a Timer resource. I've chosen Nestharus libraries, because of their quality plus he still keeps them updated.

 

[deathismyfriend]

What is with all of the private constant functions...

Simply declare it in the constant variable in the scope.

No reason to add extra functions.

When extending array Alloc is needed. The optional thing for that will break the script when it is run if you do not have Alloc

 

[Malhorne]

Constant functions are inlined so what's the problem when it depends on some parameters like level ?

 

[Cokemonkey11]

But in the long run Table, RegisterPlayerUnitEvent, UnitIndexer, WorldBounds and maybe even CTL can be found in nearly any map, which is not completly written in GUI.

I literally don't use any of those except Table, and that's not even the Table you're thinking of...

What is with all of the private constant functions...

Simply declare it in the constant variable in the scope.

No reason to add extra functions.

That's just like, your opinion, man

 

[BPower]

When extending array Alloc is needed. The optional thing for that will break the script when it is run if you do not have Alloc

            static if (thistype.allocate.exists) then
                local thistype this = allocate()
            else
                local thistype this = rn[0]
                if this == 0 then
                    set ic = ic + 1
                    set this = ic
                else
                    set rn[0] = rn[this]
                endif
            endif

I literally don't use any of those except Table, and that's not even the Table you're thinking of...

Yes I know, but I guess you don't CnP spell resources into your maps, but rather re-write them into you own coding-style.

Edit:

What is with all of the private constant functions...

Because it offers you more capabilities. For instance damage calculation --> BASE_AMOUNT + LEVEL_INCREASEMENT in a global block

while within the function you can do 20 + level*10 + GetHeroStat(caster, strenght) + ...

 

[deathismyfriend]

            static if (thistype.allocate.exists) then
                local thistype this = allocate()
            else
                local thistype this = rn[0]
                if this == 0 then
                    set ic = ic + 1
                    set this = ic
                else
                    set rn[0] = rn[this]
                endif
            endif

Yes I know, but I guess you don't CnP spell resources into your maps, but rather re-write them to you own style.

oops i must be tired lol.

@Cokemonkey11
Having constants like that looks tacky to me.
Why create extra functions when they are not needed ?

 

[Cokemonkey11]

@Cokemonkey11
Having constants like that looks tacky to me.
Why create extra functions when they are not needed ?

It was a design preference. I also don't like them, but since we're not the designers, our preferences have no place in the matter.

When you program other languages the number of design preferences and semantically equivalent constructs will increase exponentially.

I don't like if ( s > 5 ) then and prefer if s>5 then but I don't tell everyone to mimic my whitespace.

On the other hand, if (! a) and (! b) then can be simplified with demorgan's laws to if ! (a or b) then, so you might have a reason to say something in that case.

constant functions are inlined the same way as constant fields so there is no reason to complain about the difference

 

[Malhorne]

With constant variables you can't do this :

private constant function Damage takes integer level returns real
    return 100.*level
endfunction

 

[Anachron]

GROUND_LEVEL should NEVER be static but rather be calculated for every missile.
Reason is that hills and stuff change ground level and no map has a fixed ground level (except demo maps maybe).

That's one of the reasons why I hate too small demo maps.

 

[BPower]

I though SetUnitFlyHeight already considers the ground level. The Meteor have no movement in x or y axis.

I'll test that.

Edit: Tested, it totally works with GROUND_LEVEL.

Works with lowered, raised and cliff terrain of any height. Aswell as shallow and deep water.

 

[Anachron]

But you do a static check for GROUND_LEVEL and it should be dynamic on every position of the map. Create a hill somewhere and spawn meteors. Instead of exploding at top it waits until it would normally reach the other ground level.

                        if (cur.z < GROUND_LEVEL) then//Check if the meteor hit the ground
                            call GroupEnumUnitsInRange(enu, GetUnitX(cur.dum.unit), GetUnitY(cur.dum.unit), cur.aoe, null)
                            loop
                                set u = FirstOfGroup(enu)
                                exitwhen u == null
                                call GroupRemoveUnit(enu, u)
                       
                                if TargetFilter(.owner, u) then
                                    call UnitDamageTarget(.cast, u, .dmg, false, false, ATTACK_TYPE, DAMAGE_TYPE, null)
                                endif
                            endloop
                            /*
                            *   We have to use a little trick to display the full
                            *   animation of the meteor, because Dummy does
                            *   call SetUnitPosition(dummies[this], 2147483647, 2147483647) on destroy.
                            *   That's why we create a little waiting time, before recycling the dummy.
                            *   By checking if cur.model == null.
                            */
                            call DestroyEffect(cur.model)
                            set cur.model = null
                            set cur.z = 0//Reuse cur.z for the METEOR_EX_TIME check
                        endif

 

[BPower]

Just did you are wrong, because I create each meteor on the ground and then put them 1300 units in the air, relative to the position it has been created.

set .z = METEOR_HEIGHT
set .dum = Dummy.create(x + field*Cos(angle), y + field*Sin(angle), 0)
call SetUnitScale(.dum.unit, scale, 1, 1)
set .model = AddSpecialEffectTarget(METEOR_MODEL, .dum.unit, "origin")
call SetUnitFlyHeight(.dum.unit, .z, 0)

In case you do platform deformations during the cast it will not work properly.

Edit: I think it works with platform deformations during the cast (untested), but if you raise the terrain while a meteor is falling it will stop falling for one loop or even move upwards. The explosion though should be displayed correctly.

 

[Anachron]

Okay, you are right, I thought we are working with absolute positions.
But GROUND_HEIGHT actually means distance over the ground (fly height) where it should explode.

So, everything is okay, good job!

 

[BPower]

I will change the variable name to something more distinct. Its now called EXPLODE_HEIGHT.

Also added hills, valleys and cliffs to the demo map.

 

[zv27]

Why bother with so many systems for such a simple spell.

 

[BPower]

Table can most likely be found in every map which uses vJass resources and so is CTL.
Dummy is a personal preference over Missle and XE not just because of the sorting mechanics dummy has. In my opinion it also has a better API.
The CreateUnit native is a rather heavy operation, hence reducing it to a minumum is neat. However the avoided leak is negligible in the current patch version.

All other resources are optional.

The spell uses a lot of missles, which can influence the game experience by dropping the fps. Especially for those who run wc3 barely above requirements.
The more effects your resource uses the better the code should be. Optimization to a certain extend is something I really recommend.
That is the major reason those extra resources are required.

 

[Malhorne]

I don't think CTL can be found in every map.
Dummy and Missiles too.

 

[BPower]

Yeah for Dummy that is true. Sometimes I get the feeling I'm the only one using it.
Lately submissions follow the trend to run autonomous, which I agree is neat if you consider it as single resource.
When your map has 50 of those spells that might be different.
In general I guess the only two commonly used resources are TimerUtils and Table (Vexorians?).

The spell is well outlined and it should be easy to re-code it to ones needs, if you really dislike one of the requirements.
On the other side I think many people simply don't know how to use i.e CTL and now they have another nice illustration for proper usage.

 

[Malhorne]

Yeah Dummy isn't used ^^
I only use those resources when I code :
- Table by Vex
- My Fear System (just when needed)
- BoundSentinel by Vex
And I think I'm already done
Things that I might use if needed :
- GetUnitZ
- IsTerrainPathable
- IsDestructableTree

Anyway you're right that this code show how to use CTL even if I don't get the purpose of this like the purpose of Alloc :/

 

[BPower]

I don't get the purpose of this like the purpose of Alloc :/

Alloc just makes your life easy, because it is so fast to type --> implement Alloc
Like the textmacro you used in your fear explosion, it is for lazy people ^^.
Also the allocation is very optimized by using just one integer array "recycle" and no static integer "ic".
In theory it has bonus debug features to calculate used memory, but I never used that one.

Easy spoken, CTL is a linked list using one timer. It only runs if you have an active instance.
It registers the functions via TriggerCondition to one global trigger and fires them when the timer expires.
When you destroy the instance the TriggerCondition is removed. When the no instances are active
the timer is stopped. I might missed something, because the CTL library is already optimized to variables with 1 or 2 chars.

 

[Malhorne]

Textmacros are better than module when it comes to this kind of functions : inline is 55% faster than call that's why I don't get the use of Alloc :/
Also using CTL is for lazy people too ^^
Anyway I think we should stop this off-topic x)

 

[Maker]

Dummy is a great resource for "instant" facings. Recycling dummies to prevent memory leaks is something I don't bother to care about. I'm not even sure there is a memory leak after running some tests.

 

[Malhorne]

In a thread you proved that the leak hass been fixed.
Don't remember where ^^

 

[BPower]

Changelog from v.1.0 to v.2.0

• Now uses Missile, hence enables Missile API for falling Meteors.
• Position and fly angle are now properly randomized.
• Meteors do no longer fall vertical, but can now have a variety of flying angles.
• Implemented optional destructable ( tree ) collision.
• Implemented more options to customize the spell ( channeling, moving, .. )
• More effects added for better in game experience.
• Changed documentation style.

Changelog from v.2.0 to v.2.1

• Updated Missile inside the demo map to version 2.0.2
• Armageddon can now hit flying units if they collide in their fly height with a Meteor. ( z - axis collision )
  This is an optional toogle and requires DAMAGE_FLYING_UNITS = true in the Armageddon configuration.

Changelog from v.2.1 to v.2.2

• Updated Missile inside the demo map to version 2.0.2.1
• Spiced up the spell with a sound file.
• Improved documentation.
• Does no longer crash the thread when 0 is returned for meteors per seconds.
• Improved collision detection onRemove.

Changelog from v.2.2 to v.2.3

• Updated Missile inside the demo map to version 2.0.2.
• Passing 0 for MeteorsPerSecond now creates 0 missiles for that 1 second interval. ( Before it was still 1 )

Changelog from v.2.3 to v.2.4

• The on damage fx now only spawns, if the target unit was actually damaged.
• Fixed a very rare case, where GetRandomReal could recieve a higher min than max bound argument.

Changelog 2.4.1

• Improved the way how meteors spawn.