Advanced Pet System v2 [MPI] [Wohuynia]

[Moderator]

12th Dec 2015
IcemanBo: Too long time as NeedsFix. Rejected.

11:30, 31st May 2011
Maker:
Leak:

• Set W_X = (Number of players in (All players controlled by a User player))

Instead of looping through the player indexes, couldn't you use

• Custom script: if GetLocalPlayer() == GetTriggerPlayer() then

and utilize player number of triggering player for W_Int.

 

[jxtranghero]

looks nice I should try this...

 

[Midnighters]

Nice system, but maybe have it follow a bit closer

 

[x3GlikE]

Post triggers!

 

[Midnighters]

x3 there are like 10 triggers.

 

[light bolt30]

x3 there are like 10 triggers.

Well, don't we have hidden tags for that matter?

 

[wohuynia]

Nice system, but maybe have it follow a bit closer

Now you can set <Range> in "Initialization" trigger.

Post triggers!

Here maybe you'll feel better ;D i have wasted 25mins of my life time just for you.

looks nice I should try this...

You better, else your post would be simple spam.

 

[Orcnet]

this system is wonderful! do you know another version that does not use arrow keys? not a request, just a suggestion

 

[baassee]

Owner of Triggering Unit -> Triggering Player

Set a temporary integer variable into the "player number" for quick reference.

Leak

• (Position of PetOwner)

Another leak that is repeated 2 times as the above one.

• Special Effect - Create a special effect at (Position of Pet[1]) using Abilities\Spells\Other\Charm\CharmTarget.mdl

Another leak

• Player group((Owner of PetOwner))

This system isn't even MPI due to the exit trigger shutting everything down for all the players.

More leaks

• Unit - Create 1 Pet_Type[1] for (Owner of (Triggering unit)) at (Position of (Triggering unit)) facing Default building facing degrees

Change owner into triggering player too

Why do you set a pet and create a pet and instantly after kill it?

leak

• Unit - Create 1 Pet_Type[2] for (Owner of (Triggering unit)) at (Position of (Triggering unit)) facing Default building facing degrees
• Unit - Create 1 Pet_Type[3] for (Owner of (Triggering unit)) at (Position of (Triggering unit)) facing Default building facing degrees

follow trigger leaks 60 times per second

• (Distance between (Position of PetOwner) and (Position of Pet[(Integer A)])) Greater than or equal to range

the idea is kinda good yet it's not leak free and it's not mpi

 

[wohuynia]

this system is wonderful! do you know another version that does not use arrow keys? not a request, just a suggestion

This system has only one version of it, so no.

Why do you set a pet and create a pet and instantly after kill it?

Because i setup booleans that check if other pets are alive, plus if i wouldn't kill it it would cause some bugs also you would be able to summon more then one pet at the time or something.

This system isn't even MPI due to the exit trigger shutting everything down for all the players.

I think i fixed it, if not ill take my thinking capsule and go to sleep... Edit.

Leak

Fixed all of them, now it SHOULD NOT leak.

 

[baassee]

Still in the follow trigger you set a point which you dont use in the distance check

• (Distance between (Position of PetOwner) and (Position of Pet[(Integer A)])) Greater than or equal to range

Also you only remove it if the range is greater. The remove custom script line should be behind the whole if, also you need to set another point

this should have needs fix before being approved

 

[Magtheridon96]

Nice System
I'd love to use this in an RPG (you know - when i feel like making one )
You've done a good job with this system
I vote for APPROVAL and I'll give you a 5/5

 

[.VTZ.]

it works for more than 1 player?

 

[baassee]

The answer to that is no. And it still leaks.

 

[wohuynia]

Sorry for not making any updates today, its women day and my girl friend begs for attention, i found a way how to fix all the leaks and make it MPI, till tomorrow.

 

[Magtheridon96]

You're french aren't you
Women's day in Lebanon also happens to be a very.. how do i put this.. "Politically Active" day - Very "Problematic"

Anyways, i just realized that your system isn't MPI (I looked at the comments below mine ), and decided to change my rating (orally) to a 4/5 :/ DONT WORRY. I'm not going to change my rating on the hive, it's just a mental note.. -.-

 

[Adiktuz]

Right now: idea is fine, not approvable yet due being not MUI and leakless

After it becomes MPI and leakless: great, approvable

After it becomes MUI: EPIC, HR I think...

 

[wohuynia]

You're french aren't you
Women's day in Lebanon also happens to be a very.. how do i put this.. "Politically Active" day - Very "Problematic"

Anyways, i just realized that your system isn't MPI (I looked at the comments below mine ), and decided to change my rating (orally) to a 4/5 :/ DONT WORRY. I'm not going to change my rating on the hive, it's just a mental note.. -.-

Ding Ding Ding, your dreams can come through, only for 1.99$ just email me with paypal to "[email protected]" and it will happen...
On topic: Now its MPI and thanks for the rating ;D

PS: Not French, Lithuanian, yeah this day gets very active in our country, discounts, commercials, "special for ladies", etc etc etc.

Right now: idea is fine, not approvable yet due being not MUI and leakless

After it becomes MPI and leakless: great, approvable

After it becomes MUI: EPIC, HR I think...

Thanks for the comment, now it is great ;D

it works for more than 1 player?

It is now.

Still in the follow trigger you set a point which you dont use in the distance check

• (Distance between (Position of PetOwner) and (Position of Pet[(Integer A)])) Greater than or equal to range

Also you only remove it if the range is greater. The remove custom script line should be behind the whole if, also you need to set another point

this should have needs fix before being approved

Fixed it, now it doesn't leak.

 

[baassee]

Still not MPI as the whole system uses only 1 multiboard which is not possible to do.

 

[wohuynia]

Still not MPI as the whole system uses only 1 multiboard which is not possible to do.

Forgot to do it the last time, now its fixed, check it your self ;D

 

[baassee]

Still not MPI as the MPI2 variable is never increased.

The Range variable isn't arrayed so that will destroy the MPI part as well.

You have to loop thru them all in the initialization trigger, like this variable:

• Set Board[MPI2] = False

In the initialization trigger you leak this:

• Set Point = (Center of (Playable map area))
• Set Point2 = (Center of (Playable map area))

You're show multiboard trigger sucks. Every single spell on the map will 'cause a multiboard to be created.

Neither MPI variable is increased.

You should prefix all your variables as the names are way too common.

You should nest the ifs in the Operate Action trigger which is to put the second if in the first's else and the third in the second's else.

Pet Setup trigger should have the first if removed as its condition can be in the trigger's condition.

Pet Fallow trigger leaks as the variables are reset for nothing, it should look like this:

• Set Point = (Position of PetOwner)
• Set Point2 = (Position of Pet2[MPI2])
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• (Distance between Point and Point2) Greater than or equal to range
• Then - Actions
  • Unit - Order Pet1[MPI2] to Right-Click PetOwner
  • Unit - Order Pet2[MPI2] to Right-Click PetOwner
  • Unit - Order Pet3[MPI2] to Right-Click PetOwner
• Else - Actions
• Custom script: call RemoveLocation(udg_Point)
• Custom script: call RemoveLocation(udg_Point2)

In the Pet Release trigger, the first if should be removed as the condition can be set into the trigger's condition.

Yeah it's not MPI and I have checked it.

 

[wohuynia]

• Set Point = (Position of PetOwner)
• Set Point2 = (Position of Pet2[MPI2])
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• (Distance between Point and Point2) Greater than or equal to range
• Then - Actions
• Unit - Order Pet1[MPI2] to Right-Click PetOwner
• Unit - Order Pet2[MPI2] to Right-Click PetOwner
• Unit - Order Pet3[MPI2] to Right-Click PetOwner
• Else - Actions
• Custom script: call RemoveLocation(udg_Point)
• Custom script: call RemoveLocation(udg_Point2)

This point doesn't work, only Pet2[*] will fallow/attack... Others will issue an order every 0.1 sec right click the pet owner.

You should prefix all your variables as the names are way too common.

And whats the problem with that?

You should nest the ifs

Done.

Still not MPI as the MPI2 variable is never increased.

Done.

Pet Setup trigger should have the first if removed as its condition can be in the trigger's condition.

Done.

Pet Fallow trigger leaks as the variables are reset for nothing, it should look like this:

Reworked fallowing, thou your suggestion wasn't completely right.

PS: i have busted my ass for 4h'rs to make it MPI/MUI now it should be everything you always wanted.

 

[Adiktuz]

the problem with common variable names is that your variable could clash with other systems using the same variable names...

 

[wohuynia]

the problem with common variable names is that your variable could clash with other systems using the same variable names...

Good point...

 

[baassee]

Good to see you updating but still a few flaws.

-

• Set X = (Number of players in (All players controlled by a User player))

Leaks a Force

-Still in the show multiboard trigger, it will loop unnecessaryily because of the trigger's condition isn't right. Please move this condition into the trigger's condition:

• (Ability being cast) Equal to Pet Menu

-(Owner of (Triggering unit))

Should be Triggering Player

-

• (Player group((Owner of PetOwner[Int])))

Leaks a Force.

Apart from that, it looks a lot better than last time.

You still need to prefix the variables. No buts and whys.

 

[wohuynia]

Good to see you updating but still a few flaws.

-

• Set X = (Number of players in (All players controlled by a User player))

Leaks a Force

-Still in the show multiboard trigger, it will loop unnecessaryily because of the trigger's condition isn't right. Please move this condition into the trigger's condition:

• (Ability being cast) Equal to Pet Menu

-(Owner of (Triggering unit))

Should be Triggering Player

-

• (Player group((Owner of PetOwner[Int])))

Leaks a Force.

Apart from that, it looks a lot better than last time.

You still need to prefix the variables. No buts and whys.

All things fixed, edited variables, cleared leaks, other minor thingies
There are 2 more bugs that I need to fix, but that's after this week(Art exam is in 2 days and I'm missing like 20~ drawings D)

 

[baassee]

You still leak.

• Custom script: set bj_wantDestroyGroup = true

Is only for Unit Groups, you're leaking Player Groups.

Set a Player Group variable and use "call DestroyForce(yourvariable)"

 

[wohuynia]

Done.

 

[baassee]

Done.

Update the triggers in the description please

 

[wohuynia]

Update the triggers in the description please

Done that to ;D

 

[.VTZ.]

thank you wohuynia

 

[wohuynia]

Made a new update on the system.

 

[baassee]

Let's review this once again.

-You still leak a force. You set a variable and you don't even use it?

• Set W_P_Group[1] = (All players controlled by a User player)
• Set W_X = (Number of players in (All players controlled by a User player))

-The strings you're using as icons to the multiboard really should be stored into different arrayed string variables.

-I just remembered one thing. Why are you looping thru for every single trigger? Just do the if GetLocalPlayer() == GetTriggerPlayer() then
and after that you have a variable set into the player number of the triggering player. That would fix every single loop.

-Pet Level Up trigger needs a trigger condition.

-(Owner of (Triggering unit)) -> Triggering Player

 

[wohuynia]

1.-The strings you're using as icons to the multiboard really should be stored into different arrayed string variables.

2.-I just remembered one thing. Why are you looping thru for every single trigger? Just do the if GetLocalPlayer() == GetTriggerPlayer() then
and after that you have a variable set into the player number of the triggering player. That would fix every single loop.

1st. you can store icons in variables, or at least, i don't know how.
2nd. i think i tested it without loop, but it bugged a lot, so i decided to use loop (i think)?
Ill fix other problems.

 

[baassee]

1. The path to the icons must be saved into a string variable.

2. You think? Test again.

 

[azzader]

if we add another newly custom made pet..how should we modify the triggers then? i dont know and dont really quite understand about it.

 

[Fud]

I want to use it for a hunter hero... does it work for multiple players? someone else said no and i think that is pretty damn important...

 

[Bribe]

Well this spell is set to "Needs fix" we don't recommend using it.

 

[wohuynia]

well this system does work, but only bad thing is that there is one leak in it that Maker stated earlier but i haven't done triggering for ages, so i don't quite remember how to fix it, its not really hard but i just don't have time to do that.
Quote from Private message from maker:

Leak:

• Set W_X = (Number of players in (All players controlled by a User player))

Instead of looping through the player indexes, couldn't you use

• Custom script: if GetLocalPlayer() == GetTriggerPlayer() then

and utilize player number of triggering player for W_Int.

 

[gorillabull]

simple but it works =)

 

[SaintShen]

hmm i got problem with pet summoning
at triggers i just changed pet types and after i get in game and want to summon pet [ESC]
i see just animation, any ideas why ?