Approved
First Reply 
its useless cause banking systems are most used in TDs or something like that...
Set Amount = (Integer((Substring((EnteredChatString(7,11))))
Set Amount = (Integer((Substring((EnteredChatString(7,GetStringLength(EnteredChatString))))
Player- Set .... gold to ... current gold + Substring(..)
Player- Set .... gold to (BankAcc)
Merged Trigger
Events:
Player 1 types a chat message containing bank as a string part
Player 2 types a chat message containing bank as a string part
...
Conditions:
Actions:
Set Amount = (Integer((Substring((EnteredChatString(7,GetStringLength(EnteredChatString))))
If
Substring(EnteredChatString(1,6) = "-bank"
Then
Set BankAcc[PlayerNumber(TriggeringPlayer)] = BankAcc[PlayerNumber(TriggeringPlayer)] + Amount
Set Triggering Players gold to BankAcc[PlayerNumber(TriggeringPlayer)]
Set Triggering Players wood to (Triggering Players wood - Amount)
Display to Player(PlayerNumber(Triggering Player)) the text " --your withdraw message here-- "
If
Substring(EnteredChatString(1,6) = "+bank"
Triggering Player gold >= Amount
Then
Set BankAcc[PlayerNumber(TriggeringPlayer)] = BankAcc[PlayerNumber(TriggeringPlayer)] - Amount
Set Triggering Players gold to BankAcc[PlayerNumber(TriggeringPlayer)]
Set Triggering Players wood to (Triggering Players wood + Amount)
Display to Player(PlayerNumber(Triggering Player)) the text " --your deposit message here-- "
didn't knew about this "GetStringLength" il fix this.should be
to make players able to withdraw/deposit even higher values than 99999...
don't you mean Amount variable instead of BankAcc? Still got the idea, fixed it.why the hell do you do that??? you set the BankAcc variable to that value already so you can insert it:
i wanna make more RPG bank system, that NEEDS bank booth to deposit gold xD plus it leaks, don't see mistakes, did what told me to do but still it leaks xD so ima stick to the old 1. Still thanx thouThe Triggers "unit leaves bank booth" and "unit enters bank booth" are completly useless! they can be merged into the bank in trigger AND the "Bank in" and the "bank out" triggers can be also merged into one.
This is how the new trigger in MPI should (nearly) look like
Merged Trigger
Events
Unit - Something happens
Conditions
Something is less than/more than/equal to something
Actions
Set Bank___AddAmount = 1,000,000 //1 million gold!
Trigger - Run BankAddAmount <gen> Checking conditions
Shouldn't systems be a bit less specific and have a bit more options?
I mean, the user should be able to design weather or not he wish to use a chat string, click a command button or walk into different circles.
Maybe something like
Maybe even add options to make it a 'real' bank, where you lend money to the bank and it gives you money every month (or second) depending on how much you've lend, and when you borrow money from the bank it will instead take money?
And only the sum of all money in the bank's deposits are avilable for lending/borrowing?
Just some thoughts I think would greatly increase the quality of this system.
Idea
Well we have bank systems here but this one has a lot more improved functions...
4/5
Coding
A nice multiboard with good visuals without the use of imported stuff is something great!
Coding has improved a lot from the last version i reviewed! i see no leaks or faults
1. A singe space between "Account:" and your money so "Account:500" becomes "Account: 500"
2. A message when you reached the top or bottom of the list is not necessary and a little annoying
3.You can't withdraw 500 if you have less than 500 in your bank... maybe change that so if you have less than 500 you simply withdraw all!
4. pause AND stop the unit that enters a bank, cause when you quit it the unit runs on...
5. If i entered a bank with a unit and then come in range with another unit my old one is never unpaused... maybe check on enter whether there is already a unit in the bank
6. add a boolean whether all those messages should be shown!
4/5
Documentation
The documentation for how to import and how to set up could be better
3/5
Result
If your current version is 2.1 then please don't name your map "Bank System v2.0"
Improve my suggestions in the coding section and update your documentation to have a really good system!
Overall: (4+4+3)/3 = 3.6 ==> 4
Vote for Approval: [Not able to Vote but would be a yes]
+rep: No
Updates:
v2.2:
Fixed pausing unit, now you won't wont get bugged when you have more then one unit.
Removed annoying messages.
Fixed bug when you exit the bank you still initiate the last order.
Added new option, now you can disable messages.
Simplified "How to import" now its more detailed an more user friendly.Well in version 2.4 i added "store items system" i wont do your suggestion, because to store 1 item it takes 66 GUI lines, it will stay this way till ill figure out how to reduce the size of trigger functions that check every single inventory slot.
Idea
We have bank systems here but this one has a lot more improved functions...
In addition none of these systems is able to store items!
5/5
Coding
Coding is better now but there are still some things xD
1. you still can't use deposit 500 when you have less than 500 gold... change that so you simply deposit all when you have less than 500!
2. when switching to the item storage, the first multiboard line is just a "headline"... maybe it's better to remove the point image before this line and make it not selectable cause there is no use for it!
3. Merge your item actions... creating a new condition for each row can be done easier by using a loop for example!
4. i saw no hint how to set the custom amount until i opened the map in WE
4/5
Documentation
There is a explanation for each line or each bundle of actions so you can understand the whole system even as a noob!
4/5
Result
A lot of improvement, but there are still some things as mentioned above
Overall: (5+4+4)/3 = 4.3 ==> 4
Vote for Approval: [Not able to Vote but would be a yes]
+rep: No
Well in version 2.4 i added "store items system" i wont do your suggestion, because to store 1 item it takes 66 GUI lines, it will stay this way till ill figure out how to reduce the size of trigger functions that check every single inventory slot.
But till now i want to take break from triggering.
Now enjoy new version with mass coding (462 GUI lines just to store and take 6 items)
