Advanced Bouncing System v2

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

BPower 5.2.2014

• For GUI spells/systems it is better to use two chars prefix p_ --> AB_
• You should add a documentation to the configuration trigger, not all variables are self-explaining.
• You set p_Point twice to the same value in the spell cast trigger.
• p_Unit Not equal to No unit ---> p_Unit will never be null, you don't have to make this check.
• The damagetype should be configurable.
• All used effects should be configurable.
• You should check wether the destructable is a tree or not, otherwise you would also kill bridges, etc.
• In general abilities have levels, which you should take into consideration.
• Aslong as you only distinguish between 1 and 2 use booleans instead of reals for the condition checks.

old

23:07, 18th Jan 2014
BPower:
- Store TriggeringUnit and PickedUnit into variables
- Variablenames must be more specific, just Point is unacceptable, because it might mess up other triggers.
- The loop shouldn't be running, when no instance is allocated.
- Overall very inefficient coding.

However it works and I would appreciate, if you work on your resource. PM me or leave a message in the thread, if you plan to improve the code and I'll point out weak points in detail for you.

 

[BPower]

- The periodic trigger should be turned off, if no instance of Advanced Bounce exists. In other words, turn off the trigger if p_functiongroup is empty and turn it back on if not.
- The variablenames have to be unique. Names like Real, Unit, Point are unacceptable. ---> AB_Time, AB_Temp_Loc , ... otherwise they might mess up with other triggers inside the map.
- Store PickedUnit into a variable, instead of calling GetEnumUnit() over and over again.
- In BounceAbilityCast the TriggeringUnit should be stored into a variable aswell.

Bouncing is a cool feature, but you have to put some work into your system. In its current state it will face a rejection.
You can ask for help in the forum Triggers&Skripts or maybe some keen helpers will post suggestions here.

 

[IcemanBo]

1.
In your cast trigger, you don't need to set Point (Position of triggering unit) and remove it two times.
Just remove it once after you don't need it anymore.

2.
If you only need these two first locations for getting angle, you can avoid this.
You can use a tan function to get angle between two points:

Atan2(y_2 - y_1 , x_2 - x_1) * bj_RADTODEG

You should use this in both of your triggers.

3. In your periodic trigger, same as said in '1.' but now for picked unit.
Also create a new unit variabe, because you obviously overwrite "Unit". You can use Unit_2 for example, for next unit.

4.
Don't use IntegerA/B for loops, they are less efficient as custom integer would be.

5.
I see you use points only for using GetLocationX/Y, so you can use SetUnitX/Y.
SetUnitX/Y is faster yes, but using locations here can be avoided with some maths:

• Custom script: call SetUnitY(unit, GetUnitY(unit) + offset * Sin(angle))
• Custom script: call SetUnitX(unit, GetUnitX(unit) + offset * Cos(angle))

Offset is your speed and angle is the direction.

6.
SetUnitX/Y is faster, but doesnt check map pathing.
You could init coordinates of world bounds, and then check them later to prevent unit from getting out of map accidently.

Spell itself looked really cool in game
I think it's a cool spell, go on improving code! +rep

 

[zv27]

Try this

function AngleBetweenXY takes real x1, real y1, real x2, real y2 returns real
    return 57.29582 * Atan2( y2 - y1, x2 - x1 )  // ->  bj_RADTODEG * Atan2( y2 - y1, x2 - x1 )
endfunction

formula 1,2 = first x1,y1 then x2,y2 [makes more sense]

set yourangle =  AngleBetweenXY( x_1, y_1, x_2, y_2 )

For Distance

function DistanceBetweenXY takes real x1, real y1, real x2, real y2 returns real
    return SquareRoot( ( x1 - x2 ) * ( x1 - x2 ) + ( y1 - y2 ) * ( y1 - y2 ) )
endfunction

For offset

function PolarProjectionX takes real source, real dist, real angle returns real
    local real x = source + dist * Cos(angle * 0.01745)
    return x
endfunction

function PolarProjectionY takes real source, real dist, real angle returns real
    local real y = source + dist * Sin(angle * 0.01745)
    return y
endfunction

Atan2(y_2 - y_1 , x_2 - x_1) * bj_RADTODEG

In this case, the formula is: 2,1

or easiest for you[because you probably GUI user]

• Set Your_Angle = (Atan2((y_2 - y_1), (x_2 - x_1)))

 

[Datnes]

Updated.

 

[Tank-Commander]

Dummy units which are no longer in use should be removed(removed as in the function) (if you need death effects to play then you should put a short timer that'll run after it was killed before it is removed.

All effect paths should be configurable.

• Special Effect - Create a special effect at p_Point using Objects\Spawnmodels\Human\HumanLargeDeathExplode\HumanLargeDeathExplode.mdl

This one was left out

The Spell should be able to be levelled (or at the very least, as a "system", be able to support more than exactly 1 type, really)

Conditional things like "can it remove dead bodies" and such should be boolean values, not reals. (even if there were more than either on or off, it would then need to be an integer -> variable efficiency and all that

Just a few notes

 

[Andser]

Nice, but not leakless and needs some more math
sin? cos? ? no....?
but anyways 4/5 (and practice your grammar it will help your maps)