Add an ability to unit aslong as it has a special buff!

[Dinodin]

Is there possible to add an ability to an unit with a special buff and remove it when it loses the buff? I would like to do an aura that gives them demolish as long as they have the buff and remove it instantly when the buff is gone. Can anyone help me with this and send me a map with the triggers so I can paste it in to mine?

 

[Element of Water]

That's actually really hard to do in GUI... I think you'll need JASS if you want the aura to be MUI.

 

[Starquizer]

EDIT

• Buff Check
  • Events
    • Time - Every 0.10 seconds of game time
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (YourUnit has buff YourBuff) Equal to True
      • Then - Actions
        • Unit - Add YourAbility to YourUnit
      • Else - Actions
        • Unit - Remove YourAbility from YourUnit

YourBuff: A Buff variable, YourUnit: A Unit variable.

 

[Element of Water]

Oh so simple. Well done, Starquizer, I was trying to formulate a long JASS script and you come out with this :0.

 

[Dinodin]

EDIT

• Buff Check
  • Events
    • Time - Every 0.10 seconds of game time
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (YourUnit has buff YourBuff) Equal to True
      • Then - Actions
        • Unit - Add YourAbility to YourUnit
      • Else - Actions
        • Unit - Remove YourAbility from YourUnit

YourBuff: A Buff variable, YourUnit: A Unit variable.

Many thanks! This will really help me to make my own auras! Just one question. Do I have to set those variables first? How then?

 

[Cokemonkey11]

They don't have to be variables, you can fill them in for the one you want (is what he was trying to say)

 

[Starquizer]

Those variables that I made are just to complete the triggers because you can't finish it if you have the unassigned variable (red underlined words). Thats all.

 

[Dinodin]

I don't get this to work What type of unit do I have to select? "Picked Unit" "Triggering Unit"??? I have tried those but they don't get the ability when they got the buff...

 

[Ranger21]

Well, you must pick all units on map with checking condition and after that adding ability.

For timer i recommend 1 sec.

And it can be done better in Jass, i can write for you, if you want.

if you know what is "raw-code"...

And it's not so easy, you must add units with ability to group and with another timer check buffs, if they don't have buff - remove ability.

Also there can be levels of ability.

Well huh... it requires some knowledge about you map and much better, if you learn jass.

PS: Better - use TWO global timers(For adding and removing buff) than creating triggers with events and conditions.

 

[Dinodin]

Well, you must pick all units on map with checking condition and after that adding ability.

For timer i recommend 1 sec.

And it can be done better in Jass, i can wrote for you, if you want.

if you know what is "raw-code"...

And it's not so easy, you must add units with ability to group and with another timer check buffs, if they don't have buff - remove ability.

Also there can be levels of ability.

Well huh... it requires some knowledge about you map and much better, if you learn jass.

Yes I know Raw-Code but I dunno JASS. Please send me the script and allow it to be on 4 lvls.

 

[Ranger21]

globals
timer TimerBuff=CreateTimer()
group BuffGroup
boolexpr FilterB
endglobals
// Ranger21 Code :P
function AddBuff takes nothing returns nothing
if GetUnitAbilityLevel(GetFilterUnit(), 'BUau')>0 then //Buff Raw-code ^^^
call UnitAddAbility(GetEnumUnit(),'ANb2')//Ability Raw-code !
call SetUnitAbilityLevel(GetEnumUnit(),'ANb2',level)//Ability Raw-code !
endif
endfunction

function FilterBuff takes nothing returns boolean
if IsUnitInGroup(GetFilterUnit(),BuffGroup) and GetUnitAbilityLevel(GetFilterUnit(), 'BUau') == 0 then //Buff Raw-code ^^^
call GroupRemoveUnit(BuffGroup,GetFilterUnit())
call UnitRemoveAbility(GetFilterUnit(),'ANb2')
endif
return GetUnitAbilityLevel(GetFilterUnit(), 'BUau') > 0 //Buff Raw-code ^^^
endfunction

function CheckBuff takes nothing returns nothing
call GroupEnumUnitsInRect(BuffGroup, bj_mapInitialPlayableArea, FilterB)
call ForGroup(BuffGroup,function AddBuff)
endfunction

//===========================================================================
function InitTrig_AddBuff takes nothing returns nothing
set FilterB=Condition(function FilterBuff)
call TimerStart(TimerBuff,1,true,function CheckBuff)
endfunction

That very simple script, but many raw-codes , you need write you buff and ability raw-codes.

Enjoy, and it is leakless, requires vJass for global boolexpr!

And it is one timer-using.

Must work with all levels of buff. (IF buff have levels > 1, i dunno, maybe some buffs have only one level for all ability levels...)

Do you have Jass Gen New Pack?

 

[Dinodin]

globals
timer TimerBuff=CreateTimer()
group BuffGroup
boolexpr FilterB
endglobals
// Ranger21 Code :P
function AddBuff takes nothing returns nothing
if GetUnitAbilityLevel(GetFilterUnit(), 'BUau')>0 then //Buff Raw-code ^^^
call UnitAddAbility(GetEnumUnit(),'ANb2')//Ability Raw-code !
call SetUnitAbilityLevel(GetEnumUnit(),'ANb2',level)//Ability Raw-code !
endif
endfunction

function FilterBuff takes nothing returns boolean
if IsUnitInGroup(GetFilterUnit(),BuffGroup) and GetUnitAbilityLevel(GetFilterUnit(), 'BUau') == 0 then //Buff Raw-code ^^^
call GroupRemoveUnit(BuffGroup,GetFilterUnit())
call UnitRemoveAbility(GetFilterUnit(),'ANb2')
endif
return GetUnitAbilityLevel(GetFilterUnit(), 'BUau') > 0 //Buff Raw-code ^^^
endfunction

function CheckBuff takes nothing returns nothing
call GroupEnumUnitsInRect(BuffGroup, bj_mapInitialPlayableArea, FilterB)
call ForGroup(BuffGroup,function AddBuff)
endfunction

//===========================================================================
function InitTrig_AddBuff takes nothing returns nothing
set FilterB=Condition(function FilterBuff)
call TimerStart(TimerBuff,1,true,function CheckBuff)
endfunction

That very simple script, but many raw-codes , you need write you buff and ability raw-codes.

Enjoy, and it is leakless, requires vJass for global boolexpr!

And it is one timer-using.

Must work with all levels of buff. (IF buff have levels > 1, i dunno, maybe some buffs have only one level for all ability levels...)

Do you have Jass Gen New Pack?

What do you mean with // Ranger21 Code ?? And do I delete the "BUau" script and insert the code of my buffs instead?

 

[Cokemonkey11]

yes, when he says ranger raw code he means go to object editor and cntrl+d to find the correct ones.

 

[Dinodin]

I have made like this but I get error...I have taken the code of the buff I wanted and the ability I want to add to the unit if it got the buff. What's wrong? Can anyone post a map with those triggers script as working?

globals
timer TimerBuff=CreateTimer()
group BuffGroup
boolexpr FilterB
endglobals
// Ranger21 Code :P
function AddBuff takes nothing returns nothing
if GetUnitAbilityLevel(GetFilterUnit(), 'BEar')>0 then //Buff Raw-code ^^^
call UnitAddAbility(GetEnumUnit(),'ANde')//Ability Raw-code !
call SetUnitAbilityLevel(GetEnumUnit(),'ANde',level)//Ability Raw-code !
endif
endfunction
function FilterBuff takes nothing returns boolean
if IsUnitInGroup(GetFilterUnit(),BuffGroup) and GetUnitAbilityLevel(GetFilterUnit(), 'BEar') == 0 then //Buff Raw-code ^^^
call GroupRemoveUnit(BuffGroup,GetFilterUnit())
call UnitRemoveAbility(GetFilterUnit(),'ANde')
endif
return GetUnitAbilityLevel(GetFilterUnit(), 'BEar') > 0 //Buff Raw-code ^^^
endfunction
function CheckBuff takes nothing returns nothing
call GroupEnumUnitsInRect(BuffGroup, bj_mapInitialPlayableArea, FilterB)
call ForGroup(BuffGroup,function AddBuff)
endfunction
//===========================================================================
function InitTrig_AddBuff takes nothing returns nothing
set FilterB=Condition(function FilterBuff)
call TimerStart(TimerBuff,1,true,function CheckBuff)
endfunction

 

[Pharaoh_]

Leave a blank line between the functions. :S

 

[Dinodin]

I got it to work now. I made like this

• Siege Aura
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in (Units in Full map region <gen>) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked unit) has buff Siege Aura ) Equal to True
          • Then - Actions
            • Unit - Add Siege Aura (Adding Ability) to (Picked unit)
          • Else - Actions
            • Unit - Remove Siege Aura (Adding Ability) from (Picked unit)

It works fine thx for all help!

 

[Wrel]

Understand that... picking every unit in the entire map, depending on how many units you have out, is taxing on the system's resources. (As common sense would dictate, don't quote me on anything.)

You also leak a unit group.

If you 'have' to do it this way, at least...

Set TempUnitGroupVariable = Every unit in playable map region matching condition (Picked unit has specific buff WhateverBuffName)
Loop Actions
If Then Else
If Picked unit has buff = True & Level of Siege Aura < 1 (less than one)
Then
Add Siege Aura to picked unit
Else
Remove siege aura from picked unit

And at the end of the trigger, destroy the TempUnitGroup Variable.
I don't feel like finding the custom script for it right now, but it's in the "Things That Leak" stickie thread.

This way, you're not stacking the same ability on the unit over and over and over.

 

[Dinodin]

Understand that... picking every unit in the entire map, depending on how many units you have out, is taxing on the system's resources. (As common sense would dictate, don't quote me on anything.)

You also leak a unit group.

If you 'have' to do it this way, at least...

Set TempUnitGroupVariable = Every unit in playable map region matching condition (Picked unit has specific buff WhateverBuffName)
Loop Actions
If Then Else
If Picked unit has buff = True & Level of Siege Aura < 1 (less than one)
Then
Add Siege Aura to picked unit
Else
Remove siege aura from picked unit

And at the end of the trigger, destroy the TempUnitGroup Variable.
I don't feel like finding the custom script for it right now, but it's in the "Things That Leak" stickie thread.

This way, you're not stacking the same ability on the unit over and over and over.

Can u please help me with this? I have played with my map with the triggers I used but it causes lag and sometimes crashes my game becase it's adding the ability over and over again. I need it to not add the ability if the unit already have it but still remove it if it loses the aura buff...