[Trigger] According to LeakTester these trigger leak.

[GenoHacker]

Their are 9 of these triggers. Blue, Teal, Yellow, Purple, Orange, Green, Pink and Gray.

Here is the list that leaktester gives. Are these leaks due to having 9 triggers that are functionally the same? [9 leaks per trigger, 9 triggers] or is it just a false positive?

List

Type: trigger
Trig_Kick_Blue_Actions [war3map.j:7098]
CustomDefeatBJ [war3map.j:7094]
CustomDefeatDialogBJ [Blizzard.j:5359]
CreateTrigger [Blizzard.j:5310]

Type: trigger
Trig_Kick_Blue_Actions [war3map.j:7098]
CustomDefeatBJ [war3map.j:7094]
CustomDefeatDialogBJ [Blizzard.j:5359]
CreateTrigger [Blizzard.j:5316]

Type: triggeraction
Trig_Kick_Blue_Actions [war3map.j:7098]
CustomDefeatBJ [war3map.j:7094]
CustomDefeatDialogBJ [Blizzard.j:5359]
TriggerAddAction [Blizzard.j:5318]

Type: trigger
Trig_Kick_Blue_Actions [war3map.j:7098]
CustomDefeatBJ [war3map.j:7094]
CustomDefeatDialogBJ [Blizzard.j:5359]
CreateTrigger [Blizzard.j:5321]

Type: triggeraction
Trig_Kick_Blue_Actions [war3map.j:7098]
CustomDefeatBJ [war3map.j:7094]
CustomDefeatDialogBJ [Blizzard.j:5359]
TriggerAddAction [Blizzard.j:5323]

Type: trigger
Trig_Kick_Blue_Actions [war3map.j:7098]
CustomDefeatBJ [war3map.j:7094]
CustomDefeatDialogBJ [Blizzard.j:5359]
CreateTrigger [Blizzard.j:5326]

Type: triggeraction
Trig_Kick_Blue_Actions [war3map.j:7098]
CustomDefeatBJ [war3map.j:7094]
CustomDefeatDialogBJ [Blizzard.j:5359]
TriggerAddAction [Blizzard.j:5328]

Type: trigger
Trig_Kick_Blue_Actions [war3map.j:7098]
CustomDefeatBJ [war3map.j:7094]
CustomDefeatDialogBJ [Blizzard.j:5359]
CreateTrigger [Blizzard.j:5331]

Type: triggeraction
Trig_Kick_Blue_Actions [war3map.j:7098]
CustomDefeatBJ [war3map.j:7094]
CustomDefeatDialogBJ [Blizzard.j:5359]
TriggerAddAction [Blizzard.j:5333]

Trigger

• Kick Blue
  • Events
    • Player - Player 1 (Red) types a chat message containing -kick blue as An exact match
  • Conditions
  • Actions
    • Sound - Play HeroLichPissed8 <gen>
    • Game - Defeat Player 2 (Blue) with the message: Kicked!
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in (Playable map area) owned by Player 2 (Blue)) and do (Unit - Kill (Picked unit))
    • Multiboard - Set the text for (Last created multiboard) item in column 1, row 3 to (MultiBoard_Colours[2] + (-Kicked- + ((Name of (Picked player)) + |r)))

• Kick Teal
  • Events
    • Player - Player 1 (Red) types a chat message containing -kick teal as An exact match
  • Conditions
  • Actions
    • Sound - Play HeroLichPissed8 <gen>
    • Game - Defeat Player 3 (Teal) with the message: Kicked
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in (Playable map area) owned by Player 3 (Teal)) and do (Unit - Kill (Picked unit))
    • Multiboard - Set the text for (Last created multiboard) item in column 1, row 4 to (MultiBoard_Colours[3] + (-Kicked- + ((Name of (Picked player)) + |r)))

The triggers follow the above layout, with somethings changing for the player that is being kicked, the trigger for gray has 2 events since gray can be spelled gray or grey

 

[Nichilus]

I do not see anything that should be leaking. Maybe the sound leaks, not sure.

Also, this line:

• Multiboard - Set the text for (Last created multiboard) item in column 1, row 4 to (MultiBoard_Colours[3] + (-Kicked- + ((Name of (Picked player)) + |r)))

won't work properly, because there is no (Picked player).

 

[PurgeandFire]

The reason it says there is a leak is because the "Game - Defeat ..." action creates a trigger + dialog and never destroys it.

But you shouldn't worry about it because (1) that is just how that GUI function was written (2) the game is already over at that point!

 

[Meatmuffin]

Hive leak tester itself says that it might show false positives.
It is meant to clean more obvious leaks like points and groups
and not force/dialog leaks, these ones hardly take up space.

 

[Bribe]

A mapmaker should only concern themselves with leaks on things which happen a lot. A spell must have 0 leaks as it can run quite a few times throughout a game, whereas something that leaks on Map Initialization isn't much of a concern unless you're creating thousands of handles.

 

[streetpunk]

Maybe you should store the player in an variable THEN defeat it using the stored variable as reference ?

EDIT: Just tested it, storing it in an variable didn't worked.