[vJASS] Access created item in hooked function

[NightSkyAurora]

Hi everyone

I am trying to get access to items that are created by "CreateItemLoc()" and "CreateItem()" functions

Lets say I have this:

hook CreateItemLoc CreateItemLocEx

and

function CreateItemLocEx takes integer itemId, location loc returns item
call BJDebugMsg(GetItemName(bj_lastCreatedItem)) // failed to get last created item from hooked function
    return bj_lastCreatedItem
endfunction

How can access that bj_lastCreatedItem within CreateItemLocEx()?

I also discovered that when the function below is placed inside CreateItemLocEx(), no items is created at all:

call TimerStart(t, 0.00, false, function DoNothing)

This applies to any attached function. The bottom line is, timers won't work at all

Thanks for your time

 

[Chaosy]

Probably because your hook executes before the item is created, no?

 

[NightSkyAurora]

Hooks are executed AFTER the original function is executed. Check this: Question about hooks

 

[ZiBitheWand3r3r]

please check for other natives/BJ functions that create item, Im not sure if thats all

globals
    timer               t
    rect                  r
    unit                  tempUnit=null
endglobals

hook CreateItemLoc CreateItemLocEx                                  //1
hook UnitAddItemByIdSwapped UnitAddItemByIdSwappedEx //2
hook CreateItem CreateItemEx                                            //3
hook UnitAddItemById UnitAddItemByIdEx                            //4
hook UnitAddItemToSlotById UnitAddItemToSlotByIdEx         //5
//-------------------------------------------------------------------
//-------------------------------------------------------------------
//these 2 for demo only
function IsItemIndexed takes item i returns boolean
    return GetItemUserData(i)>0
endfunction
function IndexItem takes item i returns nothing
    call SetItemUserData(i, 1)
endfunction



//-------------------------------------------------------------------
function CreateItem1 takes nothing returns item
    call BJDebugMsg(GetItemName(bj_lastCreatedItem))
    return bj_lastCreatedItem
endfunction
//-------------------1-------------------------------------------------------------
function CreateItemLocEx takes integer itemId, location loc returns nothing
    call TimerStart(t, 0.00, false, function CreateItem1)  
endfunction
//-------------------2-------------------------------------------------------------
function UnitAddItemByIdSwappedEx takes integer itemId, unit whichHero returns nothing
    call TimerStart(t, 0.00, false, function CreateItem1)
endfunction
//-------------------3-------------------------------------------------------------
function EnumItm takes nothing returns nothing
    local item i = GetEnumItem()
    if not IsItemIndexed(i) then
        call IndexItem(i)
        call BJDebugMsg("indexing item: " + GetItemName(i))
    endif
    set i=null
endfunction
function SearchInRect takes nothing returns nothing
    call EnumItemsInRect(r, null, function EnumItm)
endfunction
function CreateItemEx takes integer itemid, real x, real y returns nothing
    call MoveRectTo(r, x, y)  
    call TimerStart(t, 0.00, false, function SearchInRect)
endfunction
//-------------------4-------------------------------------------------------------
function SearchOnUnitThenInRect takes nothing returns nothing
    local integer x=0
    loop
        if not IsItemIndexed(UnitItemInSlot(tempUnit, x)) then
            call IndexItem(UnitItemInSlot(tempUnit, x))
            call BJDebugMsg("indexing item: " + GetItemName(UnitItemInSlot(tempUnit, x)) + " in slot " + I2S(x))
            return
        endif
        set x=x+1
        exitwhen x==bj_MAX_INVENTORY
    endloop
    //if non-indexed item not found on "tempUnit" unit (inventory may be full) then look at the ground
    call EnumItemsInRect(r, null, function EnumItm)
endfunction

function UnitAddItemByIdEx takes unit whichUnit, integer itemId returns nothing
    call MoveRectTo(r, GetUnitX(whichUnit), GetUnitY(whichUnit))  
    set tempUnit=whichUnit
    call TimerStart(t, 0.00, false, function SearchOnUnitThenInRect)
endfunction

//-------------------5-------------------------------------------------------------
function UnitAddItemToSlotByIdEx takes unit whichUnit, integer itemId, integer itemSlot returns nothing
    call UnitAddItemByIdEx(whichUnit, itemId)
endfunction

//===========================================================================
function InitTrig_func takes nothing returns nothing

    set t=CreateTimer()
    set r=Rect(0.00, 0.00, 256.00, 256.00)
endfunction

edit
forgot: you may want to exclude dead and hiden items

 

[NightSkyAurora]

When I create two items in a row using for example "CreateItemLoc()", CreateItem1() will only capture the second created item. I think that the timer waits for too long before displaying the last created item. Before the name of the first item is displayed, a second item can be created that overrides "bj_lastCreatedItem" from the first created item

 

[ZiBitheWand3r3r]

hmm, if so, the only way I can think of is to use
function SearchInRect takes nothing returns nothing
every time, plus (for UnitAddItemXXX functions):
loop thru inventory without exiting when non-indexed item found

 

[NightSkyAurora]

I have no problem to detect when (and what) items are created for a hero. The game provides events that can detect when a unit acquires an item. The SearchInRect might be an unprofessional approach but if that is the only way then I guess we have no choice. Thanks for your help!

 

[AGD]

I just checked again

hook DoNothing Nothing

//becomes

function h__DoNothing takes nothing returns nothing
    //hook: Nothing
    call sc___prototype1_evaluate(1)
call DoNothing()
endfunction

hooked BJs/Natives run after your custom function

 

[ZiBitheWand3r3r]

I have no problem to detect when (and what) items are created for a hero. The game provides events that can detect when a unit acquires an item.

what if inventory is full? you have to check on the groud every time to be sure you will not miss any item created

@AGD

hook DoNothing Nothing

//becomes

function h__DoNothing takes nothing returns nothing
    //hook: Nothing
//so here we have access only to argument(s) passed to original native/BJs, right?
//and to get what original native returns - we have to use 0sec timer

    call sc___prototype1_evaluate(1)
call DoNothing()
endfunction