A leaking condition?

[willydawiller]

well i have in my currently spawn typed map encountered an annoying problem.
it works pretty much as its supposed to untill the game ends since when that
happens a huge lag starts, and most players have to either close warcraft3
or their computer to make it end, i have been told that its the conditions that leak.

so i need some help with my spawn trigger im sure that there is some realy simple sollution
that i just fail to notice. And if someone can tell me how it should be then
best would be if the ansver was in gui cause i cant do jass yet.

• redvillagespawn
  • Events
    • Time - Spawntimer expires
  • Conditions
    • (Number of units in (Units owned by Player 1 (Red))) Less than 160
    • (Inn 0696 <gen> is alive) Equal to True
    • (Number of units in (Units owned by Player 1 (Red) of type Fort)) Less than or equal to 1
    • (Player 1 (Red) controller) Equal to User
  • Actions
    • Set quickusepoint = (Center of Red village <gen>)
    • Unit - Create 1 Militia for Player 1 (Red) at quickusepoint facing 0.00 degrees
    • Custom script: call RemoveLocation( udg_quickusepoint )

and same in JASS

function Trig_redvillagespawn_Conditions takes nothing returns boolean
    if ( not ( CountUnitsInGroup(GetUnitsOfPlayerAll(Player(0))) < 160 ) ) then
        return false
    endif
    if ( not ( IsUnitAliveBJ(gg_unit_n01X_0696) == true ) ) then
        return false
    endif
    if ( not ( CountUnitsInGroup(GetUnitsOfPlayerAndTypeId(Player(0), 'n01R')) <= 1 ) ) then
        return false
    endif
    if ( not ( GetPlayerController(Player(0)) == MAP_CONTROL_USER ) ) then
        return false
    endif
    return true
endfunction

function Trig_redvillagespawn_Actions takes nothing returns nothing
    set udg_quickusepoint = GetRectCenter(gg_rct_Red_village)
    call CreateNUnitsAtLoc( 1, 'h003', Player(0), udg_quickusepoint, 0.00 )
    call RemoveLocation( udg_quickusepoint )
endfunction

//===========================================================================
function InitTrig_redvillagespawn takes nothing returns nothing
    set gg_trg_redvillagespawn = CreateTrigger(  )
    call TriggerRegisterTimerExpireEventBJ( gg_trg_redvillagespawn, udg_Spawntimer )
    call TriggerAddCondition( gg_trg_redvillagespawn, Condition( function Trig_redvillagespawn_Conditions ) )
    call TriggerAddAction( gg_trg_redvillagespawn, function Trig_redvillagespawn_Actions )
endfunction

i hope i posted right and stuff

 

[Silvenon]

• Conditions
  • (Number of units in (Units owned by Player 1 (Red))) Less than 160
  • (Number of units in (Units owned by Player 1 (Red) of type Fort)) Less than or equal to 1

Those are the conditions that leak. You should put those "Units owned by Player 1 (Red)" and "Units owned by Player 1 (Red) of type Fort" in a group variable and destroy them.

The minor problem here is that you can't put those checks under "Conditions", but you can simply make an if then else (multiple actions). So something like this:

• redvillagespawn
  • Events
    • Time - Spawntimer expires
  • Conditions
    • (Inn 0696 <gen> is alive) Equal to True
    • (Player 1 (Red) controller) Equal to User
  • Actions
    • Set Group1 = (Units owned by Player 1 (Red))
    • Set Group2 = (Units owned by Player 1 (Red) of type Fort)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Number of units in Group1) Less than 160
        • (Number of units in Group2) Less than or equal to 1
      • Then - Actions
        • Set quickusepoint = (Center of Red village <gen>)
        • Unit - Create 1 Militia for Player 1 (Red) at quickusepoint facing 0.00 degrees
        • Custom script: call RemoveLocation( udg_quickusepoint )
      • Else - Actions
    • Custom script: call DestroyGroup( udg_Group1 )
    • Custom script: call DestroyGroup( udg_Group2 )

So those two remaining conditions can stay where they are.

 

[willydawiller]

thank you so much

bless your kind spirit(=rep)

 

[Dr Super Good]

As a condition is purly a function which returns a boolean converted into a boolexpr, you should be able to remove leaks in it via cleaver local use.

 

[Silvenon]

Yeah, but he doesn't know JASS yet.

 

[willydawiller]

• Conditions
  • (Number of units in (Units owned by Player 1 (Red))) Less than 160
  • (Number of units in (Units owned by Player 1 (Red) of type Fort)) Less than or equal to 1

Those are the conditions that leak. You should put those "Units owned by Player 1 (Red)" and "Units owned by Player 1 (Red) of type Fort" in a group variable and destroy them.

The minor problem here is that you can't put those checks under "Conditions", but you can simply make an if then else (multiple actions). So something like this:

• redvillagespawn
  • Events
    • Time - Spawntimer expires
  • Conditions
    • (Inn 0696 <gen> is alive) Equal to True
    • (Player 1 (Red) controller) Equal to User
  • Actions
    • Set Group1 = (Units owned by Player 1 (Red))
    • Set Group2 = (Units owned by Player 1 (Red) of type Fort)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Number of units in Group1) Less than 160
        • (Number of units in Group2) Less than or equal to 1
      • Then - Actions
        • Set quickusepoint = (Center of Red village <gen>)
        • Unit - Create 1 Militia for Player 1 (Red) at quickusepoint facing 0.00 degrees
        • Custom script: call RemoveLocation( udg_quickusepoint )
      • Else - Actions
    • Custom script: call DestroyGroup( udg_Group1 )
    • Custom script: call DestroyGroup( udg_Group2 )

So those two remaining conditions can stay where they are.

uhh can i do it like this instead?

• redvillagespawn
  • Events
    • Time - spawntimer expires
  • Conditions
    • (Inn 0696 <gen> is alive) Equal to True
    • (Player 1 (Red) controller) Equal to User
  • Actions
    • Set unitpicker = (Units owned by Player 1 (Red))
    • If ((Number of units in unitpicker) Greater than or equal to 160) then do (Skip remaining actions) else do (Do nothing)
    • Custom script: call DestroyGroup( udg_unitpicker )
    • Set unitpicker = (Units owned by Player 1 (Red) of type Fort)
    • If ((Number of units in unitpicker) Greater than 1) then do (Skip remaining actions) else do (Do nothing)
    • Custom script: call DestroyGroup( udg_unitpicker )
    • Set quickusepoint = (Center of Red village <gen>)
    • Unit - Create 1 Militia for Player 1 (Red) at quickusepoint facing 0.00 degrees
    • Custom script: call RemoveLocation( udg_quickusepoint )

 

[Silvenon]

Well, you can but it will leak your way. You can do this:

• redvillagespawn
  • Events
    • Time - spawntimer expires
  • Conditions
    • (Inn 0696 <gen> is alive) Equal to True
    • (Player 1 (Red) controller) Equal to User
  • Actions
    • Set unitpicker = (Units owned by Player 1 (Red))
    • Set unitpickerCount = (Number of units in unitpicker)
    • Custom script: call DestroyGroup( udg_unitpicker )
    • If (unitpickerCount Greater than or equal to 160) then do (Skip remaining actions) else do (Do nothing)
    • Set unitpicker = (Units owned by Player 1 (Red) of type Fort)
    • Set unitpickerCount = (Number of units in unitpicker)
    • Custom script: call DestroyGroup( udg_unitpicker )
    • If (unitpickerCount Greater than 1) then do (Skip remaining actions) else do (Do nothing)
    • Set quickusepoint = (Center of Red village <gen>)
    • Unit - Create 1 Militia for Player 1 (Red) at quickusepoint facing 0.00 degrees
    • Custom script: call RemoveLocation( udg_quickusepoint )

This way it won't leak.

Btw, unitpickerCount is an integer variable.

 

[Eleandor]

If ((Number of units in unitpicker) Greater than or equal to 160) then do (Skip remaining actions) else do (Do nothing)

You realize that if it's greater than or equal to 160, it will never get to the "Call destroygroup" part and thus leak?

 

[Silvenon]

That's what I said.... Well, actually, I didnt.

 

[M_Vegeta]

i think u very need those link

plz learn this dude it will remove most lag in your map

Learn about LEAKS it will also reduce lot lag in your map after u learn leaks u use
Leak tutorial link :
http://www.hiveworkshop.com/forums/trigger-gui-editor-tutorials-279/basic-memory-leaks-5889/

Things that leak :
http://www.hiveworkshop.com/forums/triggers-and-scripts-269/things-that-leak-35124/

leak checker link :
http://www.hiveworkshop.com/forums/tools-560/leak-check-1-3-a-62951/

 

[willydawiller]

You realize that if it's greater than or equal to 160, it will never get to the "Call destroygroup" part and thus leak?

now im confused, did the trigger that the other guy said, leak or not?
this is how my trigger looks now

• redvillagespawn
  • Events
    • Time - spawntimer expires
  • Conditions
    • (Inn 0696 <gen> is alive) Equal to True
    • (Player 1 (Red) controller) Equal to User
  • Actions
    • Set unitpicker = (Units owned by Player 1 (Red))
    • Set unitpickercounter = (Number of units in unitpicker)
    • Custom script: call DestroyGroup( udg_unitpicker )
    • If (unitpickercounter Greater than or equal to 160) then do (Skip remaining actions) else do (Do nothing)
    • Set unitpicker = (Units owned by Player 1 (Red) of type Fort)
    • Set unitpickercounter = (Number of units in unitpicker)
    • Custom script: call DestroyGroup( udg_unitpicker )
    • If (unitpickercounter Greater than 1) then do (Skip remaining actions) else do (Do nothing)
    • Set quickusepoint = (Center of Red village <gen>)
    • Unit - Create 1 Militia for Player 1 (Red) at quickusepoint facing 0.00 degrees
    • Custom script: call RemoveLocation( udg_quickusepoint )

 

[Silvenon]

Yeah, that's fine. It doesn't leak.