IsDestructableTree GUI 1.1

[Moderator]

Approved

 

[doomhammer99]

What a very Simple But Useful system

Create a Unit without using locations like this
Short trigger

• Custom script: set udg_dummy = CreateUnit(Player(15), 'hpea', 0, 0, 0)
• Custom script: call ShowUnit(udg_dummy, false)
• Custom script: call UnitAddAbility(udg_dummy, 'Aloc')

 

[Almia]

You should return a boolean that check if a destructable is a tree,not like returning a debug msg.

 

[Chaosy]

@Doomhammer: That would work indeed but it is supposed to be GUI not jass so I try to use as low ammout of custom scripts as possible.

@Almia: yes, maker suggested that too.

updated:
way 2 now uses a hashtable and returns a boolean insted of a msg.
the dummy unit in way 2 is now invulnerable
variable names changed

 

[Wrda]

The easiest system ever seen

 

[Chaosy]

I hope it is, would be rejected else. Ty for checking it out

 

[Almia]

Cache GetDestructableTypeId to add some speed.


This will be much more efficient:

[jass=]

//This is for the then block:
if not HaveSavedBoolean(hash,id,key) then
set bool = true
call SaveBoolean(hash,id,key,bool
else
set bool = LoadBoolean(hash,id,key)[/code]

This way,users dont need to load them by them selves

edit

Dont do above,nevermind that.
Just return the boolean likes this in one line

set bool = IssueTargetOrderById(checker, OrderId("harvest"), d) and IssueImmediateOrderById(checker, OrderId("stop"))

Now,we are talking about the speed

 

[Chaosy]

thanks for taking your time to improve my system but my answer on this is no.

As this is a converted system I want a minimal jass within it. The only reason that I use the hashtable in jass is because you cant use a variable as a key in GUI in my case "GetDestructableTypeId(udg_ISD_d)".

but idea to store into a variable is a little update I can do sometime when im less lazy¨

edit: tho I am working on a way to return the boolean without hashtables so it's easier to understand got a minor problem atm tho

 

[Almia]

In my suggestion,you dont need hashtable.

So follow it,we are talking about the speed here.

 

[Chaosy]

As said I avoid jass in GUI and I found a better way. Will update in 3 hours

edit: updated there was no need to use the hashtable i just store the variable in the system trigger and it detects just fine.

 

[Daffa]

The second method broke horribly if the default peasant has no harvest, unless the code at the thread is outdated and the new one add a harvest ability.