[GUI] Hero Swap System 1.1

[Moderator]

Approved

The system looks to be ok.
You could cache the string in HSS Check Chatstring
or use a hashtable to dramatically cut down the number of actions performed.

 

[Elprede]

This is a very nice system. However, you are leaking player groups, when the system sends messages. In addition, do not use predefined integers like Integers A/B because these integers can bug with other systems that use the same integers and are slower than your own integers. I recommend a different integer for each trigger.

Edit: After taking another look at the system's core, I found another problem. Custom script: set bj_wantDestroyGroup = true won't clean up any leak in this case, since all you doing is setting a unit group to a variable. You are not actually doing any actions with the unit group, therefore, the Custom script has no effect. Also, I have one question about your filtering. What happens if a computer player becames an actual player in game, how would the system detect that, so that the system works for that player again?

 

[HesitationSnow]

This is a very nice system. However, you are leaking player groups, when the system sends messages. In addition, do not use predefined integers like Integers A/B because these integers can bug with other systems that use the same integers and are slower than your own integers. I recommend a different integer for each trigger.

Edit: After taking another look at the system's core, I found another problem. Custom script: set bj_wantDestroyGroup = true won't clean up any leak in this case, since all you doing is setting a unit group to a variable. You are not actually doing any actions with the unit group, therefore, the Custom script has no effect. Also, I have one question about your filtering. What happens if a computer player becames an actual player in game, how would the system detect that, so that the system works for that player again?

Hey, thanks for report, fixed it all I believe?

Also, I do not think computer can become an actual player during a game.
A computer slot is static, like if green is a comp, he will always be a comp during that game.
If you mean computers swapping with users, well, their Hero_Specific[Player #] swaps as well, which is the unit array setting for the heroes to be swapped.

Edit: if you mean swapping with a leaver (disconnecter) freely, hold up i'll add that in .

 

[Wrda]

You should add a text saying where this system can be useful, because I don't really see where this can be useful, and others may not too :/

 

[HesitationSnow]

You should add a text saying where this system can be useful, because I don't really see where this can be useful, and others may not too :/

It's useful for swapping heroes!
Okay yeah, uhh, basically any map that centers around using a hero and has -all random hero mode.
Some maps being Dota, Hero Defense/Survival/Siege.
Well, it doesn't have to be heroes. TDs work too, if you have an -all random builders mode.

 

[HesitationSnow]

I have a question regarding sending the swap messages to the specific players.
Is my method safe of desyncs, or must I use local player?

 

[rulerofiron99]

You could maybe also add the -swapall command, which basically just tells the system to swap with everyone on your team.