Mass Teleport find target building

Marsal · Mar 13, 2011

Is there any JASS command to find the casted mass teleport's target building? If I use the target point of ability being cast the pont is targeted point and not the nearest building.

Axarion · Mar 13, 2011

You could try GetSpellTargetX() and GetSpellTargetY() or GetSpellTargetUnit()

Marsal · Mar 13, 2011

thanks i try it
like this? call Set TempLocation = GetSpellTargetUnit()

PurgeandFire · Mar 13, 2011

It should be:

Custom script: set udg_TempUnit = GetSpellTargetUnit()

Or something along those lines. The variable name should be TempUnit of type unit.

Although, you already have that in GUI. It is (Target unit of ability being cast).

Marsal · Mar 13, 2011

nope it's not working, neither the target unit thing

Axarion · Mar 13, 2011

Well then you have to use the targeted point and get the nearest building to this point.

http://www.wc3jass.com/viewtopic.php?t=100&highlight=closest

Marsal · Mar 13, 2011

that's a pity :S i though that there is a much more shorter way

PurgeandFire · Mar 13, 2011

Hmm... It seems to work just fine for me. Post your triggers, maybe something is going wrong with them.

Marsal · Mar 13, 2011

Untitled Trigger 001
- Events
  - Unit - A unit Starts the effect of an ability
- Conditions
  - (Ability being cast) Equal to Mass Teleport
- Actions
  - Custom script: set udg_TempUnit = GetSpellTargetUnit()
  - Set TempLocation = (Position of TempUnit)
  - Unit - Create 1 Dummy for Neutral Passive at TempLocation facing Default building facing degrees
  - Unit - Add a 10.00 second Generic expiration timer to (Last created unit)
  - Custom script: call RemoveLocation (udg_TempLocation)

Maker · Mar 13, 2011

You don't need custom script for the target

I tried a trigger like this and it worked fine:

Untitled Trigger 002
- Events
  - Unit - A unit Starts the effect of an ability
- Conditions
  - (Ability being cast) Equal to Mass Teleport
- Actions
  - Set unit = (Target unit of ability being cast)
  - Game - Display to Player Group - Player 1 (Red) the text: (String((Unit-type of unit)))

PurgeandFire · Mar 13, 2011

Same thing for me. But the problem is that Mass Teleport can be cast on a unit or point area, and then it will choose the closest unit if there are any. (Target point of ability being cast) always seems to work for me, but just note that if you use that and create the dummy, it will teleport all the units to the dummy instead of the closest building. The way to find which building is picked is probably to manually group all the units within the area and find the closest one. (I think that is how Mass Teleport works, I didn't test it thoroughly)

Marsal · Mar 14, 2011

well, that one works for me:

Teleport
- Events
  - Unit - A unit Starts the effect of an ability
- Conditions
  - (Ability being cast) Equal to Mass Teleport
- Actions
  - Set TeleCaster = (Triggering unit)
  - Set TelePoint1 = (Target point of ability being cast)
  - Set TeleGroup = (Units in (Playable map area) matching (((Matching unit) is A structure) Equal to True))
  - Set TeleDist2 = 1000000000.00
  - Unit Group - Pick every unit in TeleGroup and do (Actions)
    - Loop - Actions
      - Set TelePoint2 = (Position of (Picked unit))
      - Set TeleDist1 = (Distance between TelePoint1 and TelePoint2)
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        TeleDist1 Less than TeleDist2
        
        Then - Actions
        
        Set TeleDist2 = (Distance between TelePoint1 and TelePoint2)
        
        Set TeleUnit = (Picked unit)
        
        Else - Actions
      - Custom script: call RemoveLocation (udg_TelePoint2)
  - Set TelePoint3 = (Position of TeleUnit)
  - Unit - Create 1 Dummy for (Owner of TeleCaster) at TelePoint3 facing Default building facing degrees
  - Unit - Add a 2.60 second Generic expiration timer to (Last created unit)
  - Custom script: call RemoveLocation (udg_TelePoint1)
  - Custom script: call RemoveLocation (udg_TelePoint3)

Maker said:
You don't need custom script for the target

I tried a trigger like this and it worked fine:

Untitled Trigger 002

Events

Unit - A unit Starts the effect of an ability

Conditions

(Ability being cast) Equal to Mass Teleport

Actions

Set unit = (Target unit of ability being cast)

Game - Display to Player Group - Player 1 (Red) the text: (String((Unit-type of unit)))

It only works if you target the building itself. If you target the spell on the ground it does nothing.

Maker · Mar 14, 2011

Marsal2000 said:
well, that one works for me:

Teleport

Events

Unit - A unit Starts the effect of an ability

Conditions

(Ability being cast) Equal to Mass Teleport

Actions

Set TeleCaster = (Triggering unit)

Set TelePoint1 = (Target point of ability being cast)

Set TeleGroup = (Units in (Playable map area) matching (((Matching unit) is A structure) Equal to True))

Set TeleDist2 = 1000000000.00

Unit Group - Pick every unit in TeleGroup and do (Actions)

Loop - Actions

Set TelePoint2 = (Position of (Picked unit))

Set TeleDist1 = (Distance between TelePoint1 and TelePoint2)

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

TeleDist1 Less than TeleDist2

Then - Actions

Set TeleDist2 = (Distance between TelePoint1 and TelePoint2)

Set TeleUnit = (Picked unit)

Else - Actions

Custom script: call RemoveLocation (udg_TelePoint2)

Set TelePoint3 = (Position of TeleUnit)

Unit - Create 1 Dummy for (Owner of TeleCaster) at TelePoint3 facing Default building facing degrees

Unit - Add a 2.60 second Generic expiration timer to (Last created unit)

Custom script: call RemoveLocation (udg_TelePoint1)

Custom script: call RemoveLocation (udg_TelePoint3)

Remember to destroy the group. Or rather than using a variable, just use

Custom script: set bj_wantDestroyGroup = true
Unit Group - Pick every unit in (Units in (Playable map area) matching (((Matching unit) is A structure) Equal to True))
- Loop - Actions
  - ...

You could filter out dead and enemy structures.

And to add some nitpicking into this post, the max range that there can be is Sqrt(480^2+480^2) * 128 = 86889... -> 87000 so no need to set the TeleDist2 to a very high value

It only works if you target the building itself. If you target the spell on the ground it does nothing.

I though you meant that it doesn't work when targeting a building

Marsal · Mar 14, 2011

Heh I always forgot to destroy these groups ~.~ Thanks for the info.

dardas · Mar 15, 2011

Hmm.. how can you know this?
"the max range that there can be is Sqrt(480^2+480^2) * 128 = 86889."
And max range of what? :O

baassee · Mar 15, 2011

Because the max map size is 480x480. The distance formula is Sqrt(x*x + y*y), not sure of the 128. though

max casting range

Maker · Mar 16, 2011

dardas said:
Hmm.. how can you know this?
"the max range that there can be is Sqrt(480^2+480^2) * 128 = 86889."

Like baassee explained, the maximum dimensions (in tiles) of a map is 480x480. The sqrt part calculates how many diagonal tiles are needed to form a diagonal line across the map. One tile is 128x128 distance units. Therefore the equation calculates the length of the diagonal of the max sized map.

And max range of what? :O

The trigger finds the closest structure. The distance between. It picks all structures in the map and then compares the distance between the targeted point and a structure. If the distance is less than the current closest structure, then the new shorter distance is stored for the next comparison.

The initial value of the distance is set to a very high value intentionally, so that no matter how far away the targeted point and the structure are, the distance will always be less than the initial value.

However there's no need to set the initial value to a extremely high value, since the max distance can only be about 87000.

In reality the value is even slightly lower than that due to collision and masked map bounds.

baassee · Mar 16, 2011

I don't get why you even set this initial distance? Can't you just compare every single distance between the buildings and the point and just choose the shortest one?

Maker · Mar 16, 2011

Yes, it does comapre and choose the shortest.

The initial high value is needed for the first comparison to return true, no matter how far the structure is.

If the initial value was not set, then it could hold a value from previous check. or it could hold 0, and the script would fail to find the closest unit.

baassee · Mar 16, 2011

Still doesn't sound right to me. Should be a way to exclude that part.

Maker · Mar 16, 2011

One more thing, one should use set bj_wantDestroyGroup instead of storing the group into a variable.

baassee said:
Still doesn't sound right to me. Should be a way to exclude that part.

I'm all ears

baassee · Mar 16, 2011

I'll figure something out, give me a day or two.

chobibo · Mar 16, 2011

Are you guys talking about finding a unit nearest the target point? If so, store the first distance and compare it to the remaining units in the group, if the distance of another group member is shorter than that of the first set, then change the stored distance to the new distance.

Marsal · Mar 16, 2011

Maaaan it's already solved ~.~

baassee said:
I'll figure something out, give me a day or two.

Well if I insert a boolean that becomes false after the first unit picked from the group and stores it's distance I don't have to set an initial distance. However if I do this I have to reset the boolean ~.~

I don't know what's your problem with this trigger at all Q.o

baassee · Mar 16, 2011

The initial value range is my problem.

Marsal · Mar 16, 2011

I already lowered that one.

baassee · Mar 16, 2011

Marsal2000 said:
I already lowered that one.

That's not the problem. The problem is that it exists

It should be unnecessary to use it and should be removed.

chobibo · Mar 16, 2011

Use the first distance as the initial value and then compare the remaining distances with that.

Marsal · Mar 16, 2011

And how about this?

Teleport
- Events
  - Unit - A unit Starts the effect of an ability
- Conditions
  - (Ability being cast) Equal to Mass Teleport
- Actions
  - Set TeleCaster = (Triggering unit)
  - Set TelePoint1 = (Target point of ability being cast)
  - Set TeleGroup = (Units in (Playable map area) matching (((Matching unit) is A structure) Equal to True))
  - Unit Group - Pick every unit in TeleGroup and do (Actions)
    - Loop - Actions
      - Set TelePoint2 = (Position of (Picked unit))
      - Set TeleDist1 = (Distance between TelePoint1 and TelePoint2)
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        TeleDist1 Greater than TeleDist2
        
        TeleDist2 Not equal to 0
        
        Then - Actions
        
        Else - Actions
        
        Set TeleDist2 = TeleDist1
        
        Set TeleUnit = (Picked unit)
      - Custom script: call RemoveLocation (udg_TelePoint2)
  - Set TelePoint3 = (Position of TeleUnit)
  - Unit - Create 1 Dummy for (Owner of TeleCaster) at TelePoint3 facing Default building facing degrees
  - Unit - Add a 2.60 second Generic expiration timer to (Last created unit)
  - Custom script: call RemoveLocation (udg_TelePoint1)
  - Custom script: call RemoveLocation (udg_TelePoint3)

chobibo · Mar 17, 2011

That won't work, just keep it the way it is there's no problem with it. I was answering baassee's question.

@baassee

JASS:

globals
    real TempX=0.0
    real TempY=0.0
    real TempDist=0.0
    unit TempUnit=null
endglobals

function enumGroup takes nothing returns nothing
    local unit u=GetEnumUnit()
    local real x=GetUnitX(u)-TempX
    local real y=GetUnitY(u)-TempY
    local real distance=SquareRoot(x*x+y*y)
    
    if TempDist>distance then
        set TempDist=distance
        set TempUnit=u
    endif
    
    set u=null
endfunction
        
function GetNearestUnitInGroupFromXY takes real x, real y, group g returns unit
    local unit u=FirstOfGroup(g)
    
    set TempX=x
    set TempY=y
    
    set x=GetUnitX(u)-x
    set y=GetUnitY(u)-y
    
    set TempDist=SquareRoot(x*x+y*y)
    
    call GroupRemoveUnit(g,u)
    set TempUnit=u
    call ForGroup(g,function enumGroup)
    
    set u=null
    
    return TempUnit
endfunction

baassee · Mar 17, 2011

Awesome chobibo! Finally I can say this. Maker I told you so

Maker · Mar 18, 2011

That might not be a better solution. You're manipulating the group inside the function (removing a unit from the group).

First of group is slower that group enum if I remember correctly.

And the extra lines of code do not appeal my eye.

Ok, I admit that it can be done without setting the variable into a high value, but I'd still do it that way.

chobibo · Mar 18, 2011

Yeah it is if you're going to iterate through all the units inside the group, but it did not, it used ForGroup for that, it was necessary to retrieve the first unit to initialize the distance variable.

Also, FirstOfGroup and ForGroup are not functionally similar so there's no point in comparing them.

baassee · Mar 18, 2011

chobibo said:
Also, FirstOfGroup and ForGroup are not functionally similar so there's no point in comparing them.

Picking units in a group in two different ways? Any other differences?

chobibo · Mar 19, 2011

FirstOfGroup alone does not loop through units, while ForGroup does. FirstOfGroup isn't meant to be used for iterating through units, why the hell would they add the ForGroup if FirstOfGroup was supposed to do that already.

baassee · Mar 19, 2011

But still he is looping with firstofgroup to simulate a forgroup call

chobibo · Mar 19, 2011

Eh?, what are we talking about? I thought you were referring to my script.
I didn't use the FirstOfGroup to loop, I just retrieved the first unit from the group.

baassee · Mar 19, 2011

chobibo said:
Eh?, what are we talking about?group.

I have no idea. We're just continueing this discussion without knowing the subject

Mass Teleport find target building

Similar threads