Moderator
M
Moderator
14:39, 23rd Feb 2011
Bribe:
1. Conditions and actions may as well be combined into just conditions
2. The periodic method makes unnecessary function calls and should just be placed inside the "update" method.
3. Inlining the TriggerRegisterAnyUnitEventBJ is completely useless because "null" as a filter no longer leaks.
4. A widget's life is against 0.405, not 0.406, but that's not going to cause any realistic problems.
5. == true and == false are useless.
But it's not the end of the world, just make those changes some day. For now:
Status: Approved
Bribe:
1. Conditions and actions may as well be combined into just conditions
2. The periodic method makes unnecessary function calls and should just be placed inside the "update" method.
3. Inlining the TriggerRegisterAnyUnitEventBJ is completely useless because "null" as a filter no longer leaks.
4. A widget's life is against 0.405, not 0.406, but that's not going to cause any realistic problems.
5. == true and == false are useless.
But it's not the end of the world, just make those changes some day. For now:
Status: Approved