Moderator
M
Moderator
18:49, 22nd Nov 2009
TriggerHappy187:
I'm rejecting this permanently. There is nothing you can do to make this approvable.
TriggerHappy187:
I'm rejecting this permanently. There is nothing you can do to make this approvable.
- Ground Friction - Hashtable wrapper.
- Custom Value - Hashtable wrapper.
- CreepRevive - Nothing with vJass+Waits will get approved with me. This could also be extremely simplified.
- Get Player String Color - PCU works far better than your color functions (check Jass Submission Area).
- Get Player Language - Not even completed. This script was found on wc3jass anyways.
- Repace String - Simple function, not a script/system.
- Shadow - Cool, but I see no uses whatsoever.
- Camera Target Controller With Ploar Offset - You can inline the setting of x/y. This is also not a system/snippet. It's merely a coding practice.
- DamageUnitsInRange fails because..
- Dynamic Groups.
- You don't need to null damagedealer.
- Indentation is horrible. (could be jass tags)
- Uses firstofgroup loop.
- Null filters leak (at least until 1.24c goes final).
- You don't need to null u, it will end up null by the end of the loop