Zwiebelchen's Threat System 2.7

[Zwiebelchen]

Actually nevermind T_T still doesn't work, does your system not work with Neutral hostile? I have a trigger set to call ZTS_ApplyHealThreat(GetEventDamageSource(),GetEventDamageSource(), 200, false, true) on attack and it no work :/

All neutral hostile units need to be registered to the system. ApplyHealThreat only works on player units registered to the system.
The system works fine with neutral hostile.

Also another strange thing, is my trigger doesn't work on units that were in game at init, until they have died and are respawned by my system...mind = blown or are spawned by a trigger, which is weird because how are they added to threat table units after respawn or are they xD?

This is because dead units get cleared from the system. You need to register those units again upon revival or when created.

 

[Nosticus]

Ok, so I'm just going to post my triggers, since nothing else is working...
Trigger 1: Init
Events
Map initialization
Conditions
Actions
Player - Disable sleeping for all creeps
-------- Add units to damage detection trigger --------
Unit Group - Pick every unit in (Units owned by Neutral Hostile) and do (Trigger - Add to DamageDetect <gen> the event (Unit - (Picked unit) Takes damage))
Unit Group - Pick every unit in (Units owned by Player 8 (Pink)) and do (Trigger - Add to DamageDetect <gen> the event (Unit - (Picked unit) Takes damage))
-------- Setting up of all the participating units in the threat system --------
-------- Units where AI shall be taken over by the script have to be registered with AddThreatUnit --------
-------- Units that shall appear on ThreatUnit's threat lists have to be registered with AddPlayerUnit --------
Unit Group - Pick every unit in (Units owned by Player 9 (Gray)) and do (Custom script: call ZTS_AddPlayerUnit( GetEnumUnit() ))
Unit Group - Pick every unit in (Units owned by Player 11 (Dark Green)) and do (Custom script: call ZTS_AddPlayerUnit( GetEnumUnit() ))
Unit Group - Pick every unit in (Units owned by Neutral Hostile) and do (Custom script: call ZTS_AddThreatUnit( GetEnumUnit(), false ))
Unit Group - Pick every unit in (Units owned by Player 8 (Pink)) and do (Custom script: call ZTS_AddThreatUnit( GetEnumUnit(), false ))



Trigger 2amageDetect
Events
Conditions
Actions
-------- A simple damage detection function used to add threat in amount of damage dealt --------
Custom script: call ZTS_ModifyThreat(GetEventDamageSource(), GetTriggerUnit(), GetEventDamage(), true)


Trigger 3:Will of the Archpaladin
Events
Game - DamageEvent becomes Equal to 1.00
Conditions
(Level of Will of the Archpaladin (Paladin) Evasion for DamageEventSource) Equal to 1
Actions
Custom script: call ZTS_ApplyHealThreat(GetEventDamageSource(),GetEventDamageSource(), 400, false, true)
Game - Display to (All players) the text: Will of the Archpal...


Ok, so why does your system not work for me? units that are already made before the game is launched do NOT work, until they are re-spawned then they do if they are player pink, not Neutral Hostile, which is opposite of what you are saying.

 

[Zwiebelchen]

From just your triggers, I can not find a mistake. Post more, as there is definitely no bug with the system (I have used it for years now without any issues)!

Remember that the units owned by pink and neutral hostile will only react to gray and dark green units this way. The threat system will simply ignore all other players.
Also remember that any units of gray and dark green MUST be registered again after revival/creation/recreation.
Same goes for pink and neutral hostile.

 

[Vlad727]

Heya Zwiebelchen,
I was wondering the following things:

1. If I make a skill that applies a buff to the caster, what type of script call do I need to generate threat for the caster (static amount) to all nearby enemies?

2. Is it possible that edit the threat generation rate for specific hero's
Like a tanking class generates 125% threat while others have 100%?
This is just for their basic attacks.

3. Is it possible to make an effect (exclamation mark) if the target changes target.
so players have a visual warning if they pull a enemy.

4. this is the script call you used for the basic heal testing skill

• call ZTS_ApplyHealThreat( GetTriggerUnit(), GetSpellTargetUnit(), 100*GetUnitAbilityLevel(GetTriggerUnit(), GetSpellAbilityId()), true, true)

I use stat based skills that do not lvl, so would it then be
GetHeroAtributeStr ?
if not what is the proper syntax?

I really like the way your system functions, and I am sadly new to Jass and ruby, having only done the basic python isnt helping much.

So could you assist me.

 

[Zwiebelchen]

Heya Zwiebelchen,
I was wondering the following things:

1. If I make a skill that applies a buff to the caster, what type of script call do I need to generate threat for the caster (static amount) to all nearby enemies?

You can simply enumerate all enemies within X range and then use ZTS_ModifyThreat on each one.

You can also use the ZTS_ApplyHealThreat, however, this mechanic will split the threat over all units that are currently aggroed and is not based on range - it will use all currently aggroed units. Which means that if a spell creates 500 threat and there's 5 units around, all units will get a total of 100 threat applied.

You probably want the first solution.

2. Is it possible that edit the threat generation rate for specific hero's
Like a tanking class generates 125% threat while others have 100%?
This is just for their basic attacks.

Yes, just use a damage detection system and if the hero unit type is XYZ, apply 1.25 points of threat per damage instead of 1 point of threat per damage.

3. Is it possible to make an effect (exclamation mark) if the target changes target.
so players have a visual warning if they pull a enemy.

You can basicly compare if the threat slot unit at slot 1 before and after applying threat is not the same. If it is, then do nothing, if it isn't, display the exclamation mark.

I'd say write a small snippet for this, so you can use a one-liner when you need to apply threat.

4. this is the script call you used for the basic heal testing skill

• call ZTS_ApplyHealThreat( GetTriggerUnit(), GetSpellTargetUnit(), 100*GetUnitAbilityLevel(GetTriggerUnit(), GetSpellAbilityId()), true, true)

I use stat based skills that do not lvl, so would it then be
GetHeroAtributeStr ?
if not what is the proper syntax?

You can use GetHeroStr(GetTriggerUnit()).

 

[Vlad727]

Thx man, this is exactly what I needed (^w^) thx again

 

[Sunchips]

Edit: I fixed the problem I had.

However I noticed something else. If I run away from a unit so that they start running back to their camp position and I then beat them to the destination so that they start attacking me right when they have returned they never count as out of combat and the threat system does no longer work for that unit. This means the unit will chase me indefinately but if I attack him he will then return to his camp position and once again count in the threat system. I can't find a logic reason to why this happens, does anyone know what might be the cause here?

 

[Zwiebelchen]

Edit: I fixed the problem I had.

However I noticed something else. If I run away from a unit so that they start running back to their camp position and I then beat them to the destination so that they start attacking me right when they have returned they never count as out of combat and the threat system does no longer work for that unit. This means the unit will chase me indefinately but if I attack him he will then return to his camp position and once again count in the threat system. I can't find a logic reason to why this happens, does anyone know what might be the cause here?

All I can say is that it can't be a bug with the actual system, as I have been using it for years and never had this problem. For reference, see the demo map. It works properly there.

I think there is some other script interfering here. Is there a script running in your map that might unregister the units that leave combat? Remember: once added to the system, you don't need to remove those units again; there is no periodic trigger running for out-of-combat units, so no performance hit at all!

 

[Sunchips]

Thanks for the reply. It does work like it should in the testmap like you said but I tried deleting all triggers in my map except the ZTS and one trigger to add the units to the threat list as showed in the picture.

Even in this state this problem occurs in my map and I'm really not sure what I have set wrong :/
I tried making a debug trigger to get the combatstate of a unit and show it over their head every 0.5 seconds. When the unit was standing in its camp position it was registered as out of combat as it should be. When I aggro the unit it says it's in combat as it should be. But when I get too far away he returns to his camping position and then if I aggro it right when it comes back it says the unit is still out of combat even though it is hitting my unit. But if I modify the threat of my unit towards the enemy unit it will be registered in combat.

EDIT: I noticed this bug exists in your test map too. But it only occurs if I do not deal damage to the enemy unit and if the enemy unit is the only one in the camp.

EDIT Again: I noticed this bug even exists in your map Gaias Retaliation. I tried aggroing a wolf without damaging it. I then lured it away so that it starts returning. I then beat it back to its camp location instantly aggroing it once it returned. I made sure to not deal any damage to it and then I could lure it away out of its return range. This is not a common occurence but I know one instance that may cause this: One player aggros a creep and runs away so it starts returning. Another player is following the first player but is so far behind that it aggros the creep just as it had returned from chasing player one. Now the second player is followed by the creep until it attacks the creep.

Picture

 

[Zwiebelchen]

I'll investigate that. I have an idea what could be the cause for that... I think the event that usually makes the unit enter combat fires too early.

--> unit returns and turns invulnerable; is still considered retreating and not truly out of combat
--> unit gets unpaused
--> player enters range again; WC3 AI issues an order to it
--> event that renders unit in-combat fires, but doesn't do anything as it still hasn't properly left combat from the previous pull
--> unit is officially out of combat again now after the initial pull, even though it's already attacking

If that is indeed the problem, it's an easy fix; I'll upload a fixed version in several hours.

 

[Sunchips]

I'll investigate that. I have an idea what could be the cause for that... I think the event that usually makes the unit enter combat fires too early.

--> unit returns and turns invulnerable; is still considered retreating and not truly out of combat
--> unit gets unpaused
--> player enters range again; WC3 AI issues an order to it
--> event that renders unit in-combat fires, but doesn't do anything as it still hasn't properly left combat from the previous pull
--> unit is officially out of combat again now after the initial pull, even though it's already attacking

If that is indeed the problem, it's an easy fix; I'll upload a fixed version in several hours.

Sounds just about right. Chill chill.

 

[Zwiebelchen]

Updated to 2.7:
- Fixed a bug that sometimes did not properly render units in-combat if pulled again right after returning to camp position

 

[Sunchips]

Updated to 2.7:
- Fixed a bug that sometimes did not properly render units in-combat if pulled again right after returning to camp position

 

[Bribe]

Just wanted to leave this here for anyone looking to use this system with DamageEngine/UnitIndexer

 

[Zwiebelchen]

Thanks for the above contribution. I pretty much already use it in combination with UnitIndexer for my purposes, but I never made that build public.

At some point in the future, I might completely rewrite this to use a cleaner struct syntax approach. While the current implementation is very effective from a performance point-of-view, it couldn't hurt updating it for better readability.

 

[GIMLI_2]

hi, i dont get the AI part to work. if the NPC does not change its attack target, it wont receive a new order and wont cast the spell again, and i have no clue how to fix that in an easy way

 

[Zwiebelchen]

Post the code if you want help. Make sure to check out the demomap properly first; it has an example for spell AI.

 

[GIMLI_2]

Hidden

• Events
  • Unit - A unit owned by Neutral feindlich Erhält einen auf ein Objekt zielenden Befehl
  • Unit - A unit owned by Neutral feindlich Erhält einen Befehl ohne Ziel
• Conditions
  • (Unit-type of (Triggering unit)) equal to Snowpaw
• Actions
  • -------- Use ZTS_IsEvent in combination with Order Events to issue special orders (for example spells) --------
  • -------- Ordinary Wc3 spells will be used randomly be creeps even with the threat system active --------
  • -------- so you only need this when you want to manually order certain things --------
  • Custom script: if not ZTS_IsEvent() then
  • Custom script: return
  • Custom script: endif
  • Unit - Order (Triggering unit) to Orc-Troll-Berserker - 'Berserk'

it works just like in the test map, the event fires once the unit enters combat, but then it waits for a new order (which only happens if someone else takes over aggro)

 

[Zwiebelchen]

Maybe its something with the spell you're using. Can you post what it does?

What you can do to troubleshoot is trying to periodically get the current order of the unit after issueing the berserk order once. Does it go back to none, "smart" or "attack"? If not, then the system will not reissue any orders. It will only apply new orders if the unit has no order, a smart or an attack order. Even move orders will interrupt any automatic orders by ZTS.

 

[GIMLI_2]

It is just a basic spell that i used for testing. I think the first one was 'spawn ghost wolves' and the second 'berserk'. The unit immediately goes back to smart order after casting an ability. The thing is, it has the same result in your test map. There are 2 units that spawn ghostboars.(this is the example trigger for AI), but they also cast it only once when entering combat (or, as i said, when changing aggro target). Maybe it has sth to do with the new sharpcraft editor?

 

[Zwiebelchen]

Add a text message to your trigger to see if it runs periodically. This way you can find out if its something with your spell or with your trigger.

 

[Guineafowl]

I love this system. But I seem to have run into a problem.
My Neutral Hostile units won't cast their standard spells when registered in the Threat-System. If I try to remove them in-game, they will cast their spells regularly again.

From what I understand, they are still supposed to be casting regular spells when, even when they are controlled by your system. Do you have any idea what could be causing this?

 

[Zwiebelchen]

Neutral hostile will never cast regular non-autocast spells. Only computer players will.

 

[Guineafowl]

Usually I don't have any problem making Neutral Hostile cast spells based on abilities like Blizzard (Neutral Hostile), Frostbolt, Roar, etc.
And as I mentioned - whenever I remove a Creep from the system with your "call ZTS_RemoveThreatUnit(unit npc)" function. They will cast their spells at random again.

I just hoped the system wouldn't interfere, since you also wrote in your demo-map:

"Ordinary Wc3 spells will be used randomly by creeps even with the threat system active"

 

[Zwiebelchen]

Just to go sure: do you issue any orders manually in your game? I'm asking that because even with neutral hostile AI being different from computer player AI, neutral hostile should still occasionally use certain spells.

What spells are you using here? Remember that neutral hostile will not spam spells like Blizzard or Frost Bolt. The AI will only use them when the requirements are met (like having a cluster of attacking units for Blizzard, etc).

 

[Guineafowl]

I have some spells being handled manually. None that involve the units I'm trying to create here though.

So if I want threat-registered neutral hostile mobs to cast spells - I need to script them individually?
I suppose the solution would be to assign them to a computer player then, I just really would like the level of the mob to be easily visible in this map, the way they are on Neutral Hostile.

 

[Zwiebelchen]

Post your manual control triggers. Neutral hostile should use certain spells just fine.

 

[Guineafowl]

I don't think I have any triggers that interfere with neutral hostile behaviour actually.

Could I send you the map? In case you have access to the World Editor right now. I've set it up so it's immediately visible where the problem lies.

 

[Zwiebelchen]

You said you "have some spells being handled manually". Post these triggers.

 

[Guineafowl]

These are the kind I have. Triggered by events. But they haven't even fired yet when I test the creep behaviour.

 

[Guineafowl]

The Spells I handle manually are only dummy spells - part of custom abilities for the player, but they are not handled by Neutral Hostile. As such, the only time I manually order Neutral Hostile so far, is when I tell them to "Attack Move".

 

[Zwiebelchen]

You register your units with the wrong function here.

ZTS_AddPlayerUnit is for player controlled units only. Player units will never receive any orders by the system. Instead, player units are the units that can build up aggro on other the units added by the other registering function.
For the threat AI to actually control units and have threat lists, you must use ZTS_AddThreatUnit on these units instead.

Example:
Player 1 has and controls a hero that can build up threat on units owned by neutral hostile -> ZTS_AddPlayerUnit on that hero
Player Neutral Hostile controls creeps that have threat tables that Player 1's units can be listed in -> ZTS_AddThreatUnit on that creep

Also you are not applying any threat anywhere in these triggers. If you just register the units without ever applying threat, nothing is going to happen and the units behave as if they were never added to the system until they receive at least 1 point of threat from any source.
If you want threat applied by dealing damage, you need a damage detection system and apply threat via ZTS_ModifyThreat for the amount of damage dealt.


Besides, it's not smart to attack-move units away from their initial registry position. They will eventually return to their original spot if they move too far. From what I see here you have some kind of defense event going on? In that case, make sure the return range is high enough so that the units can move from P1 to P2 without getting out of range of the original spawn location.

 

[Guineafowl]

Thank you for answering.
You were right of course, about me using the wrong function on the spawned creeps. This was a minor trigger, so I hadn't really noticed the effect - (or lack thereof).
I am using Bribe's damage detection system, and it works just fine with this as well. Your debug window is really helpful for testing. Also I've kept the issues with move-orders in mind, but in these cases we're talking something like a 400 unit distance, so it's well within the return range.
Anyway, I guess it's something else I have that interferes with Neutral Hostile AI then, so I'll keep digging at that.
Thank you for helping me out - and for giving us this system of course.

 

[Guineafowl]

So I finally found a way for Neutral Hostile mobs to start using their normal abilities again. I had to change the attack order to "attack" instead of "smart" in your trigger. After doing this, the Neutral Hostile creeps would use their native spells again.

 

[Vasialalko]

Does not work on current patch

 

[Bribe]

Does not work on current patch

What doesn't work about it?

 

[Solemin]

Seems like AoE healing abilities (tested with Replenish and Essence of Blight) aren't registered initially. Attacking / using a different kind of healing spell (e.g. Heal) adds the unit to the registered ones and then continually increases threat when using those AoE healing abilities.

Any chance to lend a helping hand in how to add such healing abilities to the ApplyHealThreat function?

 

[Zwiebelchen]

Any chance to lend a helping hand in how to add such healing abilities to the ApplyHealThreat function?

Just register the cast event of these abilities and use the HealThreat function once on that unit. It does exactly what you want.

 

[Solemin]

Just register the cast event of these abilities and use the HealThreat function once on that unit. It does exactly what you want.

Easier said than done. Due to the functionality of mentioned abilities (Essence of Blight / Replenish) they do not have a target, but instead are point-blank AoE abilities. And due to not having a specific target, no allies on the threat-list are picked leading to the caster not being added to the threat list.
So, I'm searching a way to get the caster registered on the threat list even though he's not having an ability-target (ally).

For now I've done a workaround by dealing 0 damage to all units in radius x around the caster which adds the caster to the threat list. However, I was hoping to find a cleaner way ...

 

[Zwiebelchen]

Easier said than done. Due to the functionality of mentioned abilities (Essence of Blight / Replenish) they do not have a target, but instead are point-blank AoE abilities. And due to not having a specific target, no allies on the threat-list are picked leading to the caster not being added to the threat list.
So, I'm searching a way to get the caster registered on the threat list even though he's not having an ability-target (ally).

For now I've done a workaround by dealing 0 damage to all units in radius x around the caster which adds the caster to the threat list. However, I was hoping to find a cleaner way ...

Use ApplyHealThreat and set the caster for both source and target (as if you used a healing spell on yourself)
It will apply threat equally to all units currently aggroed.

 

[Zwiebelchen]

Does not work on current patch

It works fine.

 

[animalols]

After the new patch, I've noticed that if you make any changes to a map that has ZTS in it and try to run it, the map editor will disable all triggers related to the system. I noticed it even does it to the ZTS map itself.

I'm not experienced enough with JASS to know how to fix this. Anyone else experiencing this?

 

[Pyrogasm]

In the Trigger Editor window, navigate on the top bar to JassHelper > Enable vJASS and make sure that it's turned on. The WE has this setting defaulting to off for all maps now, but it updates on a per-map basis when you save.

 

[animalols]

Oh, that makes sense. Thank you so much!

In the Trigger Editor window, navigate on the top bar to JassHelper > Enable vJASS and make sure that it's turned on. The WE has this setting defaulting to off for all maps now, but it updates on a per-map basis when you save.

 

[skemmerblef]

So I'm using the NewGen WE and am having the same issue Sunchips had all those years ago; tried the suggested fix and still can't get the demo map to load either from the editor or WC3 itself. Compiling results in 100 errors.

Anyone have a fix? I'm well out of my league here. Thanks.

 

[Pyrogasm]

Why are you trying to use NewGen in 2024? Are you sure JASSHelper and related utilities are enabled?

 

[skemmerblef]

Why? Dunno, thought it was correct lol. Before that I was using the stock WC3 editor. I don't have reforged so it's unclear at times exactly what is needed and where; I had to google what a vJASS Preprocessor was and that lead me to using NewGen. I'm pretty sure I have everything I need to have enabled enabled, at least for this system; ran the WE as admin as usual, JassHelper is enabled, as is UMSWE, and I'm getting the pictured issues. Do I need other utilities to get this working? If so which ones?
Thanks.

 

[Pyrogasm]

You do not need to own Reforged to update your game and gain access to the modern Lua-enabled editor. There are, of course, issues with the e official editor too but you gain a massive amount of functionality.

NewGen has been deprecated for many years and you should not be using it, since it was ultimately a collection of editor hacks being held together with digital duct tape.

Looking at the error window it seems that this code was written before 1.24b took away arbitrary typecasting (removal of the “H2I return bug”) and so each of those error lines will need to be manually resolved by fixing the return value or properly typecasting it where appropriate (you still can with a hashtable, as far as I am aware). It’s my intuition that this simply wouldn’t compile in any editor, NewGen or otherwise.

 

[skemmerblef]

Well, even if I can't get this threat system running (bummer!), it seems my current version is 1.21 so I'm definitely outdated. On HIVE's wc3 download archive I see a patch for 1.31.1, is that the "current" version folks work with? Just wanna be sure I'm up to date on things.

Sorry for all the questions (and thank you for the help!).

 

[Pyrogasm]

1.36.2.21498 is current on Battle.net; it should update through the BNet launcher. I've just now realized that the errors in your screenshot are actually errors in Blizzard.j rather than within ZTS. That's a NewGen artifact because something isn't properly loaded/present/working/depends on some other hack that isn't working properly/etc. This system compiles just fine with no issues in the current WE.