[JASS] World editor crashes

[Beier]

I recently decided to have a look at JASS, and I made a function that should change the texture of the ground taking a rect, and the type to change into.
I placed it in the general section (the part that gets loaded after global variables).
My problem is that when I try to save the map, worldeditor throws an unhandled access violation exception, so if any experts here can spot an error in my code, it would be greately pariciated

function ChangeGroundRecrusively takes integer x0, integer x1, integer y0, integer y1, integer t returns nothing
    local integer height = y1 - y0
    local integer width = x1 - x0
    local integer smallest = height
    if width < height then
        set smallest = width
    endif
    call SetTerrainType(x0 + smallest/2, y0 + smallest/2, t, -1, smallest, 1)
    
    
    if height > width then
        set height = height
        call ChangeGroundRecrusively(x0, x1, y0 + smallest, y1, t)
    
    elseif height < width then
        call ChangeGroundRecrusively(x0 + smallest, x1, y0, y1, t)
    endif    

endfunction


function ChangeGround takes rect r, integer t returns nothing
    call ChangeGroundRecrusively(GetRectMinX(r), GetRectMaxX(r), GetRectMinY(r), GetRectMaxY(r), t) 
endfunction

 

[xD.Schurke]

you created a endless loop by calling the function again,agian and again

 

[Beier]

no, its not an endless loop as I always call it with a smaller square, and if the width equals the height, no more calls are made.
The only way to go in an endless loop is if the height or width is 0, but if the initial input doesn't have a width or height of 0, the subsequent calls won't have it either, since I add a number less than the width (if height is smallest) to x0, resulting in a new width of atleast 1 (since i'm using integers)

At any case, it shouldn't call the function when saving the map..

 

[Beier]

I wrote another function to do it, and it works. I have had crashes with other functions though. Maby this is because the worldeditor syntax checker sucks? That it tries to compile invalid code.

 

[TriggerHappy]

WE Syntax checker does suck, get jass new gen pack.

Also, highlight your code with

 tags, So i can read it ^_^

 

[Beier]

jass new gen pack, where do I find that? cant see it in the tools section.
Im currently using JassCraft for writing jass functions, but would like something with some error responses other then "syntax error!". Also it would be nice if the editor could open the w3x file and import all global variables and functions.

 

[TriggerHappy]

Jass NewGen Pack v5b - Wc3campaigns

 

[Beier]

Niice! way better then that default notepad editor.

 

[TriggerHappy]

It also allows the usage of vJASS.

JassHelper 0.9.F.0

Documentation there.