World Bounds v1.3

[Moderator]

15:02, 1st Jul 2013
PurgeandFire: Changes made. Approved!

 

[Almia]

~Reserved

 

[HammerFist132]

+rep for gui , making it avaible for everyone. Btw we can use it to detect bounds of playeable map area?

 

[Almia]

Yes, and this take the region of playable map area and the blight border,overall, the whole map.

edit
Preview for this resource is broken. Can't fix it.

 

[Losam]

What this?!?! Whath the Almia's resource does?

 

[Bluebay]

Can you please explain/describe this ?

 

[maddeem]

I like the vjass version better D:
May I suggest that you make the variables WB_MinX/MaxX/MinY/MaxY
Without the WB_ in front of it. I doubt anyone would have the user defined globals Max/Min x/y
Just sayin.
Same goes for Center variables. Nothing else to critique. FYI Nestharus's version uses integers instead of reals. Dunno if you noticed it.
4/5 - Until I get a response justifying your variables or changing them.

 

[Almia]

I don't think so
Let it private as it is. Some maps that has multimaps may have use the MaxX,MaxY etc.

I do noticed that it uses integers,however,GUI doesn't allow one to typecast integers to reals directly. (Integer can be typecasted to reals if you use them as of how you used reals). So,I chose reals so that users can easily use this than opening Convert - Integer to Real all over again,

For those beginners who doesn't know what is the function of this snippet,It allows you to retrieve constant values of the World Bounds or the Map Area,this includes the max X of the World Bounds, Max Y, etc.

 

[maddeem]

I don't think so
Let it private as it is. Some maps that has multimaps may have use the MaxX,MaxY etc.

I do noticed that it uses integers,however,GUI doesn't allow one to typecast integers to reals directly. (Integer can be typecasted to reals if you use them as of how you used reals). So,I chose reals so that users can easily use this than opening Convert - Integer to Real all over again,

Fair enough. 5/5

 

[Magtheridon96]

World -> WB_World

 

[Zeatherann]

What is this? just storing the data of a rect, how is this a system/spell/creditable thing?

I do this in my map, but no credits are given. This should be in the JASS section, not the spell section.

Btw: *.5 is faster than /2

 

[Almia]

It is just the same. Blizzard Math is slow(source : Nes)
This is not rightful in the Jass section(read section title),it is too obvious that this is GUI.
If you are making some Spell Generator systems(dummy system, projectile system, knockback system,etc.) this the system you are going to use,this is very important.
@Magtheridon96
Wut.
Why not let it stay there? I haven't seen an open map with "World" as a name of a var.

 

[Magtheridon96]

Because it's not consistent with all the other variables.

If all publicly accessible variables are going to have a WB_ prefix, then World should too.

~Software design~

 

[Almia]

Ok fair enough.
Updating.

 

[Zeatherann]

my maps use a world variable lol

 

[PurgeandFire]

Remove the rect at the end of the trigger. Also, instead of using the custom script to set the centerX/centerY, use GUI functions to set the variable. That way, you don't have to have those two lines at the end of the trigger (meaning, implementation is even easier).

EDIT: You also need an image.

 

[Zeatherann]

Still don't get the usefulness of this as a resource.

 

[Almia]

@PurgeAndFire
Then, World will be useless :V

@Zethereann
I use it for Spell Generator purposes, samples are Missile System and Jump System.

 

[Zeatherann]

Oh, I understand the usefulness of having something like this in a map, but as a resource on hive?

 

[Almia]

Yep.
I think Ill add some functionalities.

 

[Almia]

Updated.
Added World Bounds functions
Renamed World to WB_World
Added a simple preview

 

[Zeatherann]

Now I can find use in this.

 

[PurgeandFire]

@Almia: Whoops. My mistake. I forgot people might use that.

You can remove the CenterX = 0.00 and CenterY = 0.00 now.
Also:

function BoundY takes real y returns real
    if udg_WB_MinY > y then
        return udg_WB_MinY
    elseif udg_WB_MaxX < y then // change to udg_WB_MaxY
        return udg_WB_MaxY
    endif
    return y
endfunction

And SetBoundedY() should use SetUnitY() not SetUnitX(), and it should use BoundY() instead of BoundX().

Fix those and I'll approve.

 

[Chaosy]

useful, a system of yours that I consider GUI friendly enough.

4/5 from me

 

[Losam]

Well, what this feature does Almia? Could you explain please?

 

[Tonex]

I find this too simple; it would take a person only slightly less time importing it than writing it... Though I guess since this is already prewritten the user won't have to worry about accidental bugs.

 

[Almia]

@Purgey
Damn typos XD

 

[Zeatherann]

Still agree with Tonex, but it'll be allowed just because.

 

[Almia]

Updated.

 

[Chaosy]

The thing is, not many knows how to use it. Therefore the system is useful.

Also, rather a simple system than an advanced system. simple +useful=good system

 

[Almia]

@Chaosy
Correct

 

[Tonex]

@Chaosy ...But if they don't know of it, how ill they know to find this resource?

 

[Chaosy]

If we are like that we can ignore 90% of the spell section?

How will I find the witchers camera system when I dont know how it works?

Anyway, they can get linked here if they ask stuff in the WE help zone. Or simply browse the spell section randomly. I do that alot

 

[Tonex]

Oops, thought you said about it as opposed to how to use it.

 

[Zeatherann]

The thing is, not many knows how to use it. Therefore the system is useful.

Also, rather a simple system than an advanced system. simple +useful=good system

I don't understand that statement.

 

[Nestharus]

It is just the same. Blizzard Math is slow(source : Nes)

No it's not...

Complexity of operations are as follows (from fastest to slowest)

Addition
Subtraction
Multiplication
Division


There is a huge difference in complexity between multiplication and division.

You'd only want to use division over multiplication to keep integers as integers (4/2 vs R2I(4*.5))

Yep.
I think Ill add some functionalities.

Please don't -.-. Super packs don't make you cool.

 

[Zeatherann]

World Bounds should contain functionality to deal with such right? Like clipping x/y to the rect.

 

[maddeem]

If it's going to be GUI make it pure GUI. None of this Jass shit as a side dish, unless you're going to make this pure Jass. Seriously, make up your mind t.t

 

[Zeatherann]

The GUI part is for the variable copy.

 

[Tonex]

I figure that as long as the user uses GUI to interface with the the system, you might as well call it GUI, as it's something GUI users can use.

 

[PurgeandFire]

Still an issue with:
call SetUnitY(u, BoundX(y))
To:
call SetUnitY(u, BoundY(y)).

 

[maddeem]

The GUI part is for the variable copy.

GUI / Triggers

I think not.


Edit:
The GUI part is the core of the system. Without it the addon functions provided are rendered useless. What I was trying to say in that post above is that if this becomes vanilla Jass GUIers won't use it. Though I would imagine those who still use GUI would find no use for such a resource. If the added functionality is the only thing that attracts GUI users, then it should be in GUI. As a Jass resource Nestharus beat it out with his original vJass world bounds. As a GUI resource, it loses functionality. If the majority of the resource is coded in Jass then I believe it should be labeled a Jass resource.

Also:

~Reserved

Why?

 

[Almia]

@maddeem
For notifs. Since August 2012
@Purgey
Should I buy some eyeglasses?

 

[Chaosy]

I don't understand that statement.

If you dont know how to use the worldbounds native since you hate jass like I used to, in that case this system would be useful.

 

[Almia]

Updated.
Fixed Typo.

 

[Lign]

I still don't know how can I use this system to check a point is in playable map. Can anyone help me?