Wind Dude v2.0

[Ethereal_]

Hoh boi o boi cant wait for that juicy criticism because I never wanted to stop makin this pack

 

[KILLCIDE]

A JASS configuration for GUI triggers...? Uhh that's odd. Why not just stick with a normal GUI configuration for a GUI spell?

I will maybe review this in a few days if no one else gives you any feedback. For now, please get rid of that UMSWE GUI / Triggers tag. They are not allowed in the Spell section.

 

[Ethereal_]

I'll get rid of the tags, my bad, but the reason I used jass config is because it's easier, for me anyway, to enter values.

 

[KILLCIDE]

Meh I guess I went ahead and also removed the JASS tag since the core of the spells are in GUI.

 

[Ethereal_]

Alright , just trying to get used to everything again, been a while

 

[KILLCIDE]

Are all the imports really necessary? on a side note, you have the wrong paths for all of the disabled icons. To get back on topic, you have a lot to work on:

• That is way too many dummy units for a spell. Two of them also look really random (Heal dummy and "the file id b**tch). Please look into using Vexorian's dummy. You can literally just use one dummy for all these spells
• Who is credited for the knockup system? Do you have a link of where you got it?
  
  
• Dashing Steel
  • Is DS_DashSpeed over a second or every loop iteration? I would add a comment about it
    
  • I would add extra configurables for the attachment points of the effects. Some effects look good on overhead, some look good in origin, etc
  • The ability should not be hardcoded
  • Storing DS_DashSpeed into DS_Speed looks really useless. You can just reference DS_DashSpeed from the get-go
  • Use Multiple action If/Then/Else
  • You should only be turning on the loop when you have to
  • Almost all the variables are way too generic. Add some sort of prefix (ex: DS_Caster, DS_Unit) to avoid clashing with people's map
    
  • All of your dummy units are hardcoded
  • You leak a location here:
    
    • Unit - Create 1 DTNado Dummy for (Owner of Unit) at (Position of Unit) facing CurrentAngle degrees
  • I would avoid using (Matching unit) to filter out units. Instead, use an If/Then/Else inside the loop. You can read more about it here
  • Store data you will reference multiple times so you do not have to keep calling the function (ex: Owner of caster, picked unit)
  • You leak a location here:
    
    • Unit Group - Pick every unit in (Units within DS_DRange of (Position of Unit) matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is alive) Equal to True) and ((((Matching unit) belongs to an enemy of (Owner of Unit)) Equal to True) and (((Matching unit) is in and do (Actions)
  • Attack type & Damage type should be configurable
  • You should only check to turn off the loop when you flush the hashtable, not every single loop iteration
    
    
• Tempest
  • Please add descriptions to your configurables. Not everyone has played League of Legends and or know who Yasuo is
  • The ability should not be hardcoded
  • All of your dummy units are hardcoded
    
  • Almost all the variables are way too generic. Add some sort of prefix (ex: TMP_Caster, TMP_Unit) to avoid clashing with people's map
    
  • You should only be turning on the loop when you have to
    
  • What is 300 for? You should avoid using hardcoded values. If you have to, at least add a comment for what they are meant for
    
    • Hashtable - Save 300.00 as (Key distance) of UnitKey in GS_Hash
  • ^ same thing applies to this:
    
    • Set Counts = 9
  • I would add a configurable for the loop timer since you use it in a few arithmetic operators. If someone were to change just the event, the spell will break
  • You leak two locations here:
    
    • Unit - Create 1 GT Dummy2 for (Owner of Unit) at (Position of Unit) facing (Position of Unit)
  • Moore hardcoded values. You also leak a location here:
    
    • Unit Group - Pick every unit in (Units within 312.00 of (Position of Unit) matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) belongs to an enemy of (Owner of Unit)) Equal to True) and (((Matching unit) is dead) Equal to False)))) and do (Actions)
  • I would avoid using (Matching unit) to filter out units. Instead, use an If/Then/Else inside the loop. You can read more about it here
  • Store data you will reference multiple times so you do not have to keep calling the function (ex: Owner of caster, picked unit)
    
  • You leak a location here:
    
    • Environment - Create a 1.00 second Temporary crater deformation at (Position of Unit) with radius 512.00 and depth 264.00
  • ^ In addition, Terrain Deformations leak. I would avoid using them.
  • You should only check to turn off the loop when you flush the hashtable, not every single loop iteration
    
    
• Wind Technique
  • Please add descriptions to your configurables. Not everyone has played League of Legends and or know who Yasuo is
  • I would add extra configurables for the attachment points of the effects. Some effects look good on overhead, some look good in origin, etc
  • The passive ability should not be hardcoded
  • The animation should not be hardcoded:
    
    • Animation - Play WT_Unit's spin animation
  • Store data you will reference multiple times so you do not have to keep calling the function (ex: Owner of caster, picked unit)
  • I would avoid using (Matching unit) to filter out units. Instead, use an If/Then/Else inside the loop. You can read more about it here
  • Attack type and Damage type should be configurable
  • Remove the Do Nothing function. It's useless and literally does what it sounds like
  • The animation should not be hardcoded:
    
    • Animation - Play WT_Unit's attack slam animation
• Last Breath
  • I would add extra configurables for the attachment points of the effects. Some effects look good on overhead, some look good in origin, etc
  • The ability should not be hardcoded
  • I would avoid using (Matching unit) to filter out units. Instead, use an If/Then/Else inside the loop. You can read more about it here
  • You leak a force here:
    
    • Game - Display to (All players matching ((Owner of Caster) Equal to Owner)) for 3.00 seconds the text: |cff00ff00No knocke...
  • Almost all the variables are way too generic. Add some sort of prefix (ex: LB_Caster, LB_Unit) to avoid clashing with people's map
  • Last Breath loop should not always be on. It should only be on when there is an active instance running
  • Store data you will reference multiple times so you do not have to keep calling the function (ex: Owner of caster, picked unit)
  • A looot of hardcoded values in the isKnockedUp group loop. I know that they have to be very specific, but you just made it so that it will only work for the imported model in the map
  • I would add a configurable for the loop timer since you use it in a few arithmetic operators. If someone were to change just the event, the spell will break
  • Attack type and Damage type should be configurable
  • You leak a location here:
    
    • Unit - Create 1 LB Effect Dummy for (Owner of Unit) at (Position of Unit) facing Default building facing degrees
  • You should only check to turn off the loop when you flush the hashtable, not every single loop iteration

Set to Awaiting Update

 

[Ethereal_]

ALRIGHTY

I've updated everything except Last Breath because I have a question

Could you tell me which hardcoded values in the isKnockedUp group I need to change?

• Should I change the flying height speeds from 0.00 to a configurable value?
  • Animation - Change LB_Unit flying height to LB_CasterHeight at 0.00
• Of course I know to change all of the "origin"s on the special effects to a configurable value
• Should I change the time at which the special effects an animations occur? I did that so it would be evened out over three strikes. Also I will change the "Picked Unit" later
  Three Strike Triggers

  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • LB_CurrentDuration Equal to LB_KnockDuration[LB_Level]
    • Then - Actions
      • Special Effect - Create a special effect attached to the origin of DS_Unit using LB_EffectCaster2
      • Special Effect - Destroy (Last created special effect)
      • Special Effect - Create a special effect attached to the origin of (Picked unit) using LB_TargetEffect[1]
      • Special Effect - Destroy (Last created special effect)
      • Animation - Reset LB_Unit's animation
      • Animation - Play LB_Unit's LB_Animation[1] animation
    • Else - Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • LB_CurrentDuration Equal to (LB_KnockDuration[LB_Level] - (0.03 x (LB_KnockDuration[LB_Level] x 16.00)))
    • Then - Actions
      • Special Effect - Create a special effect attached to the origin of (Picked unit) using LB_TargetEffect[2]
      • Special Effect - Destroy (Last created special effect)
      • Animation - Reset LB_Unit's animation
      • Animation - Play LB_Unit's LB_Animation[2] animation
    • Else - Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • LB_CurrentDuration Equal to (LB_KnockDuration[LB_Level] - (0.03 x (LB_KnockDuration[LB_Level] x 29.00)))
    • Then - Actions
      • Special Effect - Create a special effect attached to the origin of (Picked unit) using LB_TargetEffect[3]
      • Special Effect - Destroy (Last created special effect)
      • Animation - Reset LB_Unit's animation
      • Animation - Play LB_Unit's LB_Animation[3] animation
    • Else - Actions
• I've also already changed the distance and degree at which I move the caster to configurable values as well (Changing picked unit later)
  • Unit - Move LB_Unit instantly to ((Position of (Picked unit)) offset by LB_DistanceFromTarget towards LB_Degrees degrees)
• Also instead of changing flying heights to zero should I change them to "Flying Height (Default)"?
  • Animation - Change LB_Unit flying height to 0.00 at LB_SlamSpeedCaster

Edit: Also how would I use 1 dummy for all the spells? Could I create a special effect on the dummy, store it, and then remove it later?

 

[KILLCIDE]

Could you tell me which hardcoded values in the isKnockedUp group I need to change?

Did you make the knockup system yourself? You are going to want to post that as a seperate resource if you want your spell to be approved.

Should I change the flying height speeds from 0.00 to a configurable value?

That's okay to leave hardcoded. 0.00 makes it so that the change is done instantly.

Should I change the time at which the special effects an animations occur?

I don't understand your question. I made the suggestion because the values you currently have are specific to the model.

Also instead of changing flying heights to zero should I change them to "Flying Height (Default)"?

Yes. Units with Hover and Flying movement type do not have a flying height of 0.

Also how would I use 1 dummy for all the spells? Could I create a special effect on the dummy, store it, and then remove it later?

The dummy.mdx file provided in the link I gave you is an invisible dummy with attachment points. You can attach the special effects to them instead of individually changing the model files of multiple dummies.

 

[Ethereal_]

Alright I've updated the pack and also put the correct credits/link for the knockup, I thought I did that in the credit comment in my map but I brainfarted it. Hope that the pack is better.

 

[KILLCIDE]

General

• Add some documentation to your triggers. It becomes an extreme hassle to figure out what you are trying to do when there are so many functions
• Using the Trigger - Trigger Is On function is fine, but it would be better to use an integer counter
• You have configurables for the loop timer in the configuration, yet you still have the event "Every 0.03 seconds of game time" on all of them

Dashing Steel

• What purpose does DS_Owner serve onCast when you check who owns the caster every loop iteration?

Wind Technique

• Is Double Strike & Counter supposed to run on the same thread? Or is it only possible for one of these to run on every damage event?
• I don't see how WT_CantProcTwice is supposed to work. You add the DamageEventSource to it, and then immediately remove them in the same thread.

Last Breath

• You leak a location here:
  
  • Unit - Move LB_Unit instantly to (LB_PickedLoc offset by LB_DistanceFromTarget towards LB_Degrees degrees)
• You still have some hardcoded values in the LB_isKnockedUp loop:
  
  • LB_CurrentDuration Equal to (LB_KnockDuration[LB_Level] - (LB_LoopSpeed x (LB_KnockDuration[LB_Level] x 16.00)))
  • LB_CurrentDuration Equal to (LB_KnockDuration[LB_Level] - (LB_LoopSpeed x (LB_KnockDuration[LB_Level] x 29.00)))
  I'm still not sure what 16 and 29 even do. Do you mind explaining?
  
  
• Why does setting this to 100 help with "MUI?"
  
  • Animation - Change LB_Picked flying height to 100.00 at LB_SlamSpeedTarget

Set to Awaiting Update.

 

[Ethereal_]

You have configurables for the loop timer in the configuration, yet you still have the event "Every 0.03 seconds of game time" on all of them

I don't know what I'm doing wrong but it won't let me put any variables in place of the 0.03

• Is Double Strike & Counter supposed to run on the same thread? Or is it only possible for one of these to run on every damage event?

• I don't see how WT_CantProcTwice is supposed to work. You add the DamageEventSource to it, and then immediately remove them in the same thread.

• I merged them because I figured I didn't need 2 separate triggers for them, it is possible for them to run on every event if you set the chances to 100, or you're just really lucky

• Every time a unit takes damage the trigger checks to see if it the source has the ability and if the target has the ability. If the source has the ability then the double strike will run, if the target has the ability then the counter will run if they both have the ability then both of them will run, since they both count as damage I don't want double strike to cause another double strike, and that one to cause another one, etc. I also don't want counters to cause a double strike so I add the unit to a unit group before the damage and remove it after the damage so that doesn't happen.

• You still have some hardcoded values in the LB_isKnockedUp loop:
  • • LB_CurrentDuration Equal to (LB_KnockDuration[LB_Level] - (LB_LoopSpeed x (LB_KnockDuration[LB_Level] x 16.00)))
  • • LB_CurrentDuration Equal to (LB_KnockDuration[LB_Level] - (LB_LoopSpeed x (LB_KnockDuration[LB_Level] x 29.00)))
  
  I'm still not sure what 16 and 29 even do. Do you mind explaining?
  
  
• Why does setting this to 100 help with "MUI?"
  • • Animation - Change LB_Picked flying height to 100.00 at LB_SlamSpeedTarget

• The hardcoded values even out the spell over 3 strikes based on the length of the spell.
• 1 second would be 1 - 0.03 * 1 * 16 and 29 = strike at 1, 0.52, 0.13
• If it were 4 seconds - 4 * 0.03 * 4 * 16 and 29 = strike at 4, 2.08, 0.52

• Setting flying height to 100.00 makes it so more than one unit can Last Breath the same target, if it were set back to 0, it would get removed from the knock-up system group meaning it could only be targeted by 1 Last Breath.

I'll make sure I get on everything else.

 

[KILLCIDE]

I don't know what I'm doing wrong but it won't let me put any variables in place of the 0.03

TriggerRegisterTimerEvent takes trigger whichTrigger, real timeout, boolean periodic

I also don't want counters to cause a double strike so I add the unit to a unit group and check if it's in that unit group before the damage and remove it after the damage so that doesn't happen.

You can just turn the trigger off and turn it on then, right?

 

[Ethereal_]

You can just turn the trigger off and turn it on then, right?

I had no idea that worked lol, will change it.

 

[Jay-B]

Well as i observed this is good