Will this leak or cause lags or problems?

[MN Lahmar]

Hello, i'm making a rune of experience that gives all nearby ally heroes xp when used.
Will this trigger leak or cause lags or problems? Is there a better way to do it?
Also, how to make a AOE of 600?

 

[Chaosy]

Yup. The unit group leak.

 

[Light]

ew, single line unit group. use the do (Actions) one as it is far easier to change things.
like chaosy said, the unit group leaks. set it to a variable before picking units. your AoE should be correct, but try to use Units in Range, if it works (i'm not sure).

 

[Daffa]

Point leak
Unit group leak

 

[MN Lahmar]

how can i remove leaks?
Should i just set a variable before picking units? (can you upload an example of a trigger for that i can follow)
i also saw people use a custom script "call DestroyGroup(udg_Group)". Will that work?
What's a point leak?
What are the bad effects of having leaks in your map triggers?
Is having few leaks leads to bad consequences?

Pffffffffffff i used crap like this like a 100 times without knowing. God help!

 

[IcemanBo]

You can read this for how to easily show your trigger: http://www.hiveworkshop.com/forums/miscellaneous-tutorials-456/how-easily-post-triggers-163285/

About preventing memory leaks you can read http://www.hiveworkshop.com/forums/triggers-scripts-269/things-leak-35124/.

 

[RobertMKD]

how can i remove leaks?
Should i just set a variable before picking units? (can you upload an example of a trigger for that i can follow)
i also saw people use a custom script "call DestroyGroup(udg_Group)". Will that work?
What's a point leak?
What are the bad effects of having leaks in your map triggers?
Is having few leaks leads to bad consequences?

Pffffffffffff i used crap like this like a 100 times without knowing. God help!

Create variable for the unit group and point and use them, at the end of the trigger type this into two custom script:
call DestroyGroup(udg_UnitGroup)
call DestroyLocation(udg_TempPoint)

Note that on the places of UnitGroup and TempPoint you need to put your variable names.

 

[MN Lahmar]

About preventing memory leaks you can read http://www.hiveworkshop.com/forums/triggers-scripts-269/things-leak-35124/.

According to that. Are these triggers leak-free now?

Also, pls can someone post a leak-free version of my Rune of Experience trigger?

 

[IcemanBo]

Yes, you do not leak there. How ever "LastCreatedUnit" may be overwritten after the "Wait" operation.

Also, pls can someone post a leak-free version of my Rune of Experience trigger?

You should try yourself, and then ask again if you have problems with it.

You can use the "... And Do Multiple Actions" variant for "If/Then/Else" and for "PickAllUnits..." operations.
With using it, it's easier to make a structure and you gain readability.

 

[Light]

some additional info, single line ITEs are inefficient due to the usage of

Do nothing

like IcemanBo said, you can read and change it much easier.

 

[MN Lahmar]

Yes, you do not leak there.

Good. So, for the unpause triggers, the "Custom script: set bj_wantDestroyGroup = true" will do it?

 

[Light]

yeah, that will work.

if you want to use a unit group for later, don't use that, instead after using it, use this to clean the leak;

Custom script: call DestroyGroup(udg_varname)

 

[SAUS]

I'm pretty sure items leak as well. I don't think tomes ever leave your map. You might notice a small dot where the hero got one and it just stays there forever. You could create a special effect for the animation (need to delete it since it also leaks) and use the trigger that adds experience instead.

 

[MN Lahmar]

I'm pretty sure items leak as well. I don't think tomes ever leave your map. You might notice a small dot where the hero got one and it just stays there forever. You could create a special effect for the animation (need to delete it since it also leaks) and use the trigger that adds experience instead.

I think that's the death animation of the tomes. They shrink but they never disappear.