Leak or Lag Problem

svpforever · Jan 23, 2017

Set Variable A = Point B
Create C at A
RemoveLocation(udg_A)

Hi, I'm just wondering if I use 10 times of that in a trigger then will it cause leak?
Sorry for spaming, just look at this

Set Variable A = Point B
Create C at A
RemoveLocation(udg_A)
Set Variable A = Point B
Create C at A
RemoveLocation(udg_A)
Set Variable A = Point B
Create C at Variable A
RemoveLocation(udg_A)
x10.....
all of that in a trigger... so will it cause leak or lag?

P/s: Noob At English

GIMLI_2 · Jan 23, 2017

it wont leak

IcemanBo · Jan 23, 2017

^this.

But be aware that you don't necessarily need to set your variable to the very same point, if you will repeat the action again immediatly after the point was removed.
Then, you might set the point once, create all units there, and then remove the point at the end, once.

svpforever · Jan 23, 2017

oh I forgot that tks

Dr Super Good · Jan 23, 2017

svpforever said:
all of that in a trigger... so will it cause leak or lag?

It should not leak but might cause a frame drop spike. Unit displacement is very computationally expensive, especially in a crowded situation, so you should try to avoid creating units on top of each other.

svpforever · Jan 24, 2017

I have one more question is that if you use a system like GUI Damage Engine then is it possible for it to cause something wrongs with my map by using it too much? Because my map uses that system in every attacks (also spells), be attacked. I'm dealing with a problem is that if I played the map longer than 30 minutes then the chance it got error (I'm talking about save/load code) is very high (maybe 40%). Currently my map is using both GUI Damage Engine and CodeGen.

Dr Super Good · Jan 24, 2017

svpforever said:
I have one more question is that if you use a system like GUI Damage Engine then is it possible for it to cause something wrongs with my map by using it too much? Because my map uses that system in every attacks (also spells), be attacked. I'm dealing with a problem is that if I played the map longer than 30 minutes then the chance it got error (I'm talking about save/load code) is very high (maybe 40%). Currently my map is using both GUI Damage Engine and CodeGen.

Sounds like something is wrong with the save/load system... It should function the same at map initialization as it does after hours in a leaky map.

Make sure it is not hitting the op limit. If it does something silly like pick every unit or item on the map looking for what to save then that could easily cause the thread to reach the op limit before saving is complete.

svpforever · Jan 24, 2017

Hi, I am using your CodeGen Save/Load system and I have 1 issue with that. May I ask that your CodeGen is completely leakless ? Because I am dealing with a problem is that when I played my map for a long time (like 45 mins or more) then the code when you -save gets error in the next game. It was like the game before (before the game that you -load then you get error with your code) you play very normal. Nothing was going wrong in that game. But in the next game (remake), I typed -load "code" then I get error with my hero, like:
-Strength: 34253 (Instead of 80, I noticed that 34253 supposed to be 34253 gold but now its 0)
-Agility: 1239 (Instead of 65, samething happens 1239 supposed to be 1239 lumber but now its 0)
-Intelligence: 50 (Instead of 55, samething happens 50 supposed to be 50 food but now its 0)

Well, if I played the game less than 30 minutes, everything goes fine in the next game without getting my code error. I thought it was my map gets too many leaks so I checked but I couldn't find any. So........ i don't know what to do except asking you about this. Hopefully you can reply me asap @@. Thank you so much for your time reading this.

Trigger Happy: Memory leaks would have nothing to do with it and there's likely something wrong with your triggers.

That was the conversation between me and Trigger Happy (just want to post it here for more clearly about my problem).
I'm pretty new with the World Editor so may i ask what is "op limit"......

Dr Super Good · Jan 24, 2017

The fact you get a code means it is unlikely you are hitting the op limit. The op limit is a limit on the number of JASS virtual machine operations that can be executed consecutively within a single thread before the thread is terminated. It is a form of infinite loop protection that will protect against simple forms of infinite loop like a never ending loop statement or a loop that is so big/complex it might as well never end.

It might be a good idea to post the saving an loading triggers. The error might be an easy spot.

Dehua_Darbuya · Jan 24, 2017

You might want to take a look at this >>> How to easily post triggers

Dr Super Good · Jan 24, 2017

svpforever said:
..... That was the Save/Load Trigger.

None of the links work...

Please copy as text and paste into appropriate tags.

svpforever · Jan 24, 2017

Dehua_Darbuya said:
You might want to take a look at this >>> How to easily post triggers

Hi, i couldn't find the "Go Advanced" button @@

Dehua_Darbuya · Jan 24, 2017

svpforever said:
Hi, i couldn't find the "Go Advanced" button @@

You can skip that part; that's to post a new thread. Once you've copied your trigger(s) as text, paste them between [TRIGGER][/TRIGGER] tags.

svpforever · Jan 24, 2017

Dehua_Darbuya said:
You can skip that part; that's to post a new thread. Once you've copied your trigger(s) as text, paste them between [TRIGGER][/TRIGGER] tags.

Okay tks u

svpforever · Jan 24, 2017

CodeGen Save
- Events
  - Player - Player 1 (Red) types a chat message containing -luu as An exact match
  - Player - Player 2 (Blue) types a chat message containing -luu as An exact match
  - Player - Player 3 (Teal) types a chat message containing -luu as An exact match
  - Player - Player 4 (Purple) types a chat message containing -luu as An exact match
  - Player - Player 5 (Yellow) types a chat message containing -luu as An exact match
  - Player - Player 6 (Orange) types a chat message containing -luu as An exact match
  - Player - Player 7 (Green) types a chat message containing -luu as An exact match
- Conditions
  - (Number of units in (Units owned by (Triggering player) matching (((Matching unit) is A Hero) Equal to (==) True))) Greater than or equal to (>=) 1
- Actions
  - Set SaveCount = 0
  - Set SaveLoad_Index = (Player number of (Triggering player))
  - Set Hero = Game_Hero[SaveLoad_Index]
  - Custom script: set udg_Save[udg_SaveCount] = CodeGen_ConvertUnit(GetUnitTypeId(udg_Hero))
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = (Hero_Armor[SaveLoad_Index] - Item_Armor[SaveLoad_Index])
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = (Hero_AttackDamage[SaveLoad_Index] - Item_AttackDamage[SaveLoad_Index])
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = (Hero_Crit[SaveLoad_Index] - Item_Crit[SaveLoad_Index])
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = (Hero_CritChance[SaveLoad_Index] - Item_CritChance[SaveLoad_Index])
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = (Hero_AttackSpeed[SaveLoad_Index] - Item_AttackSpeed[SaveLoad_Index])
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = (Hero_HPRegen[SaveLoad_Index] - Item_HPRegen[SaveLoad_Index])
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = (Hero_MPRegen[SaveLoad_Index] - Item_MPRegen[SaveLoad_Index])
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = (Hero_SpellArmor[SaveLoad_Index] - Item_SpellArmor[SaveLoad_Index])
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = (Hero_SpellCrit[SaveLoad_Index] - Item_SpellCrit[SaveLoad_Index])
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = (Hero_SpellCritChance[SaveLoad_Index] - Item_SpellCritChance[SaveLoad_Index])
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = (Hero_SpellDamage[SaveLoad_Index] - Item_SpellDamage[SaveLoad_Index])
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = (Hero_BlockDamage[SaveLoad_Index] - Item_BlockDamage[SaveLoad_Index])
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = (Hero_BlockSpell[SaveLoad_Index] - Item_BlockSpell[SaveLoad_Index])
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = (Hero level of Hero)
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = (Strength of Hero (Exclude bonuses))
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = (Agility of Hero (Exclude bonuses))
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = (Intelligence of Hero (Exclude bonuses))
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = ((Triggering player) Current gold)
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = ((Triggering player) Current lumber)
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = ((Triggering player) Food used)
  - Set SaveCount = (SaveCount + 1)
  - Set Save[SaveCount] = Hero_ItemExp[SaveLoad_Index]
  - Set SaveCount = (SaveCount + 1)
  - Set Item = (Item carried by Hero in slot 1)
  - Custom script: set udg_Save[udg_SaveCount] = CodeGen_ConvertItem(GetItemTypeId(udg_Item))
  - Item - Set the custom value of (Item carried by Hero in slot 1) to SaveLoad_Index
  - Set SaveCount = (SaveCount + 1)
  - Set Item = (Item carried by Hero in slot 2)
  - Custom script: set udg_Save[udg_SaveCount] = CodeGen_ConvertItem(GetItemTypeId(udg_Item))
  - Item - Set the custom value of (Item carried by Hero in slot 2) to SaveLoad_Index
  - Set SaveCount = (SaveCount + 1)
  - Set Item = (Item carried by Hero in slot 3)
  - Custom script: set udg_Save[udg_SaveCount] = CodeGen_ConvertItem(GetItemTypeId(udg_Item))
  - Item - Set the custom value of (Item carried by Hero in slot 3) to SaveLoad_Index
  - Set SaveCount = (SaveCount + 1)
  - Set Item = (Item carried by Hero in slot 4)
  - Custom script: set udg_Save[udg_SaveCount] = CodeGen_ConvertItem(GetItemTypeId(udg_Item))
  - Item - Set the custom value of (Item carried by Hero in slot 4) to SaveLoad_Index
  - Set SaveCount = (SaveCount + 1)
  - Set Item = (Item carried by Hero in slot 5)
  - Custom script: set udg_Save[udg_SaveCount] = CodeGen_ConvertItem(GetItemTypeId(udg_Item))
  - Item - Set the custom value of (Item carried by Hero in slot 5) to SaveLoad_Index
  - Set SaveCount = (SaveCount + 1)
  - Set Item = (Item carried by Hero in slot 6)
  - Custom script: set udg_Save[udg_SaveCount] = CodeGen_ConvertItem(GetItemTypeId(udg_Item))
  - Item - Set the custom value of (Item carried by Hero in slot 6) to SaveLoad_Index
  - Set SaveCount = (SaveCount + 1)
  - Set Item = (Item carried by Game_Carrier[SaveLoad_Index] in slot 1)
  - Custom script: set udg_Save[udg_SaveCount] = CodeGen_ConvertItem(GetItemTypeId(udg_Item))
  - Item - Set the custom value of (Item carried by Game_Carrier[SaveLoad_Index] in slot 1) to SaveLoad_Index
  - Set SaveCount = (SaveCount + 1)
  - Set Item = (Item carried by Game_Carrier[SaveLoad_Index] in slot 2)
  - Custom script: set udg_Save[udg_SaveCount] = CodeGen_ConvertItem(GetItemTypeId(udg_Item))
  - Item - Set the custom value of (Item carried by Game_Carrier[SaveLoad_Index] in slot 2) to SaveLoad_Index
  - Set SaveCount = (SaveCount + 1)
  - Set Item = (Item carried by Game_Carrier[SaveLoad_Index] in slot 3)
  - Custom script: set udg_Save[udg_SaveCount] = CodeGen_ConvertItem(GetItemTypeId(udg_Item))
  - Item - Set the custom value of (Item carried by Game_Carrier[SaveLoad_Index] in slot 3) to SaveLoad_Index
  - Set SaveCount = (SaveCount + 1)
  - Set Item = (Item carried by Game_Carrier[SaveLoad_Index] in slot 4)
  - Custom script: set udg_Save[udg_SaveCount] = CodeGen_ConvertItem(GetItemTypeId(udg_Item))
  - Item - Set the custom value of (Item carried by Game_Carrier[SaveLoad_Index] in slot 4) to SaveLoad_Index
  - Set SaveCount = (SaveCount + 1)
  - Set Item = (Item carried by Game_Carrier[SaveLoad_Index] in slot 5)
  - Custom script: set udg_Save[udg_SaveCount] = CodeGen_ConvertItem(GetItemTypeId(udg_Item))
  - Item - Set the custom value of (Item carried by Game_Carrier[SaveLoad_Index] in slot 5) to SaveLoad_Index
  - Set SaveCount = (SaveCount + 1)
  - Set Item = (Item carried by Game_Carrier[SaveLoad_Index] in slot 6)
  - Custom script: set udg_Save[udg_SaveCount] = CodeGen_ConvertItem(GetItemTypeId(udg_Item))
  - Item - Set the custom value of (Item carried by Game_Carrier[SaveLoad_Index] in slot 6) to SaveLoad_Index
  - -------- -------------------- --------
  - -------- Set the filename for where the loadcode will be stored. --------
  - -------- -------------------- --------
  - Set SaveLoad_Directory = Save
  - Set SaveLoad_Filename = ((Deathly Angel VN RPG + (Name of (Triggering player))) + ('s + ( + (((Name of Hero) + ( Cap Do + (String((Hero level of Hero))))) + .txt))))
  - -------- -------------------- --------
  - -------- Show Code --------
  - -------- -------------------- --------
  - Set ZPlayer_Force = (Player group((Triggering player)))
  - Game - Display to ZPlayer_Force the text: MÂ· cÃ±a bÂ¹n Â®Â· ...
  - Custom script: set udg_Code = CodeGen_Compile()
  - Game - Display to ZPlayer_Force for 60.00 seconds the text: Code
  - Custom script: call DestroyForce(udg_ZPlayer_Force)

CodeGen Load
- Events
  - Player - Player 1 (Red) types a chat message containing -load as A substring
  - Player - Player 2 (Blue) types a chat message containing -load as A substring
  - Player - Player 3 (Teal) types a chat message containing -load as A substring
  - Player - Player 4 (Purple) types a chat message containing -load as A substring
  - Player - Player 5 (Yellow) types a chat message containing -load as A substring
  - Player - Player 6 (Orange) types a chat message containing -load as A substring
  - Player - Player 7 (Green) types a chat message containing -load as A substring
- Conditions
  - Multiple ConditionsAnd - All (Conditions) are true
    - Conditions
      - (String((Substring((Entered chat string), 1, 6))) as Lower case) Equal to (==) -load
      - (Number of units in (Units owned by (Triggering player) matching (((Matching unit) is A Hero) Equal to (==) True))) Equal to (==) 0
- Actions
  - -------- -------------------- --------
  - -------- Check if load is valid --------
  - -------- -------------------- --------
  - Set Code = (Substring((Entered chat string), 7, 999))
  - Custom script: call CodeGen_Load(udg_Code)
  - Set SaveLoad_Index = (Player number of (Triggering player))
    - Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
      - If - Conditions
        
        SaveLoad_Valid Equal to (==) False
      - Then - Actions
        
        Set ZPlayer_Force = (Player group((Triggering player)))
        
        Game - Display to ZPlayer_Force for 10.00 seconds the text: SaveLoad_Error
        
        Custom script: call DestroyForce(udg_ZPlayer_Force)
        
        Skip remaining actions
      - Else - Actions
  - Player Group - Remove (Triggering player) from HeroPick_Player
  - Set LoadCount = 0
  - Set SaveLoad_Point = (Center of Greenforst <gen>)
  - Unit - Create 1 SaveLoad_Hero[Load[LoadCount]] for (Triggering player) at SaveLoad_Point facing Default building facing (270.0) degrees
  - Set Hero = (Last created unit)
  - Set Game_Hero[SaveLoad_Index] = (Last created unit)
  - Selection - Select (Last created unit) for (Triggering player)
    - Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
      - If - Conditions
        
        (Unit-type of Hero) Equal to (==) TriÃ–u HÃ¥i SÂ
      - Then - Actions
        
        Unit - Create 1 Ma BÂ¨ng HÃ© PhÂ¸p for (Triggering player) at SaveLoad_Point facing Default building facing (270.0) degrees
        
        Set Game_Summon[SaveLoad_Index] = (Last created unit)
        
        Unit - Add .Energy Shield to Hero
      - Else - Actions
  - Unit - Create 1 NgÂÃªi VÂ¸c Â§Ã¥ for (Triggering player) at SaveLoad_Point facing Default building facing (270.0) degrees
  - Set Game_Carrier[SaveLoad_Index] = (Last created unit)
  - -------- -------------------- --------
  - -------- Load heroes level --------
  - -------- -------------------- --------
  - Set LoadCount = (LoadCount + 1)
  - Set Hero_Armor[SaveLoad_Index] = Load[LoadCount]
  - Set LoadCount = (LoadCount + 1)
  - Set Hero_AttackDamage[SaveLoad_Index] = Load[LoadCount]
  - Set LoadCount = (LoadCount + 1)
  - Set Hero_Crit[SaveLoad_Index] = Load[LoadCount]
  - Set LoadCount = (LoadCount + 1)
  - Set Hero_CritChance[SaveLoad_Index] = Load[LoadCount]
  - Set LoadCount = (LoadCount + 1)
  - Set Hero_AttackSpeed[SaveLoad_Index] = Load[LoadCount]
  - Set LoadCount = (LoadCount + 1)
  - Set Hero_HPRegen[SaveLoad_Index] = Load[LoadCount]
  - Set LoadCount = (LoadCount + 1)
  - Set Hero_MPRegen[SaveLoad_Index] = Load[LoadCount]
  - Set LoadCount = (LoadCount + 1)
  - Set Hero_SpellArmor[SaveLoad_Index] = Load[LoadCount]
  - Set LoadCount = (LoadCount + 1)
  - Set Hero_SpellCrit[SaveLoad_Index] = Load[LoadCount]
  - Set LoadCount = (LoadCount + 1)
  - Set Hero_SpellCritChance[SaveLoad_Index] = Load[LoadCount]
  - Set LoadCount = (LoadCount + 1)
  - Set Hero_SpellDamage[SaveLoad_Index] = Load[LoadCount]
  - Set LoadCount = (LoadCount + 1)
  - Set Hero_BlockDamage[SaveLoad_Index] = Load[LoadCount]
  - Set LoadCount = (LoadCount + 1)
  - Set Hero_BlockSpell[SaveLoad_Index] = Load[LoadCount]
  - Set LoadCount = (LoadCount + 1)
  - Hero - Set Hero Hero-level to Load[LoadCount], Show level-up graphics
    - Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
      - If - Conditions
        
        (Unit-type of Hero) Equal to (==) TriÃ–u HÃ¥i SÂ
        
        (Hero level of Hero) Greater than or equal to (>=) 55
        
        ((Triggering player) is in Game_Summon_PlayerGroup) Equal to (==) False
      - Then - Actions
        
        Unit - Create 1 PhÂ¸p SÂ BÃ£ng TÃ¨i for (Triggering player) at SaveLoad_Point facing Default building facing (270.0) degrees
        
        Set Game_Summon2[SaveLoad_Index] = (Last created unit)
        
        Player Group - Add (Triggering player) to Game_Summon_PlayerGroup
      - Else - Actions
    - Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
      - If - Conditions
        
        (Hero level of Hero) Greater than or equal to (>=) 55
      - Then - Actions
        
        Player Group - Add (Triggering player) to ThienXa_Group
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng Chien Binh for Hero to 5
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng Cung ThÃ± for Hero to 5
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng PhÃ¯ ThÃ±y for Hero to 5
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng SÂ¸t ThÃ± for Hero to 5
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng XÂ¹ ThÃ± for Hero to 5
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng PhÂ¸p SÂ for Hero to 5
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng Â§ÃŠu SÃœ for Hero to 5
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng Tu SÃœ for Hero to 5
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng NÃ¡ ThÃ± for Hero to 5
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng ThÂ¸nh HiÃ–p SÃœ for Hero to 5
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng SÃ¸ GiÂ¶ RÃµng Xanh for Hero to 5
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng TriÃ–u HÃ¥i SÂ for Hero to 4
        
        Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (Unit-type of Hero) Equal to (==) TriÃ–u HÃ¥i SÂ
        
        Then - Actions
        
        Unit - Add Call of the Damned to Hero
        
        Else - Actions
      - Else - Actions
        
        Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (Hero level of Hero) Greater than or equal to (>=) 40
        
        Then - Actions
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng Chien Binh for Hero to 4
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng Cung ThÃ± for Hero to 4
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng PhÃ¯ ThÃ±y for Hero to 4
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng SÂ¸t ThÃ± for Hero to 4
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng XÂ¹ ThÃ± for Hero to 4
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng PhÂ¸p SÂ for Hero to 4
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng Â§ÃŠu SÃœ for Hero to 4
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng Tu SÃœ for Hero to 4
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng NÃ¡ ThÃ± for Hero to 4
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng TriÃ–u HÃ¥i SÂ for Hero to 4
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng ThÂ¸nh HiÃ–p SÃœ for Hero to 4
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng SÃ¸ GiÂ¶ RÃµng Xanh for Hero to 4
        
        Else - Actions
        
        Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (Hero level of Hero) Greater than or equal to (>=) 25
        
        Then - Actions
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng Chien Binh for Hero to 3
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng Cung ThÃ± for Hero to 3
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng PhÃ¯ ThÃ±y for Hero to 3
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng SÂ¸t ThÃ± for Hero to 3
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng XÂ¹ ThÃ± for Hero to 3
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng PhÂ¸p SÂ for Hero to 3
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng Â§ÃŠu SÃœ for Hero to 3
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng Tu SÃœ for Hero to 3
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng NÃ¡ ThÃ± for Hero to 3
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng TriÃ–u HÃ¥i SÂ for Hero to 3
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng ThÂ¸nh HiÃ–p SÃœ for Hero to 3
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng SÃ¸ GiÂ¶ RÃµng Xanh for Hero to 3
        
        Else - Actions
        
        Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (Hero level of Hero) Greater than or equal to (>=) 10
        
        Then - Actions
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng Chien Binh for Hero to 2
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng Cung ThÃ± for Hero to 2
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng PhÃ¯ ThÃ±y for Hero to 2
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng SÂ¸t ThÃ± for Hero to 2
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng XÂ¹ ThÃ± for Hero to 2
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng PhÂ¸p SÂ for Hero to 2
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng Â§ÃŠu SÃœ for Hero to 2
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng Tu SÃœ for Hero to 2
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng NÃ¡ ThÃ± for Hero to 2
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng TriÃ–u HÃ¥i SÂ for Hero to 2
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng ThÂ¸nh HiÃ–p SÃœ for Hero to 2
        
        Unit - Set level of .KÃ¼ NÂ¨ng TÂÃng SÃ¸ GiÂ¶ RÃµng Xanh for Hero to 2
        
        Else - Actions
    - Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
      - If - Conditions
        
        (Hero level of Hero) Greater than or equal to (>=) 15
        
        ((Owner of Hero) is in MBHP_Group1) Equal to (==) False
      - Then - Actions
        
        Unit - Add .BÂ¨ng Phong TrÂ¶m to Game_Summon[SaveLoad_Index]
        
        Player Group - Add (Owner of Hero) to MBHP_Group1
      - Else - Actions
    - Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
      - If - Conditions
        
        (Hero level of Hero) Greater than or equal to (>=) 35
        
        ((Owner of Hero) is in MBHP_Group2) Equal to (==) False
      - Then - Actions
        
        Unit - Add .BÂ¨ng Phong HÃ© PhÂ¸p to Game_Summon[SaveLoad_Index]
        
        Player Group - Add (Owner of (Triggering unit)) to MBHP_Group2
      - Else - Actions
    - Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
      - If - Conditions
        
        (Hero level of Hero) Greater than or equal to (>=) 65
        
        ((Owner of Hero) is in PSBT_Group1) Equal to (==) False
      - Then - Actions
        
        Unit - Add .TÃ‹n ThÃ• to Game_Summon2[SaveLoad_Index]
        
        Player Group - Add (Triggering player) to PSBT_Group1
      - Else - Actions
    - Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
      - If - Conditions
        
        (Hero level of Hero) Greater than or equal to (>=) 85
        
        ((Triggering player) is in PSBT_Group2) Equal to (==) False
      - Then - Actions
        
        Unit - Add .SÃ¸c MÂ¹nh TÃ¨i ThÂÃ®ng to Game_Summon2[SaveLoad_Index]
        
        Player Group - Add (Triggering player) to PSBT_Group2
      - Else - Actions
  - Set LoadCount = (LoadCount + 1)
  - Hero - Modify Strength of Hero: Set to Load[LoadCount]
  - Hero - Modify Strength of Game_Summon[SaveLoad_Index]: Set to Load[LoadCount]
  - Hero - Modify Strength of Game_Summon2[SaveLoad_Index]: Set to Load[LoadCount]
  - Set LoadCount = (LoadCount + 1)
  - Hero - Modify Agility of Hero: Set to Load[LoadCount]
  - Set LoadCount = (LoadCount + 1)
  - Hero - Modify Intelligence of Hero: Set to Load[LoadCount]
  - Hero - Modify Intelligence of Game_Summon[SaveLoad_Index]: Set to Load[LoadCount]
  - Hero - Modify Intelligence of Game_Summon2[SaveLoad_Index]: Set to Load[LoadCount]
  - Set LoadCount = (LoadCount + 1)
  - Player - Set (Triggering player) Current gold to Load[LoadCount]
  - Set LoadCount = (LoadCount + 1)
  - Player - Set (Triggering player) Current lumber to Load[LoadCount]
  - Set LoadCount = (LoadCount + 1)
  - Player - Set (Triggering player) Food used to Load[LoadCount]
  - Set LoadCount = (LoadCount + 1)
  - Set Hero_ItemExp[(Player number of (Triggering player))] = Load[LoadCount]
  - Set LoadCount = (LoadCount + 1)
  - Hero - Create SaveLoad_Item[Load[LoadCount]] and give it to Hero
  - Item - Set the custom value of (Last created item) to SaveLoad_Index
  - Set LoadCount = (LoadCount + 1)
  - Hero - Create SaveLoad_Item[Load[LoadCount]] and give it to Hero
  - Item - Set the custom value of (Last created item) to SaveLoad_Index
  - Set LoadCount = (LoadCount + 1)
  - Hero - Create SaveLoad_Item[Load[LoadCount]] and give it to Hero
  - Item - Set the custom value of (Last created item) to SaveLoad_Index
  - Set LoadCount = (LoadCount + 1)
  - Hero - Create SaveLoad_Item[Load[LoadCount]] and give it to Hero
  - Item - Set the custom value of (Last created item) to SaveLoad_Index
  - Set LoadCount = (LoadCount + 1)
  - Hero - Create SaveLoad_Item[Load[LoadCount]] and give it to Hero
  - Item - Set the custom value of (Last created item) to SaveLoad_Index
  - Set LoadCount = (LoadCount + 1)
  - Hero - Create SaveLoad_Item[Load[LoadCount]] and give it to Hero
  - Item - Set the custom value of (Last created item) to SaveLoad_Index
  - Set LoadCount = (LoadCount + 1)
  - Hero - Create SaveLoad_Item[Load[LoadCount]] and give it to Game_Carrier[SaveLoad_Index]
  - Item - Set the custom value of (Last created item) to SaveLoad_Index
  - Set LoadCount = (LoadCount + 1)
  - Hero - Create SaveLoad_Item[Load[LoadCount]] and give it to Game_Carrier[SaveLoad_Index]
  - Item - Set the custom value of (Last created item) to SaveLoad_Index
  - Set LoadCount = (LoadCount + 1)
  - Hero - Create SaveLoad_Item[Load[LoadCount]] and give it to Game_Carrier[SaveLoad_Index]
  - Item - Set the custom value of (Last created item) to SaveLoad_Index
  - Set LoadCount = (LoadCount + 1)
  - Hero - Create SaveLoad_Item[Load[LoadCount]] and give it to Game_Carrier[SaveLoad_Index]
  - Item - Set the custom value of (Last created item) to SaveLoad_Index
  - Set LoadCount = (LoadCount + 1)
  - Hero - Create SaveLoad_Item[Load[LoadCount]] and give it to Game_Carrier[SaveLoad_Index]
  - Item - Set the custom value of (Last created item) to SaveLoad_Index
  - Set LoadCount = (LoadCount + 1)
  - Hero - Create SaveLoad_Item[Load[LoadCount]] and give it to Game_Carrier[SaveLoad_Index]
  - Item - Set the custom value of (Last created item) to SaveLoad_Index
  - Trigger - Add to Heroes Level Up <gen> the event (Unit - Hero Gains a level)
  - Custom script: call RemoveLocation(udg_SaveLoad_Point)

.... That was the trigger @@.

Tks u.

Dehua_Darbuya · Jan 24, 2017

Hopefully I didn't miss anything but as far as I can tell, there aren't any leaks in those two triggers. It's probably causing some lag for a brief moment as it loads but nothing that should make the map unplayable.

svpforever · Jan 24, 2017

Dehua_Darbuya said:
Hopefully I didn't miss anything but as far as I can tell, there aren't any leaks in those two triggers. It's probably causing some lag for a brief moment as it loads but nothing that should make the map unplayable.

The map still playable but it generated wrong code like what I've mentioned in the #8 post..... I'm still wondering why it generated wrong code. As far as I can tell, if I played the map for a long time like 1 hour then it will generate wrong code. In the next game still -load able but wrong stats......

Dr Super Good · Jan 24, 2017

Debug the save/load system by printing a list to the player, say over 10 seconds, of what is being saved. If when he loads it is different then something breaks with the save/load system. It could be that another trigger is accidently changing player hero variables to other values and hence garbage gets correctly saved. If the code is too long then maybe the end of it is being truncated (there is a character limit on chat messages) which is resulting in garbage being loaded however I would imagine the system's checksum would fail in this case and throw an invalid code result for loading.

svpforever · Jan 25, 2017

What do I need to do now @@. All I do is just copy and paste so I don't know how to fix this problem....

Edit: By the way, can they affect the save/load system code?

Testing
- Events
  - Unit - A unit enters (Entire map)
- Conditions
  - Multiple ConditionsOr - Any (Conditions) are true
    - Conditions
      - (Unit-type of (Triggering unit)) Equal to (==) ChiÃ•n Binh
      - (Unit-type of (Triggering unit)) Equal to (==) Cung ThÃ±
      - (Unit-type of (Triggering unit)) Equal to (==) HÃ¤c ViÂªn
      - (Unit-type of (Triggering unit)) Equal to (==) NÃ¡ thÃ±
      - (Unit-type of (Triggering unit)) Equal to (==) PhÂ¸p SÂ
      - (Unit-type of (Triggering unit)) Equal to (==) PhÃ¯ ThÃ±y
      - (Unit-type of (Triggering unit)) Equal to (==) SÂ¸t ThÃ±
      - (Unit-type of (Triggering unit)) Equal to (==) TriÃ–u HÃ¥i SÂ
      - (Unit-type of (Triggering unit)) Equal to (==) Tu SÃœ
      - (Unit-type of (Triggering unit)) Equal to (==) XÂ¹ ThÃ±
      - (Unit-type of (Triggering unit)) Equal to (==) Â§ÃŠu SÃœ
      - (Unit-type of (Triggering unit)) Equal to (==) ThÂ¸nh HiÃ–p SÃœ
      - (Unit-type of (Triggering unit)) Equal to (==) SÃ¸ GiÂ¶ RÃµng Xanh
- Actions
  - Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - ((Triggering unit) is in Game_Group) Equal to (==) False
    - Then - Actions
      - Unit Group - Add (Triggering unit) to Game_Group
    - Else - Actions

Testing 2
- Events
  - Unit - A unit enters (Entire map)
- Conditions
  - Multiple ConditionsOr - Any (Conditions) are true
    - Conditions
      - (Unit-type of (Triggering unit)) Equal to (==) XÂ¹ ThÃ±
      - (Unit-type of (Triggering unit)) Equal to (==) HuyÃ•t KÃ¾
      - (Unit-type of (Triggering unit)) Equal to (==) NgÂÃªi CÂ©y
      - (Unit-type of (Triggering unit)) Equal to (==) SÃ£i
      - (Unit-type of (Triggering unit)) Equal to (==) Chim Â¦ng
- Actions
  - Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - (Unit-type of (Triggering unit)) Equal to (==) XÂ¹ ThÃ±
    - Then - Actions
      - Set Game_Summon_XaThu[(Player number of (Owner of (Triggering unit)))] = (Triggering unit)
    - Else - Actions
  - Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - (Unit-type of (Triggering unit)) Equal to (==) HuyÃ•t KÃ¾
    - Then - Actions
      - Set Game_Summon_HuyetKy[(Player number of (Owner of (Triggering unit)))] = (Triggering unit)
    - Else - Actions
  - Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - (Unit-type of (Triggering unit)) Equal to (==) NgÂÃªi CÂ©y
    - Then - Actions
      - Set Game_Summon_NguoiCay[(Player number of (Owner of (Triggering unit)))] = (Triggering unit)
    - Else - Actions
  - Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - (Unit-type of (Triggering unit)) Equal to (==) SÃ£i
    - Then - Actions
      - Set Game_Summon_Soi[(Player number of (Owner of (Triggering unit)))] = (Triggering unit)
    - Else - Actions
  - Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - (Unit-type of (Triggering unit)) Equal to (==) Chim Â¦ng
    - Then - Actions
      - Set Game_Summon_ChimUng[(Player number of (Owner of (Triggering unit)))] = (Triggering unit)
    - Else - Actions

svpforever · Jan 26, 2017

up @@

Dr Super Good · Jan 26, 2017

When saving, print out the values being saved in a human readable string. This makes sure the save code is being generated correctly. When loading then print out the loaded values in a human readable string, this will tell you if the values are being loaded properly. The human readable string produced by saving should match the one produced by loading. If they do not match then one might be able to see where it is going wrong. If everything is wrong then maybe the save code is too long to enter into chat.

Such a human readable string might be as simple as comma separated values for every stored entry in the code.

Leak or Lag Problem

Similar threads