Leak or not?

[GIMLI_2]

hey, simple question, do i need to create a second point variable for editing an offset?

• Set Respawn_Point = (Position of (Triggering unit))
• Held - Instantly revive (Triggering unit) at (Respawn_Location offset by 256.00 towards 0.00 degrees), Zeigen revival graphics
• Custom script: call RemoveLocation (udg_Respawn_Point)

 

[Xonok]

hey, simple question, do i need to create a second point variable for editing an offset?

• Set Respawn_Point = (Position of (Triggering unit))
• Held - Instantly revive (Triggering unit) at (Respawn_Location offset by 256.00 towards 0.00 degrees), Zeigen revival graphics
• Custom script: call RemoveLocation (udg_Respawn_Point)

Yes, create a second one.

 

[ultimate11]

hey, simple question, do i need to create a second point variable for editing an offset?

• Set Respawn_Point = (Position of (Triggering unit))
• Held - Instantly revive (Triggering unit) at (Respawn_Location offset by 256.00 towards 0.00 degrees), Zeigen revival graphics
• Custom script: call RemoveLocation (udg_Respawn_Point)

True form:

• Set Respawn_Point = (Position of (Triggering unit))
• Set Respawn_Point2 = (Respawn_Location offset by 256.00 towards 0.00 degrees)
• Held - Instantly revive (Triggering unit) at Respawn_Point2 , Zeigen revival graphics
• Custom script: call RemoveLocation (udg_Respawn_Point)
• Custom script: call RemoveLocation (udg_Respawn_Point2)

 

[Faith]

True form:

• Set Respawn_Point = (Position of (Triggering unit))
• Set Respawn_Point2 = (Respawn_Location offset by 256.00 towards 0.00 degrees)
• Held - Instantly revive (Triggering unit) at Respawn_Point2 , Zeigen revival graphics
• Custom script: call RemoveLocation (udg_Respawn_Point)
• Custom script: call RemoveLocation (udg_Respawn_Point2)

Position of Triggering Unit isn't used..?

I clearly didn't read this right..
Use this method to ensure the leaks are removed.

Keep in mind, if you want to keep the respawn location the same,
DO NOT remove the location.

 

[defskull]

@Archange1
In your trigger, it looks like you have 3 point variables: Respawn_Point, Respawn_Point2, Respawn_Location

I believe it's a typo to your code ?
Respawn_Location should be Respawn_Point.

 

[shadowvzs]

hey, simple question, do i need to create a second point variable for editing an offset?

• Set Respawn_Point = (Position of (Triggering unit))
• Held - Instantly revive (Triggering unit) at (Respawn_Location offset by 256.00 towards 0.00 degrees), Zeigen revival graphics
• Custom script: call RemoveLocation (udg_Respawn_Point)

this dont leak that sure

• Melee Initialization
  • Events
    • Unit - A unit Dies
  • Conditions
  • Actions
    • Set U = (Triggering unit)
    • Custom script: call ReviveHero(udg_U, GetUnitX(udg_U) + 256.00 * Cos(0 * bj_DEGTORAD), GetUnitY(udg_U) + 256.00 * Sin(0 * bj_DEGTORAD), true)

x = original hero x coordinate
y = original hero x coordinate
newX = x + distance * Cos(angle * bj_DEGTORAD)
newY = y + distance * Sin(angle * bj_DEGTORAD)

 

[edo494]

0 * bj_DEGTORAD is still 0 so dont use it unless hou want some specific value
speed baby, speed

also because it is static value, you could negate the Sin Cos function calls replacing them with the values

 

[Maker]

And Sin(0*x) = 1

 

[shadowvzs]

0 * bj_DEGTORAD is still 0 so dont use it unless hou want some specific value
speed baby, speed

also because it is static value, you could negate the Sin Cos function calls replacing them with the values

if i remove the 0 or even the whole sin cos then how could somebody compare with GUI one?

 

[edo494]

if he is working with GUI he can just use point offset, if he was to use this, why even calling those?
in Jass you can optimize a lot more then in GUI

and why would you want to compare it with GUI?

 

[shadowvzs]

if he is working with GUI he can just use point offset, if he was to use this, why even calling those?
in Jass you can optimize a lot more then in GUI

and why would you want to compare it with GUI?

every deent system what use gui, also use custom script, correct me if wrong but custom script is needed for clean the leaks, what i posted that also a way, u can use gui just with custom script and without location and without another 2 leak cleaning custom script, and maybe someone dont know how its work when u use coordinates and not location for pollaroffset things

 

[edo494]

to be honest if I didnt inow what polar projection is I would most likely have no idea what the Cos, Sin does there

this doesnt change anything on the fact that Sin and Cos are usless here because he does it towards 0 degrees

anyways ultimate11 already post a good enough solution

 

[Faith]

@Archange1
In your trigger, it looks like you have 3 point variables: Respawn_Point, Respawn_Point2, Respawn_Location

I believe it's a typo to your code ?
Respawn_Location should be Respawn_Point.

I didn't even post a trigger.

 

[defskull]

Lol I thought that was your post, until...
Yep, it was a quote, my bad =,="