why this triggers leak?

[snowman990]

• Negative Clock
  • Events
• Unit - a unit begin casting an ability
  • Conditions
• [Ability being cast] equal to negative clock
  • Actions
• Pause [targeted unit of ability being cat]
• Effect -Set [targeted unit of ability being cast] animation into 0 with [150,150,150] tint and [0] vertex coloring
• Wait - wait 3 second.
• Unpause [targeted unit of ability being cast]
• Effect - set [targeted unit of ability being cast] unit animation into 100% with ]250,250,250] tint and [0] vertex coloring

This trigger sometime leak and I don't know why... anyone help me please.
Note: I am writing this trigger on my handphone, so apologize if it was inaccurate. I'll update later in midnight, because right now I'm in school and I was busy all day, except midnight.

 

[Arhowk]

how do you know that it leaks.....

also, target unit of ability being cast doesnt work after a wait

 

[mckill2009]

if you're using Effect and not remove it then it will leak, but I dont think its Effect but Animation - Change Unit Vertex Coloring which shouldnt leak...

 

[Dr Super Good]

If that wait you are using is wait game time (PolledWait) then it is leaking there. The BJ that makes up PolledWait leaks a handle index due to not nulling a local declared local timer that is created and destroyed during the function call.

 

[snowman990]

"how do you know that it leaks....."

It sometime make the target freeze forever, and sometime make the animation of the target unit freeze.

"also, target unit of ability being cast doesn't work after a wait"

Really? I think it worked, because it do freeze the enemy.

"if you're using Effect and not remove it then it will leak, but I dont think its Effect but Animation - Change Unit Vertex Coloring which shouldn't leak..."
I was removing it. But sometime when AI use this ability the "freeze the target forever" leak is sometime triggered by itself.
@supergood: I'm not using ingame time, I think.

 

[Maker]

Create a unit variable called unit

Trigger

• Untitled Trigger 009
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Holy Light
  • Actions
    • Custom script: local unit u = GetSpellTargetUnit()
    • Custom script: set udg_unit = u
    • Unit - Pause unit
    • Animation - Change unit's vertex coloring to (100.00%, 100.00%, 100.00%) with 0.00% transparency
    • Wait 2.00 seconds
    • Custom script: set udg_unit = u
    • Unit - Unpause unit
    • Animation - Change unit's vertex coloring to (100.00%, 100.00%, 100.00%) with 0.00% transparency
    • Custom script: set u = null

 

[snowman990]

Let me try that trigger tonight, because I'm too busy (but still can get online on hive thanks to my phone).

 

[Dr Super Good]

It sometime make the target freeze forever, and sometime make the animation of the target unit freeze.

That has nothing to do with leaks. That is a bug.

It would only leak if you use the PolledWait instead of TriggerSleepAction as PolledWait does leak a handle index due to not nulling a local defined local timer.

 

[Meticulous]

How would you deal with a polled wait leak?

 

[snowman990]

That has nothing to do with leaks. That is a bug.

It would only leak if you use the PolledWait instead of TriggerSleepAction as PolledWait does leak a handle index due to not nulling a local defined local timer.

How to fix the bug?


@Maker : something odd is happening. see the pic oh and here's the trigger... because you say that i need to create variable unit i create it.

Trigger

• Jam Negatif
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Negative Clock
  • Actions
    • Set Unit = (Target unit of ability being cast)
    • Custom script: local unit u = GetSpellTargetUnit()
    • Custom script: set udg_unit = u
    • Unit - Pause Unit
    • Animation - Change Unit's vertex coloring to (50.00%, 50.00%, 50.00%) with 24.00% transparency
    • Wait 3.00 seconds
    • Unit - Unpause Unit
    • Animation - Change Unit's vertex coloring to (100.00%, 100.00%, 100.00%) with 0.00% transparency
    • Custom script: set u = null

@Meticulous : i'm sorry, but i dont get it about what you're saying

 

[Justify]

You did not copy the trigger. You added one line that bugs

 

[Dr Super Good]

How would you deal with a polled wait leak?

Use a custom version of PolledWait that does null the local declared local timer at the end of the function. There is no way without resorting to custom script.

 

[Arhowk]

First, put this code into your map header

function PolledWait2 takes real duration returns nothing
local real timeRemaining
local real st=TimerGetElapsed( bj_gameStartedTimer)
if st <= 0 then
set bj_gameStartedTimer = CreateTimer()
call TimerStart(bj_gameStartedTimer, 1000000, false, null)
endif
if (duration > 0) then
loop
set timeRemaining = duration - TimerGetElapsed( bj_gameStartedTimer) + st
exitwhen timeRemaining <= 0
if (timeRemaining > bj_POLLED_WAIT_SKIP_THRESHOLD) then
call TriggerSleepAction(0.1 * timeRemaining)
else
call TriggerSleepAction(bj_POLLED_WAIT_INTERVAL)
endif
endloop
endif
endfunction

than instead of Wait (x) do

CustomScript : call PolledWait2(YourTimeToWaitFor.) (you need the . )

 

[Dr Super Good]

Do be aware that for small waits of about 1 second or less it is probably better to use TriggerSleepAction directly as the latency in multiplayer hammers precision of PolledWait enough to not be worth it.

 

[Troll-Brain]

also, target unit of ability being cast doesnt work after a wait

IIRC, that's not absolutely true, it will work if the endcast even has not fire yet, else it will return null.

 

[mckill2009]

you need to put that local on top of the trigger and you didnt follow Maker's trigger btw, the idea behind it is creating a local variable coz it will be executed even if there are waits within a function, thus making your spell MUI, after the wait you need to "set udg_unit = u" to point the local to a global variable...

some spells will do an infinite loop when you pause after you casted the spell, that's why it freezes the caster forever, provided that mana is still available...

 

[snowman990]

@mckill : I actually follow what he say. But add variable on top the custom scripts and edit the animation thingy and wait a little bit. Are you informing that I should put those custom scripts. Atop the variable I create or I should delete it (I've try delete the variable, but my map can't be played because the WE say there's a syntax error)? Actually the caster does not get freezing forever, only the target is. But it was a really rare bug, I only get this bug twice when I test it. Maybe I am going to post the map included with the trigger and ability, if anyone willing to see it. Oh almost forgot, I don't know if this might help you guys solve my problem, but I think I should tell. I use JassNewGenPack.
@supergood and illidan : I'm so sorry, but for some reason jass that I create or copy are just being shitty sometime so maybe I can't use jass...
@Justify : is a variable line really make a bug?

 

[Maker]

is a variable line really make a bug?

Yes, the one you added.

 

[snowman990]

Yes, the one you added.

So I should remove the variable line? lemme try again, because the last time I when I does not add the variable line, the syntax check say there's something error...

 

[mckill2009]

no you didnt, compare post#6 and #10, you can see that it's not the same, plus like I said locals must be put on top of the function, like post #6...

 

[snowman990]

Kay then, I'll make Maker's trigger after finishing some exams