[Solved] Why isn't this functions working?

[streetpunk]

So this is a TEXTURE changer trigger that will change a model's skin while in-game. I tested the same functiong using the "Unit enters playable map area" event and it works fine, but in this one it doesn't. What m'I missing ?

• Untitled Trigger 001
  • Events
    • Unit - A unit Acquires an item
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Item-type of (Item being manipulated)) Equal to Linen Clothing
      • Then - Actions
        • Set TempPointTexture = (Position of (Triggering unit))
        • Set TempPointTexture2 = (TempPointTexture offset by 12.00 towards (Facing of (Triggering unit)) degrees)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Owner of (Triggering unit)) is an ally of Player 11 (Dark Green)) Equal to True
          • Then - Actions
            • Destructible - Create a Human v1 at TempPointTexture facing 0.00 with scale 0.01 and variation 0
          • Else - Actions
            • Destructible - Create a Human v2 at TempPointTexture facing 0.00 with scale 0.01 and variation 0
        • Unit - Add Texture Changer to (Triggering unit)
        • Unit - Order (Triggering unit) to Night Elf Mountain Giant - War Club (Last created destructible)
        • Unit - Remove Texture Changer from (Triggering unit)
        • Destructible - Remove (Last created destructible)
        • Custom script: call RemoveLocation(udg_TempPointTexture)
        • Custom script: call RemoveLocation(udg_TempPointTexture2)
        • Custom script: set udg_TempPointTexture = null
        • Custom script: set udg_TempPointTexture2 = null
        • Custom script: set bj_lastCreatedDestructable = null
      • Else - Actions

 

[Pyrogasm]

Is it possible "Item being manipulated" isn't registering for that event? I see nothing else that would cause it not to run properly. How much "doesn't work"? all the trigger?

 

[streetpunk]

I tested without the condition too, and no effect. I've put an "Display Game Message for Player" on every part of the function and it showed up on the screen when the event was fired.

EDIT: If the unit haven't moved yet in the match the trigger will work, but somehow if the units moves and then stops, THEN execute the trigger, it won't work

 

[Pyrogasm]

Try disabling these two lines and seeing if it works then. Perhaps the destructible is going away too quickly for the unit to use War Club on it.

Unit - Remove Texture Changer from (Triggering unit)
Destructible - Remove (Last created destructible)

 

[streetpunk]

It's working with the disabled functions, however can you help me on what can be done to remove the ability and the destructible without having any visual trace of the destructible on the gameplay ?

 

[Pyrogasm]

In this instance it would probably be best just to store them in a local variable, wait the shortest possible time, and then perform those actions. There's no need to set bj_lastCreatedDestructable to null, and keeping that line in will mess with you here. Nulling a global variable is unnecessary since it will eventually be reassigned to something else anyway, effectively clearing that part of the leak (still need to actually remove the location, though).

• Untitled Trigger 001
  • Events
    • Unit - A unit Acquires an item
  • Conditions
  • Actions
    • Custom script: local destructable D
    • -------- that has to be the first line of the trigger, else you get compiler errors --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Item-type of (Item being manipulated)) Equal to Linen Clothing
      • Then - Actions
        • Set TempPointTexture = (Position of (Triggering unit))
        • Set TempPointTexture2 = (TempPointTexture offset by 12.00 towards (Facing of (Triggering unit)) degrees)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Owner of (Triggering unit)) is an ally of Player 11 (Dark Green)) Equal to True
          • Then - Actions
            • Destructible - Create a Human v1 at TempPointTexture facing 0.00 with scale 0.01 and variation 0
          • Else - Actions
            • Destructible - Create a Human v2 at TempPointTexture facing 0.00 with scale 0.01 and variation 0
        • Unit - Add Texture Changer to (Triggering unit)
        • Unit - Order (Triggering unit) to Night Elf Mountain Giant - War Club (Last created destructible)
        • Custom script: call RemoveLocation(udg_TempPointTexture)
        • Custom script: call RemoveLocation(udg_TempPointTexture2)
        • -------- REMOVE THIS --------
        • Custom script: set udg_TempPointTexture = null
        • Custom script: set udg_TempPointTexture2 = null
        • Custom script: set bj_lastCreatedDestructable = null
        • -------- REMOVE THIS --------
        • Custom script: set D = bj_lastCreatedDestructable
        • Wait 0.00 seconds //something like 0.27 is the shortest possible wait, but this will do that
        • Custom script: set bj_lastCreatedDestructable = D
        • Custom script: set D = null
        • Unit - Remove Texture Changer from (Triggering unit)
        • Destructible - Remove (Last created destructible)
      • Else - Actions

 

[streetpunk]

Ah, I found the problem, the destructible was being created at TempPointTexture instead of TempPointTexture2, making the second variable position useless at all, I changed that and it didn't need the wait function to work! Thanks a lot, @Pyrogasm !

 

[Pyrogasm]

Ah. That's likely because the unit needed to turn to cast the spell the target destructable was at its location rather than in front of it.

 

[streetpunk]

Yeah, I realize that now... that's why it worked when the unit hadn't moved yet in the match...

 

[streetpunk]

I would like to re-open this thread!

So what is happening is that the function is working only at the second time it runs (or maybe half of the times or so) can anyone point to an explanation and solution ?

 

[Pyrogasm]

I know it's not much different but can you post your current code again?

 

[streetpunk]

Here it goes:

• Untitled Trigger 001
  • Events
    • Unit - A unit Acquires an item
  • Conditions
    • (Item-class of (Item being manipulated)) Equal to Permanent
  • Actions
    • -------- ----------------------------------------------- --------
    • -------- LINEN CLOTHING --------
    • -------- ----------------------------------------------- --------
    • Set TempPointTexture = (Position of (Triggering unit))
    • Set TempPointTexture2 = (TempPointTexture offset by 12.00 towards (Facing of (Triggering unit)) degrees)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Owner of (Triggering unit)) is an ally of Player 11 (Dark Green)) Equal to True
      • Then - Actions
        • Destructible - Create a Human v1 at TempPointTexture2 facing 0.00 with scale 0.01 and variation 0
      • Else - Actions
        • Destructible - Create a Human v2 at TempPointTexture2 facing 0.00 with scale 0.01 and variation 0
    • Unit - Add Texture Changer to Unit_Animation[(Player number of (Owner of (Triggering unit)))]
    • Unit - Order Unit_Animation[(Player number of (Owner of (Triggering unit)))] to Night Elf Mountain Giant - War Club (Last created destructible)
    • Unit - Remove Texture Changer from Unit_Animation[(Player number of (Owner of (Triggering unit)))]
    • Destructible - Remove (Last created destructible)
    • Custom script: call RemoveLocation(udg_TempPointTexture)
    • Custom script: call RemoveLocation(udg_TempPointTexture2)
    • Custom script: set udg_TempPointTexture = null
    • Custom script: set udg_TempPointTexture2 = null
    • Custom script: set bj_lastCreatedDestructable = null

 

[Pyrogasm]

Where is Unit_Animation[] being set and what is it actually? I assumed it was the unit picking up the item, and in that case I don't really see why you're sometimes using Triggering Unit and sometimes using that variable. My intuition is that the variable isn't being set before the first cast.

Like before, does it work fine if you disable (Ctrl+F) the Remove Texture Changer... and Remove (Last created destructible) lines?

 

[streetpunk]

the triggering unit is the unit picking up the item, unit_animation is the unit that will have it's texture changed, they're both at the same place all the time. I use the triggering unit for stats etc and the unit_aniamtion to perform animations (attack, walk etc). it is set at the beggining of the match.

 

[Pyrogasm]

Ah, that makes sense.

Like before, does it work fine if you disable (Ctrl+F) the Remove Texture Changer... and Remove (Last created destructible) lines?

 

[streetpunk]

Removing the functions cited above doesn't changed anything, however I realized that it was happening because the trigger that runs that function maybe isn't recognizing unit_animation, as it is set praticaly at the same time that the trigger is run. let me explain: the game starts when I choose a dialog button, that's when the unit_animation is set and that's where the item is given to the triggering unit. adding a wait 0.50 seconds in the trigger makes it work, but I would need a better solution than using "wait" functions

 

[Pyrogasm]

Why not just wait 0.50s before giving the unit the item? Or is that what you mean you don't want to do?

 

[streetpunk]

that's what I mean I don't want to do. waits are umpredictable. if two units take the item at the same time the wait function would glitch it

 

[Pyrogasm]

No, I mean put the wait in the dialog button trigger. This way it will only happen the very first time for each player.

• Events
  • Dialog button is clicked
• Conditions
• Actions
  • -------- ... --------
  • Set Unit_Animation[...] etc.
  • Wait 0.50 seconds.
  • Item - Create 1 Item etc.
• Events
  • Unit - A unit acquires an item
• Conditions
• Actions
  • -------- Blah blah --------

 

[streetpunk]

but again, what if two players press the dialog button at once ?
I think I may have a solution, I'll come back to tell the results!

 

[Pyrogasm]

If you post the full trigger I could tell you if a wait is going to mess with it, but I don't really see it causing a problem.