Wait in timer

[Vortigon]

it is me or

call TriggerSleepAction(#)

is buggy when used in timers?

 

[Maker]

Post trigger.

 

[Pharaoh_]

Waits are not as accurate as timers. If you fire a timer, use an additional trigger with the event Time - Timer X expires, you don't need the wait to detect its expiration.

 

[PurgeandFire]

Waits can't be used in timer callbacks. (as well as a group iterations)

It will most likely stop the thread. (no functions past the wait will execute) I am not sure if this is the case for the way GUI handles timers, but I am pretty sure it applies.

 

[mckill2009]

maybe he meant a looping wait inside a timer?...sample, a timer runs for every 0.1 seconds, then damages enemy(s) for every 5 seconds inside the loop?...

to do this, you need to use hashtables/indexing, set it to zero first during the casting...
then increase the variable to 0.1, when it reaches 5.0 set it back again to zero inside the loop...

 

[Bribe]

This is an easy way to set it up:

function Wait takes nothing returns nothing
    call TriggerSleepAction(0)
endfunction

function Callback takes nothing returns nothing
    call ExecuteFunc("Wait")
endfunction

 

[Justify]

Either what Bribe said or just a "trigger". The name of TSA is quite accurate as only triggers can be paused (in their functions for sure). A callback is not a real trigger but only a function that is called. If you create a trigger with the timeout-event waits should work afair.

 

[Vortigon]

an example of trigger:

function timer takes nothing returns nothing
timer t = get expired timer blablabla.. (it is a 0.01 timer)

call BJDebugMsg("a")
call TriggerSleepAction(1.00)
call BJDebugMsg("b")

endfunction

well nothing happens past the wait...

ill try bribe thing

EDIT:
with Executefunc it simply skips the wait
and with a normal call it just bug like before

I dont get what u told me to do Justify ><

 

[Bribe]

"with Executefunc it simply skips the wait"

I have no idea what you mean. ExecuteFunc will work just fine.

Please post the code you were trying.

 

[Ceday]

He probably writed something like this.

function waitfunc takes nothing returns nothing
    call TriggerSleepAction(1.00)
endfunction

function somefunc takes something returns something

//something
    call ExecuteFunc("waitfunc")
//actions that will be executed 1 seconds later.
endfunction

 

[baassee]

It will most likely stop the thread. (no functions past the wait will execute) I am not sure if this is the case for the way GUI handles timers, but I am pretty sure it applies.

GUI uses StartTimerBJ which sets the callback function to null.

 

[Ceday]

Read first post and his post again, he is talking about something completely different.

 

[baassee]

Waits can't be used in timer callbacks. (as well as a group iterations)

It will most likely stop the thread. (no functions past the wait will execute) I am not sure if this is the case for the way GUI handles timers, but I am pretty sure it applies.

I answered this part.

 

[Ceday]

Then I should have read your post again, you were talking about something completely different.

 

[Bribe]

He probably writed something like this.

function waitfunc takes nothing returns nothing
    call TriggerSleepAction(1.00)
endfunction

function somefunc takes something returns something

//something
    call ExecuteFunc("waitfunc")
//actions that will be executed 1 seconds later.
endfunction

Yeah, which in that case of course would need to be changed to this:

function waitfunc takes nothing returns nothing
    call TriggerSleepAction(1.00)
//actions that will be executed 1 seconds later.
endfunction

function somefunc takes something returns something

//something
    call ExecuteFunc("waitfunc")
endfunction

 

[Vortigon]

oh okay I see, but then can I give arguments when i call a function with Executefunc ? :/

 

[baassee]

Callbacks cannot have any arguments. Neither can ExecuteFunc. Then you just have to call a function instead.

 

[Vortigon]

ye but then it doesn't work..

 

[Ceday]

Save values to globals first, then call ExecuteFunc.

function WaitedFunc takes nothing returns nothing
    local effect e = PassedEffect
    call TriggerSleepAction(PassedReal)
    call DestroyEffect(e)
    set e = null
endfunction

function MainFunction takes something returns something
//...
    set PassedEffect = AddSpecialEffectTarget(SomeUnit, "someEffect", "origin")
    set PassedReal = 5.00
    call ExecuteFunc("WaitedFunc")
//...
endfunction

or (I have never used it so I am not sure) you can use WaitedFunc.execute(unit, effect) to pass parameters, .execute use a trigger, a trigger action and globals to pass data.

I want my post to stay below 100

 

[Vortigon]

oh.. i never thinked about saving in global to get my new local :O

I think it shuld be good thanks a lot.

 

[baassee]

function WaitedFunc takes effect e, real yourtime returns nothing
    call TriggerSleppAction(yourtime)
    call DestroyEffect(e)
    set e = null
endfunction

function Mainfunction takes nothing reutrns nothing
   call WaitedFunc(youreffect, 5.)
endfunction

?????

 

[Troll-Brain]

Quite off-topic but you don't need to null handle arguments of function, they are not concerned with the bug (personally tested but you can test it yourself).
But locals declared in the corpse of a function have to be nulled, so it's lame when you have to return them :/ (just use a global in this case)

 

[Bribe]

I have also tested this and parameters do not leak handle IDs like
local variables do.

 

[Luorax]

function WaitedFunc takes effect e, real yourtime returns nothing
    call TriggerSleppAction(yourtime)
    call DestroyEffect(e)
    set e = null
endfunction

function Mainfunction takes nothing reutrns nothing
   call WaitedFunc(youreffect, 5.)
endfunction

?????

That won't work. WaitedFunc will run in the thread Mainfunction is, where you can't use waits --> WaitedFunc will crash it. You have to execute that function.

 

[Bribe]

I would just recommend doing everything in the function that was executed, that way you don't have to pass any timer data.

Or you can use TriggerRegisterTimerEvent, and use trigger actions.

 

[baassee]

@T-B
Ah I see.

OT:

well if it's a callback then nothing but if it's the GUI event it works basically Bribe's version