W3MMD Desync Problem

[PlayMan]

Hello,

i did read much Threads about Desync and W3MMD and know, there can be some problems.

My Problem is after game start, some ppl get dc.

(00:00 / All) justGG.: Shortest load by player [achjakomdochher] was 48.71 seconds.
(00:00 / All) justGG.: Longest load by player [diVision] was 237.64 seconds.
(00:00 / All) justGG.: This game is hosted by GhostPlay.
(00:00 / All) justGG.: Good Luck and Have Fun
(00:01 / All) justGG.: Warning! Desync detected!
(00:01 / All) justGG.: Players in game state #1: x-Heisenberg-x
(00:01 / All) justGG.: Players in game state #2: justGG., achjakomdochher, forby51, OiMeL, VIDIOT, diVision
(00:01 / All) justGG.: Players in game state #3: fuunky, guillemarc
(00:01 / All) justGG.: x-Heisenberg-x was dropped due to desync.
(00:01 / All) justGG.: guillemarc was dropped due to desync.
(00:01 / All) justGG.: fuunky was dropped due to desync.

i have 4 triggers for check win and if all players from one team left:
1 Trigger:

function Team_1_Win_Local takes nothing returns nothing
    if ( GetPlayerSlotState(Player(0)) != PLAYER_SLOT_STATE_PLAYING ) then
        call DoNothing(  )
    else
        call MMD_FlagPlayer(Player(0), MMD_FLAG_WINNER)
    endif
    if ( GetPlayerSlotState(Player(1)) != PLAYER_SLOT_STATE_PLAYING ) then
        call DoNothing(  )
    else
        call MMD_FlagPlayer(Player(1), MMD_FLAG_WINNER)
    endif
    if ( GetPlayerSlotState(Player(2)) != PLAYER_SLOT_STATE_PLAYING ) then
        call DoNothing(  )
    else
        call MMD_FlagPlayer(Player(2), MMD_FLAG_WINNER)
    endif
    if ( GetPlayerSlotState(Player(3)) != PLAYER_SLOT_STATE_PLAYING ) then
        call DoNothing(  )
    else
        call MMD_FlagPlayer(Player(3), MMD_FLAG_WINNER)
    endif
    if ( GetPlayerSlotState(Player(4)) != PLAYER_SLOT_STATE_PLAYING ) then
        call DoNothing(  )
    else
        call MMD_FlagPlayer(Player(4), MMD_FLAG_WINNER)
    endif
    call MMD_FlagPlayer(Player(5), MMD_FLAG_LOSER)
    call MMD_FlagPlayer(Player(6), MMD_FLAG_LOSER)
    call MMD_FlagPlayer(Player(7), MMD_FLAG_LOSER)
    call MMD_FlagPlayer(Player(8), MMD_FLAG_LOSER)
    call MMD_FlagPlayer(Player(9), MMD_FLAG_LOSER)
endfunction

//===========================================================================
function InitTrig_Team_1_Win_Local takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    call TriggerRegisterUnitEvent( t, gg_unit_ofrt_0020, EVENT_UNIT_DEATH )
    call TriggerAddAction( t, function Team_1_Win_Local )
endfunction

2 Trigger:

function Team_1_Leave_Local_Conditions takes nothing returns boolean
    if ( not GetBooleanOr( GetPlayerSlotState(Player(0)) == PLAYER_SLOT_STATE_EMPTY, GetPlayerSlotState(Player(0)) == PLAYER_SLOT_STATE_LEFT ) ) then
        return false
    endif
    if ( not GetBooleanOr( GetPlayerSlotState(Player(1)) == PLAYER_SLOT_STATE_EMPTY, GetPlayerSlotState(Player(1)) == PLAYER_SLOT_STATE_LEFT ) ) then
        return false
    endif
    if ( not GetBooleanOr( GetPlayerSlotState(Player(2)) == PLAYER_SLOT_STATE_EMPTY, GetPlayerSlotState(Player(2)) == PLAYER_SLOT_STATE_LEFT ) ) then
        return false
    endif
    if ( not GetBooleanOr( GetPlayerSlotState(Player(3)) == PLAYER_SLOT_STATE_EMPTY, GetPlayerSlotState(Player(3)) == PLAYER_SLOT_STATE_LEFT ) ) then
        return false
    endif
    if ( not GetBooleanOr( GetPlayerSlotState(Player(4)) == PLAYER_SLOT_STATE_EMPTY, GetPlayerSlotState(Player(4)) == PLAYER_SLOT_STATE_LEFT ) ) then
        return false
    endif
    return true
endfunction

function Team_1_Leave_Local_Actions takes nothing returns nothing
    if ( GetPlayerSlotState(Player(5)) != PLAYER_SLOT_STATE_PLAYING) then
        call DoNothing(  )
    else
        call MMD_FlagPlayer(Player(5), MMD_FLAG_WINNER)
    endif
    if ( GetPlayerSlotState(Player(6)) != PLAYER_SLOT_STATE_PLAYING ) then
        call DoNothing(  )
    else
        call MMD_FlagPlayer(Player(6), MMD_FLAG_WINNER)
    endif
    if ( GetPlayerSlotState(Player(7)) != PLAYER_SLOT_STATE_PLAYING ) then
        call DoNothing(  )
    else
        call MMD_FlagPlayer(Player(7), MMD_FLAG_WINNER)
    endif
    if ( GetPlayerSlotState(Player(8)) != PLAYER_SLOT_STATE_PLAYING ) then
        call DoNothing(  )
    else
        call MMD_FlagPlayer(Player(8), MMD_FLAG_WINNER)
    endif
    if ( GetPlayerSlotState(Player(9)) != PLAYER_SLOT_STATE_PLAYING ) then
        call DoNothing(  )
    else
        call MMD_FlagPlayer(Player(9), MMD_FLAG_WINNER)
    endif
    call MMD_FlagPlayer(Player(0), MMD_FLAG_LOSER)
    call MMD_FlagPlayer(Player(1), MMD_FLAG_LOSER)
    call MMD_FlagPlayer(Player(2), MMD_FLAG_LOSER)
    call MMD_FlagPlayer(Player(3), MMD_FLAG_LOSER)
    call MMD_FlagPlayer(Player(4), MMD_FLAG_LOSER)
endfunction

//===========================================================================
function InitTrig_team_1_leave_Local takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    call TriggerRegisterTimerEventPeriodic( t, 15.00 )
    call TriggerAddCondition( t, Condition( function Team_1_Leave_Local_Conditions ) )
    call TriggerAddAction( t, function Team_1_Leave_Local_Actions )
endfunction

Other 2 Triggers looks like this too only with other player numbers.

I did pub only w3mmd library in the map and use only win/lose, nothing more.

Can someone help me?

Thx you

(sorry for my bad english)

 

[Vinz]

I doubt this will fix your problem, but I suggest remove all Do Nothing calls. This will improve efficiency by a bit.

 

[deathismyfriend]

Since it seems like you know JASS but don't know efficient codon you should look at my tutorial converting GUI to efficient JASS. Link is in my sig. You should also look at things you should know when using triggers / GUI.

Also checking for players lot state playing will not accurately check for players that are playing. You need to check if the player is also a user.

You can also put most of this in a simple loop to make it more efficient.

 

[PlayMan]

Greet thx for your answers.
But can it really help with my Desync problem.

If someone have finished triggers for w3mmd (2 Teams) and can send me it, it will be really nice.

Ofc as next step i try follow your suggestions.

Thx again.

 

[deathismyfriend]

I don't see anything that would cause a desync in those triggers. If you turn those off is it still desyncing ? If it is then turn off a few triggers at a time to narrow down the bad trigger. Then when you find that it does not desync take that group and turn each trigger on one by one till you find the bad trigger then post it here.

 

[PlayMan]

I am thinking about this JassNewGenPack 5d, i used it for putting stats into map. But map was created with newer Version of world editor. Before i open map in this JassNewGenPack 5d worldeditor say me, that it was created with newer version.
Now a question, can it be possible that last save of map was made with older version?

 

[deathismyfriend]

That is not possible as JNGP works fine. Make sure you have the newest version of it though. JNGP 2.0 beta is the newest and best with added features.

Here is the link to the newest one.
http://www.hiveworkshop.com/forums/...en-pack-2-0-x-beta-recruiting-testing-233145/

 

[Vinz]

Now a question, can it be possible that last save of map was made with older version?

That happens to me when opening a map made by vanilla editor only. Try saying yes.

 

[PlayMan]

i have news,
i checked the replay with dota replay manager and saw that (look attachment)

can you help me with it?


Thx

 

[deathismyfriend]

i have news,
i checked the replay with dota replay manager and saw that (look attachment)

can you help me with it?


Thx

I have no idea what that is supposed to mean in the picture.

Did you try what I said above ?

 

[PlayMan]

so....
i tryed to disable w3mmd and it still desync.
hm...
i am not map creator i am only who try implement stats in to the map.
In next days i should get older map, where no desync and i try to put it there to check, maybe it really all right.

Thx Guys for so much Help.

If i get map and did test it, i would post here.

 

[PlayMan]

i did tested it and that was not w3mmd stats who did provocate desync, so topic can be closed.

thx a lot for your answers