vJass Chat System v1.1

[Moderator]

Update 26 April 2012
Bribe: Approved 3/5. Another chat system for vJass joins the fray.

6th Apr 2012
Bribe: In "sendMessage" method, instead of spamming "return" use the "elseif" keyword.

You are leaking handle ID's.

Sean: Helping with the script layout, @dedication to him, may he rest in peace@.

Someone died to write this script for you?

Spawner trigger -

This doesn't compile and run properly for me: public constant effect array landing[11]. Arrays cannot be constant, ever.

The following lines:

//Instead of this:
        local trigger t = CreateTrigger()
        call rects()
        call TriggerRegisterTimerEvent(t, .05, false)
        call TriggerAddAction(t, function spawn.start)
        set t = null
//Do this:
 call rects()
 call TimerStart(CreateTimer(), 0.5, false, function spawn.start)

 

[Magtheridon96]

• All the globals should be private or private constant so users can't use them outside the system and because they're taking up namespace
• The global boolean private should be changed because it might cause errors with the parser o-o (change the name to priv or something)
• ==true is incredibly redundant everywhere
• To display a message to all players, you would do this: call DisplayTimedTextToPlayer(GetLocalPlayer(), 0, 0, DURATION, MESSAGE)
• Whenever you call DisplayText functions multiple times inside a function, you could optimize that function by using a local string and instead of displaying the message, you would that local to: set s = s + message + "\n", then you would call DisplayTimedTextToPlayer at the end of the function.
• You don't need to check if a player is playing or not to display text. You won't lose performance at all. In fact, by not caring, you would be gaining performance.
• In your name static method, the 15 should be configurable.

edit
And who's Sean?

 

[Adiktuz]

Description: This system can be used for RPG, AOS, ORPG or any basic map. Customization is included in the script, however I'll also post some explanations here ; ). When I was working on a map with a friend, I found myself lacking a chat system that had what I wanted, so I decided to make my own. I believe the script matches JPAG requirements, if you find a mistake please tell me, I'll fix it but I checked over it and fixed what I found.

where is the description of what this system does?

 

[khamarr3524]

• All the globals should be private or private constant so users can't use them outside the system and because they're taking up namespace
• The global boolean private should be changed because it might cause errors with the parser o-o (change the name to priv or something)
• ==true is incredibly redundant everywhere
• To display a message to all players, you would do this: call DisplayTimedTextToPlayer(GetLocalPlayer(), 0, 0, DURATION, MESSAGE)
• Whenever you call DisplayText functions multiple times inside a function, you could optimize that function by using a local string and instead of displaying the message, you would that local to: set s = s + message + "\n", then you would call DisplayTimedTextToPlayer at the end of the function.
• You don't need to check if a player is playing or not to display text. You won't lose performance at all. In fact, by not caring, you would be gaining performance.
• In your name static method, the 15 should be configurable.

edit
And who's Sean?

1. Will fix SOME globals. As stated in the configuration, the functions listed with On in them should be left touchable to players because they can configure them throughout the game. Also some globals are used outside the library and therefore cannot be wrapped as private, otherwise they wouldn't work properly.

2. I thought I did this, but I must have been wrong Thank you. Fixed.

3. I don't understand? In configuration for whatever reason, if default values are not given, the functions dont register values properly.

4. Fixed. Thanks, I was unaware of this. I've heard to avoid GetLocalPlayer() for desyncs but I guess if it's all, doesn't affect it at all

5. If you read the scripting more clearly, you would notice some slight differences in the only location in which this occurs are present, this is why I cannot simplify it more.

6. Originally when working with the coding, displaying text to a non-playing player seemed bad because it would create an excess string declaration that cannot be "trash collected". Or am I wrong? And I don't really see where this is, other than when I add players to playForce.

7. Fixed

Also, Sean is more of a personal friend, he hung himself last weekend and we were working on this together, I felt it fitting to include him as a very important contributor.

 

[khamarr3524]

where is the description of what this system does?

Edited now to describe it's function better now.

 

[Adiktuz]

don't double post my friend...

and please explain messaging more... is it like a mailing system or something?

 

[khamarr3524]

Apologies, I mean to edit >.<. Anyways I understand now, I haven't been very direct in explaining it, I'll post a revised description now. It's more of a "non-Blizzard" way of displaying in-game messages. I'll post more in original post.


EDIT: I understand Magtheridon96 now, all "redundant" == true comparisons are resolved. I was unaware of this o.o Thank you.

 

[Magtheridon96]

if whoPrivate != 0 and whoPrivate != 1 and whoPrivate != 2 and whoPrivate != 3 and whoPrivate != 4 and whoPrivate != 5 and whoPrivate != 6 and whoPrivate != 7 and whoPrivate != 8 and whoPrivate != 9 and whoPrivate != 10 and whoPrivate != 11 then

Why not check if it's less than 0 or greater than 11? ._.

 

[shadowvzs]

player controller also work too since cpu can be player 4, no?

 

[khamarr3524]

@Magtheridon o.o I'm sorry, i didn't do that system set, I should have picked up on it, but I'll fix it now thanks.

@shadowvs Messages are displayed only to players in the game and who are users due to the conditions set in place in the addition of players to the force playForce.

Edit: Map is currently not updated however script is. Apologies.

Edit: Map is now updated. A solution to the PM problem has been found.

 

[khamarr3524]

Updated with 3 new colors and system colors implemented. An adjustable message time system is being implemented, will post it tomorrow.