Veteran System

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

21:44, 7th Aug 2013
PurgeandFire: Set to "Needs Fix". A few changes suggested here:
http://www.hiveworkshop.com/forums/2385686-post23.html

 

[deathismyfriend]

u do know that skip remaining actions will end the trigger right ?
also dont use integer A/B its less efficient and slower than ur own variable.

this trigger does nothing. V Start Ability

change the second killing unit to the variable u set above it in this.

• Set V_Killer = (Killing unit)
• Set V_HashUnit = (Key (Killing unit))

reverse these and use the variable that is set for triggering unit

• Set V_HashUnit = (Key (Triggering unit))
• Set V_Unit = (Triggering unit)

 

[13oot-Me]

also dont use integer A/B its less efficient and slower than ur own variable.

So what do you mean when I should use my own variable? I already have one indexing the spells.

change the second killing unit to the variable u set above it in this.

• Set V_Killer = (Killing unit)
  • Set V_HashUnit = (Key (Killing unit))

reverse these and use the variable that is set for triggering unit

• Set V_HashUnit = (Key (Triggering unit))
  • Set V_Unit = (Triggering unit)

I can't select those variables for the 'V_HashUnit' key.

 

[Almia]

use this:
set V_Unit = Triggering Unit
Custom script : set udg_V_HashUnit = GetHandleId(udg_V_Unit)

 

[deathismyfriend]

So what do you mean when I should use my own variable? I already have one indexing the spells.

make another tempInteger to replace integer A. integer A/B is slower and less efficient.

I can't select those variables for the 'V_HashUnit' key.

as for these change them from this

• Set V_Killer = (Killing unit)
• Set V_HashUnit = (Key V_Killer)

reverse these and use the variable that is set for triggering unit

• Set V_Unit = (Triggering unit)
• Set V_HashUnit = (Key V_Unit)

 

[13oot-Me]

as for these change them from this

• Set V_Killer = (Killing unit)
  • Set V_HashUnit = (Key V_Killer)

reverse these and use the variable that is set for triggering unit

• Set V_Unit = (Triggering unit)
  • Set V_HashUnit = (Key V_Unit)

I get what you're saying but the fact is when I try to set 'V_Unit' as the handle, there is no variable to pick from at all. Look at the picture below to see.

I'm using Almia's way for now.

 

[Almia]

That's because they all use my method

 

[maddeem]

I get what you're saying but the fact is when I try to set 'V_Unit' as the handle, there is no variable to pick from at all. Look at the picture below to see.

I'm using Almia's way for now.

That is one of the major flaws of GUI hashtables, the key function is bugged. It does not allow you to use udg variables. However, this can be fixed by using custom script.

 

[deathismyfriend]

That is one of the major flaws of GUI hashtables, the key function is bugged. It does not allow you to use udg variables. However, this can be fixed by using custom script.

if i use the normal WE i can use the udg variables. So im not sure y he cant unless he is using JNGP.

its been a while since i used the normal WE so i could be mistaken. i dont think i am tho

 

[13oot-Me]

if i use the normal WE i can use the udg variables. So im not sure y he cant unless he is using JNGP.

its been a while since i used the normal WE so i could be mistaken. i dont think i am tho

I'm using the normal WE and it works if I use Almia's method with the custom script but the GUI way doesn't work. That's alright though as long as it works the way it should. What WE do you use?

 

[deathismyfriend]

normal world editor.
u need to store it as a handle and use the handle variable like this
or use the tempInt which can be used as key of picked unit

• Actions
  • Set hand = (Picked unit)
  • Set tempInt = (Key (Picked unit))
  • Hashtable - Save 0 as (Key hand) of tempInt in (Last created hashtable)

see what i mean lol. u can do this in normal WE.

 

[Almia]

@dimf
we meant this:

Set Unit = Picked Unit Set Key = Key(Unit)

Assuming that Unit is a unit variable.

If we convert yours to JASS, it will call the Picked Unit twice:

set udg_Unit = GetEnumUnit()
set udg_Key = GetHandleId(GetEnumUnit())

 

[deathismyfriend]

ik but u can still do this lol.

• Set tempInt = (Key hand)

that other one was just a quick example

the variable hand is actually a handle variable not a unit variable

ur trying to use the unit variable when in fact u need to use the handle variable to be able to do this.

here look at this map on the normal WE

 

[13oot-Me]

Oh i get you now haha I thought you wanted me to use the unit variable for the hashtable.

 

[maddeem]

if i use the normal WE i can use the udg variables. So im not sure y he cant unless he is using JNGP.

its been a while since i used the normal WE so i could be mistaken. i dont think i am tho

Back when I used to use GUI I would switch between JNGP and the vanilla editor just to copy over hashtable keys. It was a pain. GUIers should stick to the vanilla editor.

 

[deathismyfriend]

Back when I used to use GUI I would switch between JNGP and the vanilla editor just to copy over hashtable keys. It was a pain. GUIers should stick to the vanilla editor.

u should reread wat i said. i said this is possible in WE. i didnt say he should use JNGP. u cant do this with hashtables in JNGP for GUI.

 

[maddeem]

u should reread wat i said. i said this is possible in WE. i didnt say he should use JNGP. u cant do this with hashtables in JNGP for GUI.

You clearly misread my post t.t
I perfectly understood what you said, I was confirming it.

 

[defskull]

I don't have time to test this map so I'm just gonna ask you one question:
Does the kill gets registered if the kill is made by a dummy that is spawned from a unit's spell ?

Example:
A hero targets an enemy unit using Spell A - in which this spell will spawn dummy unit to cast Storm Bolt and the Storm Bolt killed the target.

Now, does the kill gets registered ?

If it doesn't, well, fix it

If it does, good job

 

[13oot-Me]

I don't have time to test this map so I'm just gonna ask you one question:
Does the kill gets registered if the kill is made by a dummy that is spawned from a unit's spell ?

Example:
A hero targets an enemy unit using Spell A - in which this spell will spawn dummy unit to cast Storm Bolt and the Storm Bolt killed the target.

Now, does the kill gets registered ?

If it doesn't, well, fix it

If it does, good job

No it would not be registered for the casting unit of the spell, and now that you mention it this system would give the dummy unit the veteran ability. I guess i'll have a couple of things to change.

I wonder... How would I even go about fixing that for a spell that uses dummies?

 

[defskull]

I've got this comment too (with my Rank system)
Just wanna see how you would react

Good luck

 

[13oot-Me]

I have changed a couple things but won't update until I figure out the dummy-unit caster bug.

I've got this comment too (with my Rank system)
Just wanna see how you would react

Good luck

Out of curiosity, did you get your system to give kills to the casting unit of the dummy spell?

 

[defskull]

Out of curiosity, did you get your system to give kills to the casting unit of the dummy spell?

No, and that is why your system is not unique.
If you manage to solve this problem, yes, your system beats me.

I do know how to solve the problem, but guess I'm too lazy ;p

Hint: Use a Hashtable to link the dummy and the caster

I have changed a couple things but won't update until I figure out the dummy-unit caster bug.

It's not a bug, it's a feature.

 

[Maker]

-The rank icon has no disabled version
-You could store a boolean and check the boolean for blocked units instead of using a loop
-You could store a boolean and check the boolean for abilities instead of using a loop

 

[13oot-Me]

-The rank icon has no disabled version
-You could store a boolean and check the boolean for blocked units instead of using a loop
-You could store a boolean and check the boolean for abilities instead of using a loop

What do you mean? I don't understand how I would use one boolean to check for multiple units/abilities that I want to check.

 

[Maker]

At map init, you store a boolean using the ability id as a key, then you load the boolean later.