Unsure about trigger

[Karzama]

I've started making some spells of my own. This one is for my pokemon map. The problem is if the spell is cast by multiple units at the same time... Will the variables still work?

• Nightshade
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Nightshade (Level 4)
  • Actions
    • Set Nightshade_Caster = (Casting unit)
    • Set Nightshade_Target = (Target unit of ability being cast)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Level of Nightshade (Level 4) for Nightshade_Caster) Equal to 1
      • Then - Actions
        • Unit - Cause Nightshade_Caster to damage Nightshade_Target, dealing ((Real((Hero level of Nightshade_Caster))) x 4.00) damage of attack type Spells and damage type Normal
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Level of Nightshade (Level 4) for Nightshade_Caster) Equal to 2
          • Then - Actions
            • Unit - Cause Nightshade_Caster to damage Nightshade_Target, dealing ((Real((Hero level of Nightshade_Caster))) x 8.00) damage of attack type Spells and damage type Normal
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Level of Nightshade (Level 4) for Nightshade_Caster) Equal to 3
              • Then - Actions
                • Unit - Cause Nightshade_Caster to damage Nightshade_Target, dealing ((Real((Hero level of Nightshade_Caster))) x 12.00) damage of attack type Spells and damage type Normal
              • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (Level of Nightshade (Level 4) for Nightshade_Caster) Equal to 4
                  • Then - Actions
                    • Unit - Cause Nightshade_Caster to damage Nightshade_Target, dealing ((Real((Hero level of Nightshade_Caster))) x 16.00) damage of attack type Spells and damage type Normal
                  • Else - Actions
                    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                      • If - Conditions
                        • (Level of Nightshade (Level 4) for Nightshade_Caster) Equal to 5
                      • Then - Actions
                        • Unit - Cause Nightshade_Caster to damage Nightshade_Target, dealing ((Real((Hero level of Nightshade_Caster))) x 20.00) damage of attack type Spells and damage type Normal
                      • Else - Actions
                        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                          • If - Conditions
                            • (Level of Nightshade (Level 4) for Nightshade_Caster) Equal to 6
                          • Then - Actions
                            • Unit - Cause Nightshade_Caster to damage Nightshade_Target, dealing ((Real((Hero level of Nightshade_Caster))) x 25.00) damage of attack type Spells and damage type Normal
                          • Else - Actions

 

[Maker]

It will work.

You could use unitLevel*(4*abilityLevel) for the damage instead of the if/then/else.

Use [hidden][/hidden] tags for the trigger.

 

[DVendetta]

i think when more than a unit use that ability, the last unit used the ability will be the NightShade_Caster variable, other way it will leaks. you can avoid that by doing the following steps:

1- make the variable array and set the size to 1.
2-use that trigger instead you are using.

• NightShade
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to NightShade (Level 4)
  • Actions
    • Set NightShade_Caster[(Player number of (Owner of (Casting unit)))] = (Casting unit)
    • Set NightShade_Target[(Player number of (Owner of (Casting unit)))] = (Target unit of ability being cast)

 

[Miles111]

Instead of using the variable "NightShade_Caster", why dont you just use "Event Response - Casting Unit"? It will save you the space that the variable would take up

 

[dudeim]

Don't use casting unit it just refers to triggering unit and for the damage formula as maker said:
Hero Level of Triggering Unit * (Level of NightShade (level 4) * 4)

 

[Maker]

i think when more than a unit use that ability, the last unit used the ability will be the NightShade_Caster variable, other way it will leaks. you can avoid that by doing the following steps

It can only cause one leak per game per a global variable used. And that is insignificant. The memory leak is so small it is difficult to even measure it.

No arrays should be used in this trigger

 

[Karzama]

Yay! A successful trigger! One other point... I've got a few other spells like this (with their own variables and stuff)... They should be good too yes?

 

[DVendetta]

It can only cause one leak per game per a global variable used. And that is insignificant. The memory leak is so small it is difficult to even measure it.

No arrays should be used in this trigger

you the best maker

 

[defskull]

Instead of using the variable "NightShade_Caster", why dont you just use "Event Response - Casting Unit"? It will save you the space that the variable would take up

By using native function, without saving it to a variable and if you use that function more than one time, you should use variable, why ?

Because, once you set the native function to a variable, it will not generate new set of function everytime you repeat the same usage process in a single trigger, therefore it's less efficient if you keep calling the same function, when you can actually save it first, and call it whenever necessary (in a single trigger)

But if you use it only once per single trigger, then it's okay to call it by its native function (doesn't need to save it to variable)

This is all matter of efficiency.