My Map Crashes to Main Menu

[flacidTurtle]

Hey Guys, I use New Gen
I tested my map, instantly brought to main menu. can't get it to work ingame, just sends me to main menu. friend tried, same thing. I worked literally 10 minutes ago. I copied one trigger, its event driven

• ReapAbility
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Reap
  • Actions
    • Unit Group - Pick every unit in (Units within 300.00 of (Position of (Casting unit)) matching (((Matching unit) belongs to an enemy of (Owner of (Casting unit))) Equal to True)) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Level of Reap for (Casting unit)) Equal to 1
          • Then - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Percentage life of (Picked unit)) Less than or equal to 10.00
              • Then - Actions
                • Unit - Cause (Casting unit) to damage (Picked unit), dealing 1000000000.00 damage of attack type Chaos and damage type Normal
              • Else - Actions
                • Unit - Cause (Casting unit) to damage (Picked unit), dealing ((Real((Intelligence of (Casting unit) (Include bonuses)))) x 1.00) damage of attack type Spells and damage type Normal
          • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Level of Reap for (Casting unit)) Equal to 2
          • Then - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Percentage life of (Picked unit)) Less than or equal to 15.00
              • Then - Actions
                • Unit - Cause (Casting unit) to damage (Picked unit), dealing 1000000000.00 damage of attack type Chaos and damage type Normal
              • Else - Actions
                • Unit - Cause (Casting unit) to damage (Picked unit), dealing ((Real((Intelligence of (Casting unit) (Include bonuses)))) x 2.00) damage of attack type Spells and damage type Normal
          • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Level of Reap for (Casting unit)) Equal to 3
          • Then - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Percentage life of (Picked unit)) Less than or equal to 20.00
              • Then - Actions
                • Unit - Cause (Casting unit) to damage (Picked unit), dealing 1000000000.00 damage of attack type Chaos and damage type Normal
              • Else - Actions
                • Unit - Cause (Casting unit) to damage (Picked unit), dealing ((Real((Intelligence of (Casting unit) (Include bonuses)))) x 3.00) damage of attack type Spells and damage type Normal
          • Else - Actions

 

[WaterKnight]

If you think it's the trigger, then try deactivating it. Generally narrow it down. Or attach the map.

 

[Maker]

On a side not, get rid of the ability checking if/then/elses.

Chage these lines
Percentage life less than 5 + 5*level of ability
Damage int*level of ability

https://www.hiveworkshop.com/forums/triggers-scripts-269/things-leak-35124/

 

[flacidTurtle]

So i deleted, re added it. it worked. added another ability, same problem as original. is there a problem with my map that causes new triggers to malfunction?

Same process fixed it again, but itd be really annoying if I had to do this every time I wanted to add a new trigger

 

[chobibo]

Try using a smaller value than 1000000000.00, might help.

 

[-Kobas-]

Can you share map. Uploaod it as attachment pls.

 

[flacidTurtle]

I figured it out. After searching through the forums an hour, someone had a similar problem however long ago; apparently it's caused when you add a jass trigger to the map, and then test map without saving first. Just a bug with NewGen Editor. So the solution, Save before Test
Thanks guys, +Reps

 

[-Kobas-]

I have been coding (C++, Python, Java, Flash) for several years, and making maps for several games (sc1, C&C, Wc3, sc2, Hlf1, Hlf2, Other Source Games) since I was 8 years old. And I only just figured our how to use the For Loop in the WC3 GUI.

I don't believe you.
The way you coded that trigger is really bad.
There are few things you can't know like (TriggeringUnit = CasterUnit in this case) but, using argument instead 3 or more if then else blocks seems reasonable.

 

[flacidTurtle]

free time coding vs professional coding is an entirely different world. if all you have to say is something negative about my code, then don't bother. I don't care about your ad hominems. My code works and I've never had an issue in any map where my code made the map unplayable. If you must know or intend to insult my coding abilities again, i'll inform you that I tend to review my code and change it for optimum efficiency to my best knowledge. Thanks for the input

 

[WaterKnight]

Testing the map in JNGP does not effectively run the vjass compiler.