[Trigger] Unit Group Memory Leak Problem

[seurimas]

• TheSelect
  • Events
  • Conditions
  • Actions
    • Unit Group - Pick every unit in (Units of type Circle of Power) and do (Actions)
      • Loop - Actions
        • Unit - Remove (Picked unit) from the game
    • Custom script: set bj_wantDestroyGroup = true

See, this is how I have it now. I had it backwards before which resulted in the whole iteration never working. Now, it works the first time, but not the second.

So, what's the right way to do it? Cause I only found a mention of this years ago and can't remember.

Thanks in advance.

 

[Marcelo Hossomi]

The custom script should be before the action...

 

[-Berz-]

Yes, use custom string, before you pick every unit.

Also you can set a variable (unit group)

And destroy it by using

call DestroyGroup(udg_<my group var>)

 

[seurimas]

That'll probably work better, thanks plenty.

 

[ALiEN95]

• TheSelect
  • Events
  • Conditions
  • Actions
    • Unit Group - Pick every unit i:mwahaha:n (Units of type Circle of Power) and do (Actions)
      • Loop - Actions
        • Unit - Remove (Picked unit) from the game
    • Custom script: set bj_wantDestroyGroup = true

See, this is how I have it now. I had it backwards before which resulted in the whole iteration never working. Now, it works the first time, but not the second.

So, what's the right way to do it? Cause I only found a mention of this years ago and can't remember.

Thanks in advance.

You need to set variable for your unit group

set=YourUnitGroup
Pick every units in YourUnitGroup and do actions
-remove picked unit
Custom script: call DestroyGroup(udg_YourUnitGroup)

 

[ALiEN95]

The custom script should be before the action...

Are you sure ???I think its after the action...

 

[redscores]

Well, the way you did it, you need it before the action, the way alient tells it needs after the action.

 

[ALiEN95]

just do it on my way it will be good i saw many people doing it like that
set YourUnitGroup=units owned by player 1(red).....
Pick every units rom YourUnitGroup and do actions....
costom script DestroyGroup(udg_YourUnitGroup)

 

[redscores]

His way destroys all the groups in the trigger which get created after the trigger ends.

 

[PurplePoot]

His way destroys all the groups in the trigger which get created after the trigger ends.

No it doesn't. Check out the code if you don't believe me.

--

bj_wantDestroyGroup is handy in GUI simply because it's a little shorter and allows you to not screw with variables when you don't need them.

just do it on my way it will be good i saw many people doing it like that

Lots of people doing something doesn't make it smart.

 

[ALiEN95]

Can someone say how it should be done and is my way good or wrong?

 

[PurplePoot]

Either way works, your way is just a bit more annoying to write.

 

[darthfett]

Can someone say how it should be done and is my way good or wrong?

These are both the correct solution:

The custom script should be before the action...

set=YourUnitGroup
Pick every units in YourUnitGroup and do actions
-remove picked unit
Custom script: call DestroyGroup(udg_YourUnitGroup)

Basically, the bj_wantDestroyGroup is checked every time a GUI "Pick every units in ..." function runs, and if it is true, it destroys the group, and sets it to false again. If it is false, it leaves the group alone.

I believe setting it to a variable, and then destroying it yourself makes your code more readable, however.

 

[seurimas]

As I said, I'm doing it

Set variable group
Pick every unit blah blah blah
Destroy group

And it's working wonderfully, thanks for all the input.

 

[redscores]

Purple, you are all wrong, the bj_wantDestroyGroup will destroy ALL the groups in the WHOLE trigger after completing the execution of the trigger, I tested it, and I hate people like you which think they know everything, beside that my sources are jassvault and others..

YOU should explain what something does before you give the suggestion to other people, if he uses this in combination with 2 groups in 1 trigger which 1 of those should be saved and the other deleted and he forgets to set it false it will bug the hell out of the trigger.

 

[PurplePoot]

Purple, you are all wrong, the bj_wantDestroyGroup will destroy ALL the groups in the WHOLE trigger after completing the execution of the trigger, I tested it, and I hate people like you which think they know everything, beside that my sources are jassvault and others..

YOU should explain what something does before you give the suggestion to other people, if he uses this in combination with 2 groups in 1 trigger which 1 of those should be saved and the other deleted and he forgets to set it false it will bug the hell out of the trigger.

function ForGroupBJ takes group whichGroup, code callback returns nothing
    // If the user wants the group destroyed, remember that fact and clear
    // the flag, in case it is used again in the callback.
    local boolean wantDestroy = bj_wantDestroyGroup
    set bj_wantDestroyGroup = false

    call ForGroup(whichGroup, callback)

    // If the user wants the group destroyed, do so now.
    if (wantDestroy) then
        call DestroyGroup(whichGroup)
    endif
endfunction

Go away.

 

[Eleandor]

phail.