Unit Group Leaks

[GodsHand]

I just have a quick question. Unit groups leak if not destroyed right? so if for example i make a trigger that calls the units in the group say every .00000001 of a second im about to experience an unhappy computer?

 

[baassee]

then you will have alot of memory leaks and suffer huge laggs and after a crash

 

[Adiktuz]

I just have a quick question. Unit groups leak if not destroyed right? so if for example i make a trigger that calls the units in the group say every .00000001 of a second im about to experience an unhappy computer?

is that decimal even possible in warcraft?

 

[baassee]

is that decimal even possible in warcraft?

I think 0.01 is the minimum

 

[Adiktuz]

I think 0.01 is the minimum

no... you can use 0.00

 

[baassee]

then it isnt every "value", it is all the time

 

[Maker]

You can go lower than 0.01, you just have to use arithmetic function in GUI:

• Untitled Trigger 108
  • Events
    • Time - Every (0.01 / 2.00) seconds of game time
  • Conditions
  • Actions
    • Set Temp_Real_4 = (Temp_Real_4 + 1.00)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Temp_Real_4 Equal to 1000.00
      • Then - Actions
        • Game - Display to (All players) the text: (String(Temp_Real_4))
        • Trigger - Turn off (This trigger)
      • Else - Actions

• Untitled Trigger 108 Copy
  • Events
    • Time - Every 0.01 seconds of game time
  • Conditions
  • Actions
    • Set Temp_Real_3 = (Temp_Real_3 + 1.00)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Temp_Real_3 Equal to 1000.00
      • Then - Actions
        • Game - Display to (All players) the text: (String(Temp_Real_3))
        • Trigger - Turn off (This trigger)
      • Else - Actions

Temp_Real_4 will display the text a lot sooner.

 

[Adiktuz]

You can go lower than 0.01, you just have to use arithmetic function in GUI:

• Untitled Trigger 108
  • Events
    • Time - Every (0.01 / 2.00) seconds of game time
  • Conditions
  • Actions
    • Set Temp_Real_4 = (Temp_Real_4 + 1.00)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Temp_Real_4 Equal to 1000.00
      • Then - Actions
        • Game - Display to (All players) the text: (String(Temp_Real_4))
        • Trigger - Turn off (This trigger)
      • Else - Actions

• Untitled Trigger 108 Copy
  • Events
    • Time - Every 0.01 seconds of game time
  • Conditions
  • Actions
    • Set Temp_Real_3 = (Temp_Real_3 + 1.00)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Temp_Real_3 Equal to 1000.00
      • Then - Actions
        • Game - Display to (All players) the text: (String(Temp_Real_3))
        • Trigger - Turn off (This trigger)
      • Else - Actions

Temp_Real_4 will diplay the text a lot sooner.

oh.. never thought it would accept that value...

 

[baassee]

neither did I :O

 

[Dr Super Good]

WC3 uses 32 bit floats I believe which means they have limited accuracy. 0 is a perfectly valid time. However it still has a delay as I believe it runs the timer next internal update cycle.

Unit groups do not leak by them selves, they only leak if you make new ones and then lose the pointers to them before destroying them (something WC3.'s garbage collector could easilly catch but does not). Generally I advise making a constant group and then just using the enums on it as they only alter the contense of the group and do not make new groups. This is the most efficent way as you only have like 1 group used by many systems which is never destroyed and always reused meaning no wasted time in object allocation / deallocation.

 

[Mufanza]

How is it nobody ment call DestroyGroup (udg_Unit_Group) yet?

 

[D4RK_G4ND4LF]

How is it nobody ment call DestroyGroup (udg_Unit_Group) yet?

cause

set bj_wantDestroyGroup = true

is better anyway since

ForGroupBJ

includes

call DestroyGroup

anyway

http://wiki.thehelper.net/wc3/jass/Blizzard.j/ForGroupBJ

 

[Adiktuz]

How is it nobody ment call DestroyGroup (udg_Unit_Group) yet?

he knows about it, and if you read the first post his question is about leaks if he do not destroy the groups...

 

[Dr. Boom]

Seas =)

Hmm don't matches the topic - but I didn't know what Maker says so I want to test it.
After I try something else ( don't know why ) but the editor do some mistakes. Take a look for your self.
( The event-time isn't to fast because he do the same thing with 0.10 seconds and 0.25 seconds. )

Trigger

• TriggerReal
  • Events
    • Time - Every 0.01 seconds of game time
  • Conditions
  • Actions
    • Set TempReal1 = (TempReal1 + 0.01)
    • Game - Display to (All players) the text: (String(TempReal1))

Screen

After some time he change the 9 into a 7 after into a 6 and so on ...

 

[baassee]

WC3 uses 32 bit floats I believe which means they have limited accuracy. 0 is a perfectly valid time. However it still has a delay as I believe it runs the timer next internal update cycle.

Unit groups do not leak by them selves, they only leak if you make new ones and then lose the pointers to them before destroying them (something WC3.'s garbage collector could easilly catch but does not). Generally I advise making a constant group and then just using the enums on it as they only alter the contense of the group and do not make new groups. This is the most efficent way as you only have like 1 group used by many systems which is never destroyed and always reused meaning no wasted time in object allocation / deallocation.

are you refering to Risens GroupUtils?