Unit Fusion

[SinisterLuffy]

Not to dampen your efforts, Unit Fusion System pretty much covers all there is to unit fusion without arbitrary limits.

 

[loktar]

Didn't know about that. But made this for someone else, thought I might as well post it
Guess this could still be useful for people who want something simple and don't need more than this.

 

[MyPad]

Releasing a short review:

Spell Review:

The mechanics of the Unit Fusion spell appear to be quite similar to [GUI-Friendly] Unit Fusion System, albeit with a lot of restrictions (unit fusion mechanic is restricted to one spell). There isn't much to say here.
​

Code:

• The filter condition may appear to be wrongfully stated; it checks if the level of the base spell is greater than 0 instead of checking if the spell is being cast.
  
  
• The spell generates a lot of objects. This is likely prone to memory leaks as a result. Try to minimize the amount of generated objects in the pre-fusion process.
  
  
• A timer can be used directly instead of leaving the callback to a trigger. This is prominent in (Fuse__AdjustDamage_Conditions).
  
  
• This spell could benefit a lot more from an OOP approach. (The way instances are generated support a strong data structure).

Rating:

Due to the existence of a generalized Unit Fusion System, as well as the above points,
I'll have to move this to Substandard​

 

[loktar]

Thanks for the review.

The filter condition may appear to be wrongfully stated; it checks if the level of the base spell is greater than 0 instead of checking if the spell is being cast.

This is as intended, it checks if the casting unit has the spell before continuing to the conditions. Maybe this is unnecessary?

The spell generates a lot of objects. This is likely prone to memory leaks as a result. Try to minimize the amount of generated objects in the pre-fusion process.

Hmm, I don't think I can eliminate any objects, but I'll review the code. I tried to be thorough in plugging any leaks though.

A timer can be used directly instead of leaving the callback to a trigger. This is prominent in (Fuse__AdjustDamage_Conditions).

Right, I'll change that.

This spell could benefit a lot more from an OOP approach. (The way instances are generated support a strong data structure).

I wanted to keep this strictly JASS (no vJASS), so unfortunately no OOP approach available.