Unbelievable Lag

[xDeathKnightx]

Hey guys, i kinda need help, badly, i want to continue my cinematic 'TLS:Siege of Surchuri' but it's boring me, becuase, no matter what i do in the trigger editor, it lags. For E.g.

Trigger

• Part H5
  • Events
  • Conditions
  • Actions
    • Camera - Apply Camera 153 <gen> for Player 1 (Red) over 0.00 seconds
    • Camera - Apply Camera 154 <gen> for Player 1 (Red) over 5.00 seconds
    • Camera - Change camera smoothing factor to 2.00
    • Wait 2.00 seconds
    • Animation - Change Sharnae Yakobutso 0443 <gen>'s animation speed to 100.00% of its original speed
    • Animation - Change Raiken Yanobokuya 0455 <gen>'s animation speed to 100.00% of its original speed
    • Wait 2.50 seconds
    • Camera - Reset camera smoothing factor
    • Cinematic - Fade out over 0.50 seconds using texture White Mask and color (100.00%, 100.00%, 100.00%) with 0.00% transparency
    • Wait 1.00 seconds
    • Sound - Play swords <gen>
    • Wait 1.10 seconds
    • Sound - Play menu_slash <gen>
    • Wait 1.00 seconds
    • Unit - Unhide Musashi 0456 <gen>
    • Unit - Unhide Nagamasa Azei 0446 <gen>
    • Animation - Play Nagamasa Azei 0446 <gen>'s stand ready animation
    • Animation - Play Musashi 0456 <gen>'s stand ready animation
    • Animation - Play Raiken Yanobokuya 0455 <gen>'s stand ready animation
    • Unit - Move Raiken Yanobokuya 0455 <gen> instantly to (Center of Rect 124 <gen>)
    • Camera - Apply Camera 156 <gen> for Player 1 (Red) over 0.00 seconds
    • Camera - Apply Camera 157 <gen> for Player 1 (Red) over 15.00 seconds
    • Unit - Make Raiken Yanobokuya 0455 <gen> face Musashi 0456 <gen> over 0.00 seconds
    • Wait 0.25 seconds
    • Cinematic - Fade in over 0.50 seconds using texture White Mask and color (100.00%, 100.00%, 100.00%) with 0.00% transparency
    • Wait 1.00 seconds
    • Cinematic - Send transmission to (All players) from Raiken Yanobokuya 0318 <gen> named Raiken: Play No sound and display Argh! You two again.... Modify duration: Set to 5.00 seconds and Wait
    • Cinematic - Send transmission to (All players) from Musashi 0456 <gen> named Musashi: Play No sound and display Are you joking? I'v.... Modify duration: Set to 6.00 seconds and Wait

Now, everything there, that requires me, to select a 'Unit' or a 'Region' Lags, i don't know why, for example, when i 'send Transmission' from a unit, it says, 'Unit' , click on it. It takes 10 seconds to load the next dialog, where it says, 'Select A Unit' , which also takes 10 seconds to load.

Now, my map is about 1 hour long =/ so i don't know if that is the problem, but is there anything i can do to stop, or at least reduce this? because it is putting me off, finishing my map.

 

[Adiktuz]

hmmm... mine only lags when my comp is already open for a long time...

have you tried toggling the view of the Brush list?

 

[xDeathKnightx]

Yes, i think it might just be because of the size of the map, because when i do other maps, it doesn't lag =/

Maybe this is the problem... too big/ too many triggers?

Screenshot

 

[Datnes]

this leaks:

• Unit - Move Raiken Yanobokuya 0455 <gen> instantly to (Center of Rect 124 <gen>)

Make it like this:

• Set Temp_Point = (Center of Rect 124 <gen>)
• Unit - Move Raiken Yanobokuya 0455 <gen> instantly to Temp_Point
• Custom script - call RemoveLocation(udg_Temp_Point)

 

[xDeathKnightx]

Oh yeah i do removing leaks when it is finished, i make a Variables called, Point[1] and FX[1] and basically set every region and special effect to a variable to remove in-game lagging.

 

[Adiktuz]

if you only use a few indexes, diff variables is more optimized than using an array...

 

[xDeathKnightx]

Yes, but it is a really big map, so using separate variables for each different thing, would be a nightmare, wouldn't it? Inless i don't understand what you stated above properly =/

 

[Adiktuz]

Its all about performance, arrays are slower than normal variables...

as such, its unadvised to use arrays when you only use a few of its indexes (and they also take much space since they always create 8190 indexes, the size you put on the variable editor is just the indexes that would get initialized, but the others are still there)

You won't probably notice the difference for a few scripts, but if you run a lot of those scripts at roughly the same time, you would surely see the drop in performance, so if you only use a few indexes, just use different variables...

performance always comes before everything isn't it?

 

[Dr Super Good]

(and they also take much space since they always create 8190 indexes, the size you put on the variable editor is just the indexes that would get initialized, but the others are still there)

As far as I am aware, jass arrays are dynamic arrays. This means they will allocate a new larger array and then copy the contense of the current array across before dealocating the current array and using the new larger array.
This is the only reason why vJASS uses arrays so heavilly, it would be difficult if each allocated 32 KB of space.

 

[xDeathKnightx]

Whoa, uhm, what you just said was kinda confusing... So because my map is so big, and the cinematic is long, what should i use to remove leaks?
If someone could do like a [TRIGGER.][./TRIGGER] thing, that would be helpful.

Thanks.