[Solved] Triggers causes Wc3 closes

[ArgentinianUser]

Hi everybody, well i was working in my map and something causes that wc3 closes without any window, i tested a lot of times and i guess that i found the problem: the triggers that i use.
My map includes an AI that is working with triggers but it causes that wc3 closes at 15min in every game, i think that when it happen the game have so many actions to do simultaneously... i dont know what to do..
This are the trigger format that i use:

Triggers are off unless the game need it, when AI Pandaren is selected, for example
Sorry for my english

 

[Dr Super Good]

Your triggers are leaking by the looks of things. Although not part of the crash you may want to fix them. Specifically in the picture above the group destroy actions only occur if there are more than 4 units in the group, so while there are less than or equal to 4 the two groups leak. Place the destroy group calls after and outside the conditional statement but still inside the player group loop.

Your trigger also leaks a player group I think. Hard to tell with the GUI.

Is it possible that you get into an infinite loop? For example one of the orders the AI issues then causes more orders which trigger itself.

Maybe your AI design is inefficient. For example the trigger shown above applies to all computers, possibly ones which may never be able to build the unit. Some optimizations could possibly improve AI performance and prevent any crashes.

 

[KILLCIDE]

Is it possible that you get into an infinite loop? For example one of the orders the AI issues then causes more orders which trigger itself.

This. The issued unit order might be causing an infinite loop. Are there any triggers that run off the "A unit is Issued an order with no target?"

Your trigger also leaks a player group I think. Hard to tell with the GUI.

It does.

On top of the leaks DSG pointed out, the GUI function "Unit Group - Units of Type" has an unpreventable leak. I suggest filtering out the unittype with an If / Then / Else.


Also, next time you post triggers, just copy paste them between trigger tags. Take a look at this thread if you're confused on how to do it.

 

[ArgentinianUser]

Okay, first, thanks so much for answers guys, i keep trying to solve this.
I find a way to use triggers that dont requires so many variables:
First i need a trigger to assign race type to AI player, and then other trigger to train the unit

• Set forsaken variable
  • Events
    • Time - Elapsed game time is 3.00 seconds
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Number of living Town Hall (Forsaken) units owned by (Picked player)) Equal to 1
      • Then - Actions
        • Set PlayerIAForsaken = (Picked player)
      • Else - Actions

• Archer Fo
  • Events
    • Time - Every 35.00 seconds of game time
  • Conditions
  • Actions
    • Player Group - Pick every player in (All players controlled by a Computer player) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Number of living Undead Footman (Forsaken) units owned by PlayerIAForsaken) Less than or equal to 3
          • Then - Actions
            • Unit - Order (Random unit from (Units owned by PlayerIAForsaken of type Skeletal Marksman)) to train/upgrade to a Undead Footman (Forsaken)
          • Else - Actions

Is it possible that you get into an infinite loop? For example one of the orders the AI issues then causes more orders which trigger itself.

This. The issued unit order might be causing an infinite loop. Are there any triggers that run off the "A unit is Issued an order with no target?"

I didnt get it this, sorry
You guys mean that the infinite loop can be the reason of the crash? Or i should use a trigger with infinite loop to fix the crash?
The crash can be caused because the map have so many triggers with the "periodic event" timer?

(Sorry for double post, but i couldnt send the entire message)

 

[Dr Super Good]

With Archer Fo there still is a player group (force) leak. You also leak at least 1 group and possibly even 1 or more handles.

Surely the player loop is not even needed?

You guys mean that the infinite loop can be the reason of the crash?

Yes we mean that an infinite loop can cause the crash. Its one of the most common reasons for WC3 suddenly closing without a crash report dialog.

The crash can be caused because the map have so many triggers with the "periodic event" timer?

No it can only be caused by doing something recursive, as mentioned in the example. For example if you have a trigger that fires when a unit is issued a point order and in its actions issues the triggering unit a point order then it will recursively fire itself until the game closes.

 

[ArgentinianUser]

Surely the player loop is not even needed?

Yes, i dont need that player group function, and i understood what you say about infinite loops, thanks for answer again dude