Trigger Problem

[edysan]

Hello i got a problem with a trigger
So here is how the trigger is:

• Events
  • Unit - A unit Finishes training a unit
• Conditions
  • Or - Any (Conditions) are true
    • Conditions
      • (Owner of (Trained unit)) Equal to Player
      • ((Owner of (Trained unit)) is an ally of Player) Equal to True
• Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • (Unit-type of (Trained unit)) Equal to unit1
      • integer1 Equal to 5
    • Then - Actions
      • Unit - Create 1 unit1 for (Owner of (Triggering unit)) at (Position of (Trained unit)) facing Default building facing degrees
      • Set integer1 = 0
    • Else - Actions
      • Set integer1 = (integer1 + 1)
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • (Unit-type of (Trained unit)) Equal to unit2
      • integer2 Equal to 5
    • Then - Actions
      • Unit - Create 1 unit2 for (Owner of (Triggering unit)) at (Position of (Trained unit)) facing Default building facing degrees
      • Set integer2 = 0
    • Else - Actions
      • Set integer2 = (integer2 + 1)

At the start of the map when i train 5 unit1 units the trigger to give me another unit1 and reset the integer1 will work, but if i train unit2 after or while training unit1 the trigger will never work again, and vice verso for unit2

Any help would be appreciated.

 

[goldenflame]

you set the wrong integer variable for unit 2 man. your integer = 0 must be integer2 = 0

 

[IcemanBo]

Your methode is wrong. Even if you train Unit1 ineteger2 will set integer2+1

Do like this:

Trigger

• Aktionen
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • 'IF'-Bedingungen
      • (Unit-type of (Triggering unit)) Gleich unit1
    • 'THEN'-Aktionen
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • 'IF'-Bedingungen
          • integer1 Gleich 5
        • 'THEN'-Aktionen
          • Einheit - Create 1 unit1 for Player 1 (Red) at xxx
          • Set integer1 = 0
        • 'ELSE'-Aktionen
          • Set integer1 = (integer1 + 1)
    • 'ELSE'-Aktionen

Use same IfThenElse-block for unit2, and btw in second IfThenElse you set wrong integer=0

 

[edysan]

you set the wrong integer variable for unit 2 man. your integer = 0 must be integer2 = 0

my wrong typing sry about that

 

[goldenflame]

this would solve your problem

• zzz
  • Events
    • Unit - A unit Finishes training a unit
  • Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • (Owner of (Trained unit)) Equal to Player
        • ((Owner of (Trained unit)) is an ally of Player) Equal to True
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Unit-type of (Trained unit)) Equal to Unit1
      • Then - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • integer1 Less than 5
          • Then - Actions
            • Set integer1 = (integer1 + 1)
          • Else - Actions
            • Unit - Create 1 Unit1 for Player at (Position of (Trained unit)) facing Default building facing degrees
            • Set integer1 = 0
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Unit-type of (Trained unit)) Equal to Unit2
          • Then - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • integer2 Less than 5
              • Then - Actions
                • Set integer2 = (integer2 + 1)
              • Else - Actions
                • Unit - Create 1 Unit2 for Player at (Position of (Trained unit)) facing Default building facing degrees
                • Set integer2 = 0
          • Else - Actions

 

[edysan]

Your methode is wrong. Even if you train Unit1 ineteger2 will set integer2+1

Do like this:

Trigger

• Aktionen
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • 'IF'-Bedingungen
      • (Unit-type of (Triggering unit)) Gleich unit1
    • 'THEN'-Aktionen
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • 'IF'-Bedingungen
          • integer1 Gleich 5
        • 'THEN'-Aktionen
          • Einheit - Create 1 unit1 for Player 1 (Red) at xxx
          • Set integer1 = 0
        • 'ELSE'-Aktionen
          • Set integer1 = (integer1 + 1)
    • 'ELSE'-Aktionen

This is exactly what i needed thank you very much

 

[IcemanBo]

No problem, and better use a variable of type point if you create a unit:

• Set Point = (Position of (Triggering unit))
• Einheit - Create 1 unit1 for Player at Point
• Custom script: call RemoveLocation(udg_Point)

This will remove the location leak.