trigger optimization

[duthorian10]

Wind Hunter

• Wind Hunter
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • (Level of Wind Mastery for (Attacking unit)) Greater than 0
  • Actions
    • Trigger - Turn off (This trigger)
    • Set WH_Loc = (Position of (Attacking unit))
    • Set WH_Loc2 = (Position of (Triggering unit))
    • Set WH_EG = (Units within 350.00 of (Position of (Triggering unit)) matching ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Owner of (Attacking unit))) Equal to True)))
    • Unit - Create 1 Wind Hunter Dummy for (Owner of (Attacking unit)) at WH_Loc facing Default building facing degrees
    • Set WH_Dummy = (Last created unit)
    • Unit - Move WH_Dummy instantly to WH_Loc
    • Hero - Set (Last created unit) Hero-level to (Hero level of (Attacking unit)), Hide level-up graphics
    • Hero - Create (Item-type of (Item carried by (Attacking unit) in slot 1)) and give it to (Last created unit)
    • Hero - Create (Item-type of (Item carried by (Attacking unit) in slot 2)) and give it to (Last created unit)
    • Hero - Create (Item-type of (Item carried by (Attacking unit) in slot 3)) and give it to (Last created unit)
    • Hero - Create (Item-type of (Item carried by (Attacking unit) in slot 4)) and give it to (Last created unit)
    • Hero - Create (Item-type of (Item carried by (Attacking unit) in slot 5)) and give it to (Last created unit)
    • Hero - Create (Item-type of (Item carried by (Attacking unit) in slot 6)) and give it to (Last created unit)
    • Unit - Order (Last created unit) to Attack (Random unit from WH_EG)
    • Animation - Change (Last created unit)'s vertex coloring to (100.00%, 100.00%, 100.00%) with 100.00% transparency
    • Animation - Change (Last created unit)'s animation speed to 500.00% of its original speed
    • Wait 1.00 seconds
    • Unit - Remove WH_Dummy from the game
    • Trigger - Turn on (This trigger)

So I have that trigger ^ and I was wondering if it looks good\leakless and are there any ways to improve it to make it more efficient?

 

[Geshishouhu]

you need to remove the locations and destroy the group after use.

 

[Dr Super Good]

make it more efficient

Remove leaks.
Recycle dummy (create once, re-use later).
Cache function results in local/global variables.
Not use GUI (write more clean JASS than GUI does).

 

[Maker]

http://www.hiveworkshop.com/forums/triggers-scripts-269/things-leak-35124/