Trigger for bonus stats not working

[sethmachine]

Hi,

I tried using the binary count off system for bonus stats (attack speed, spell resistance, and mana). The only one that seems to work is attack speed--the rest don't stack or fail to.

But before that, I use the manual of health tome to give permanent health bonuses. In this function below, I should be adding one manual of health tome (+1 health) every call, so my total hero's health should increase by +100 after 100 calls to this function. This works, but as soon as I add an additional stat to the loop (spell resistance), my hero gains 7 less health everytime. This doesn't make any sense, because the loop structure is the SAME as for attack speed, I just copied and pasted and replaced the names.

So why is this function producing the correct health (+100) but the extended one failing to do so (it adds only 93 health and not 100, even though I call it 100 times).

 

[Adiktuz]

you could really benefit from using Debug messages to pinpoint the erroneous parts of your code...

anyway, it seems to be something with that SP variable if it all works fine when you remove the elseif for that...

 

[sethmachine]

Well I tried changing that value but still same result.

But interestingly (and again this just doesn't make any sense) if I add this line inside the elseif for HP I get 8 less health rather than 7.

 set gain = (newPts / attrRatio[cntNum]) - (attrPts[cntNum] / attrRatio[cntNum])

Quite frustrating...

 

[Adiktuz]

well, that means something in the calculations or in the variable values that are wrong... which is where debug messages can come in handy...

I really find it nice and helpful to put debug messages first to see which part is wrong... and it could help you fix it on your own too

for this, you probably want to put debug messages before each if-checks to see the values for yourself

 

[sethmachine]

well, that means something in the calculations or in the variable values that are wrong... which is where debug messages can come in handy...

I really find it nice and helpful to put debug messages first to see which part is wrong... and it could help you fix it on your own too

for this, you probably want to put debug messages before each if-checks to see the values for yourself

Well I was thinking that, but the calculations work out fine, except when adding that additional elseif case. And since I can't see how it interacts with the other variables to affect the final outcome of the total health gained, I'm quite confused.

I'll need to look up a tutorial for debug message.

 

[Adiktuz]

for example

set gain = (newPts / attrRatio[cntNum]) - (attrPts[cntNum] / attrRatio[cntNum])
//Put a display text here to show value of gain
//If it proves to be wrong, then you would proceed with showing texts about the values
//of each part of the equation

 

[sethmachine]

Alright I think I solved it. It looks like I got caught in a few infinite loops, which prevented the rest of the health from being calculated. That's my only hunch, otherwise it's a mystery (because health should always finish b4 any infinite loop starts), but I guess they add up and prevent further computation.

 

[Maker]

Make sure not to divide by zero.

With integers 5/2 = 2 for example, not sure if that is wanted behaviour here.

 

[Adiktuz]

Alright I think I solved it. It looks like I got caught in a few infinite loops, which prevented the rest of the health from being calculated. That's my only hunch, otherwise it's a mystery (because health should always finish b4 any infinite loop starts), but I guess they add up and prevent further computation.

That is why you need to put debug messages so we can see where it stops...