Tips and Tricks

[Malhorne]

JASS

Don't use GetWidgetX/Y.

Never use location, use real instead.

Use only conditions and no actions.
It involves using Timer and not TSA (TriggerSleepAction or Wait in GUI).
NEVER USED PolledWait (game time in GUI). It leaks and is innacurate as hell

To heal a unit -> SetWidgetLife()
To damage a unit -> UnitDamageTarget()

Use only FirstOfGroup loop and try to avoid for groups.
When using the FirstOfGroup loop use the boolexpr inside the loop.

Use a variable when refering twice or more to something.

Don't null local player handle. It is pointless.

Null global variables handle after usage

Always trust this

GUI

Always use multiple ITE -> So you don't use the Do Nothing shit xD


@JASS AND GUI (not vJASS at all) -> This proves to be useful :3 If you want to convert vJASS to JASS.

 

[Assassins-Creed]

Teach me JASS lol.

 

[Rheiko]

to know jass, you must know how the syntax works
and to know the scripts you could convert GUI triggers to jass
i could be wrong though
i'm also a beginner at jass, so i don't know much

by the way, here is my tips & tricks

Spoiler

destroy unused variables to avoid leaks!

 

[Malhorne]

I got a tutorial on a group.
But not comple (nned pictures) that's why it isn't upload.

 

[T. D. W.]

In a moment :3 just to go onto my laptop ;3

 

[FUJI]

"destroy unused variables to avoid leaks!"

you mean local handlers and agents

 

[Rheiko]

maybe, i don't know what is it called =P
i just know doing it!

 

[Malhorne]

Agent don't have to infact.
It is just that handle extends agent so there is the problem.

 

[T. D. W.]

So, best way to learn jass is to convert your triggers into custom script and inspect how they are written, the end

Hidden

Next stop: tutorial:
i will only teach you about function calls here, all other optimization stuff will be learned when trying to make spells, people will tell you the wrong and goof things and you will be better at jass by then

functions:

example:

Unit - Pause (Triggering Unit)

in jass:
call PauseUnit(GetTriggerUnit(), true)
for instance, this line "calls" PauseUnit function, it takes arguments (needed stuff to work with) and make the desired thing... in here, PauseUnit will get the unit handle GetTriggerUniit() and the boolean true (true to pause, false to unpause)

Okay, let's ease a little now:

function Example takes unit U, boolean B returns boolean
    if B then 
        return IsUnitHidden(U)
    else
        return (GetWidgetLife(U) < 0)
    endif
    return false
endfunction

i created a function, a weird one btw, it will tell you if the unit is hidden if the boolean you give it is true, and it will give you if the unit is dead if the boolean you give it is false, example:

//here, we set a local boolean
local boolean B
//now we use our function:
set B = Example(GetLastCreatedUnit(), true)
//now, B will be true if the last created unit is hidden, and false if it isn't

//another one:
set B = Example(GetLastCreatedUnit(), false)
//now, B will be true if the unit is dead, false if he is alive

//btw, the "//" before some sentences is to start a trigger comment ;P

Hope it helped

 

[Malhorne]

function Example takes unit U, boolean B returns boolean
    if B then
        return IsUnitHidden(U)
    else
        return (GetWidgetLife(U) < 0)
    endif
    return false
endfunction

->

function Example takes unit U, boolean B returns boolean
    return (B and IsUnitHidden(u)) or (not(B) and GetWidgetLife(U)<0))
endfunction

 

[T. D. W.]

xDD yeah it can be this too, but let's make it simple as for his first time he works with functions xD

 

[Malhorne]

Ahah lol ^=^

 

[chobibo]

GetWidgetX/Y
It is faster !

Proof? No loop tests, I've proven it invalid. [here]

 

[Malhorne]

Yeah sorry didn't update.
Don't take it till I prove it.

 

[chobibo]

destroy unused variables to avoid leaks!

Destroy the objects and null the references to avoid memory leaks (for both objects and references)

Yeah sorry didn't update.
Don't take it till I prove it.

Sorry to sound like an asshole, I just woke up and I saw this, I'm the one who should apologize dude.

 

[Malhorne]

You don't have to apologize
I was wrong I though it has been proved

 

[chobibo]

I've only proven that loops aren't benchmarking tools. lol

 

[Malhorne]

Yeah I saw it.
Chobibo can you see the new prototypes on .w3m :3 !
They're probably full of mistakes because I'm tired xD
If you can check it please

 

[chobibo]

Already did, but my brain ain't working at the moment when I try to parse vjass. Maybe later lol

 

[Malhorne]

Okay thanks

 

[Rheiko]

i love to see that thread

Spoiler

I'm referring to "GetWidgetX/Y vs GetUnitX/Y" thread :3

 

[Malhorne]

Ya sorry I truly though it was better xD

 

[chobibo]

I found something from the past. TriggerEvaluate vs TriggerExecute

 

[Assassins-Creed]

Hello guys this is my first question. How do I use SetUnitX/Y WITH facing angle? I don't want call setunitfacing or else I would just use GUI right after.

 

[chobibo]

What do you mean? please explain more.

 

[Assassins-Creed]

SetUnitX(unit, x cord) Can I use facing inside the arguements?

 

[chobibo]

What do you mean by facing? something like polar offset (GUI) or Polar Projection?

 

[Assassins-Creed]

• Unit - Move (Picked unit) instantly to (Point(XCord, YCord)), facing (PW_Angle[TempInt] - 180.00) degrees

I want to do this but doing setunitx. I want to set the facing of the unit which is moving and do something like SetUnitX(unit, cord, facing angle)

 

[chobibo]

Oh, I understand now. You need to use polar projection for that, are you going to use custom script or you code in jass?

 

[Assassins-Creed]

are you going to use custom script or you code in jass?

Custom Script

 

[chobibo]

Oh God... okay here's what you could do:

    call SetUnitX(yourUnit,udg_PosX)
    call SetUnitX(yourUnit,udg_PosY)
    call SetUnitFacing(yourUnit,udg_Angle)

 

[Assassins-Creed]

This is kind of what I wanted to avoid, oh well.

 

[chobibo]

Why would you avoid that call? It's better than using polar projection.
Wait a minute... Could you tell me what are you exactly doing, I think I haven't understood exactly what you want to do.

 

[Malhorne]

So chobibo what is the result ?
I'm a bit lazy to see code/result ^^'

 

[Assassins-Creed]

Why would you avoid that call? It's better than using polar projection.
Wait a minute... Could you tell me what are you exactly doing, I think I haven't understood exactly what you want to do.

Nevermind, it's fine.
Anyways, new problem.
I took on a GUI spell request where it extends then returns to the caster(not the problem).
However, the problem is that when the hero moves, and the spell is still active, the dummy units need to maintain the circle formation around the hero as it moves(I've tried a couple of things and nothing worked, my only idea is using a variable to track each one and (Amount Of Units Using it at the time)*36*36 every 0.03 seconds would probably cause lag.

PS:It's Razor's spell from Dota 2 called Plasma Field or something.

 

[T. D. W.]

Save the Range, Angle, and caster
Increase the range first, using "polar projection" from the caster's position, move the dummies
when reaches max dist, just reduce the range and do the same stuff

 

[Assassins-Creed]

Increase the range first, using "polar projection" from the caster's position, move the dummies

I already did polar offset based on the position of the caster but it didn't work.
I was thinking about using a maxdistance and a regular distance so if the distance is over maxdistance it will subtract the difference and put it in its original place.
But yet again, this would require me giving each of them there own distance array. I'm going to try this when I get home from school.

 

[chobibo]

@Malhorne which code?

 

[T. D. W.]

@Assassins-Creed
What happened when u used polar offset?
send the test map, i'll take a look at it

 

[Malhorne]

@chobibo : the one of your link.
I wanted to know what func is the best.

 

[chobibo]

TriggerEvaluate, but inlining is 55% faster.

 

[FUJI]

The spell of Razor Plasma Field is hard coded base to the group enumeration.

 

[T. D. W.]

It is really simple :/ like KB3D but instead of one damage/missile, it's one damage/circle
Send the test map plz

 

[Malhorne]

Okay let's use inlining

 

[FUJI]

@Jad

It is not simple, how can create a one unique group that handles all of the missile?
the kb3d has a line damage that only damages unit once but PER 1 missile they can damage the affected unit on the another missile source.
But the Plasma Field ability from ( Dota ) can detect if the unit is damaged by another damage source of the missile.

 

[chobibo]

This was one of the reasons why I was urging you to make modules Jad.

 

[Malhorne]

Added structs in GUI/JASS

 

[chobibo]

Malhorne, could you put the jass functions in ljass tags, thanks.

 

[Malhorne]

I'll do it soon

 

[Vinz]

Never use location, use real instead.

I don't want to be that stupid, but why?