[JASS] bj_lastCreatedGroup in FirstOfGroup loops

[kStiyl]

a lot of people seem to be using bj_lastCreatedGroup.. to save a group handle?

                    call GroupEnumUnitsInRange(bj_lastCreatedGroup,this.x,this.y,collsion_size,null)
                    loop
                        set u=FirstOfGroup(bj_lastCreatedGroup)
                        exitwhen u==null
                        call GroupRemoveUnit(bj_lastCreatedGroup,u)
                        if SomeCondition then

the problem is, sometimes I have another FirstOfGroup loop called from functions inside the action. This often collides and is annoying to debug.
any solutions? (this isnt just with my systems.. snippets in jass section used it too)

 

[Troll-Brain]

The answer seems obvious, use several groups.
It's not like if there is an other way.

 

[Magtheridon96]

The answer seems obvious, use several groups.
It's not like if there is an other way.

This.

Snippets in the Jass section only use bj_lastCreatedGroup because we don't like creating a group just for an enumeration (We'll save on handles this way)

If you're doing FirstOfGroup loops within the FirstOfGroup loop, create another group.
OR, you can search blizzard.j to find some other global group : P

 

[mckill2009]

bj_lastCreatedGroup is a preset group handle, means you dont have to create it nor destroy it, if you want instant picking and execution then this is recommended...

 

[Troll-Brain]

If you want to f*** up GUI users use bj_lasCreatedGroup for your instant enumerations, else use your own group(s).

 

[kStiyl]

Thanks for replies.

Would it be better to create a temporary group in function, use it then release it at the end of the function? or just use a global group?

 

[Troll-Brain]

globals groups are theorically better, but that doesn't really matter that much.

 

[Bribe]

If you have a loop within a loop use two global groups. bj_lastCreatedGroup is possible for one of them though I'm not going to reject a resource if it doesn't use it (that would be insane).

However, it doesn't "f*** up" GUI scripts. No GUI user is going to get the value of (Last created group) except for immediately after a group of units are created, which is the exact use you'd use it for in JASS (immediately, not relying on timers or waits to remember the contents of that group).

GroupUtils went quite far with the ENUM_GROUP variable which is historical evidence that using a global group is great. Unfortunately the idea behind GroupUtils is not practical in many cases where you need the fastest and most logical looping possible which is why I made GroupMacro. Just use a second global group from within that loop if you need it. And by a global group I mean declaring it to a new group handle, and never destroying it, like this:

globals
    private group GROUP_2 = CreateGroup()
endglobals

 

[WaterKnight]

You will get a problem if the group function can be run recursively though. Or if you call some function that wants to use the group itself.

Do not think it would be senceful to abuse the blizzard.j variables, this already looks bad in semantics.

 

[Troll-Brain]

You will get a problem if the group function can be run recursively though. Or if you call some function that wants to use the group itself.

Do not think it would be senceful to abuse the blizzard.j variables, this already looks bad in semantics.

+ 42

And you can still push something hard in the ass of gui adepts, simply because you can't expect that a gui user use a variable instead of always "last group".

 

[Bribe]

(Last created group) creates a new group each time it is used, so yeah the user will either set that to a variable or get their resource rejected.

function GetLastCreatedGroup takes nothing returns group
    set bj_groupLastCreatedDest = CreateGroup()
    call ForGroup(bj_lastCreatedGroup, function GetLastCreatedGroupEnum)
    return bj_groupLastCreatedDest
endfunction

 

[Troll-Brain]

, why the heck it always creates a new group ...
That doesn't make any sense, or i'm missing something ?

Anyway my point was not with an official resource, just about a random user.

// creates a new group in gui, we will name it "g"

// use a jass "system" but don't care about the group it used

// use again "g" but with the last created group function == fail.

EDIT : But that will be fine if you use bj_groupLastCreatedDest (i haven't checked other GUI functions though, i just mean that is ok with this function)

 

[Bribe]

Can you give a more practical example? If the user gets the value of (Last created group) after a wait then it doesn't matter if there's a JASS script using it or not, even a GUI script could mess it up at that point. All the GUI script would have to do is create a unit:

function CreateNUnitsAtLoc takes integer count, integer unitId, player whichPlayer, location loc, real face returns group
    call GroupClear(bj_lastCreatedGroup)
    loop
        set count = count - 1
        exitwhen count < 0
        call CreateUnitAtLocSaveLast(whichPlayer, unitId, loc, face)
        call GroupAddUnit(bj_lastCreatedGroup, bj_lastCreatedUnit)
    endloop
    return bj_lastCreatedGroup
endfunction

 

[Troll-Brain]

I've never talked about a wait.

Just gui usage / jass system / gui usage.

Also see my previous edit.

 

[Bribe]

bj_groupLastCreatedDest is unsafe to use cause the GUI user will often destroy that dynamic variable. Though no script ever destroys bj_lastCreatedGroup, it is a perpetual group.

 

[Troll-Brain]

I still believe that saving 32 bits of memory usage isn't worth the use of an ugly bj_
Plus, like i've said you can break a gui code, yes you can argue that a such broken script has already leaks, but leaks are not such an issue, most of times.

Hell, i still don't get why blizzard made a such Get last created group function, i thought it just returned bj_lastCreatedGroup.
GUI will never cease to amaze me.

 

[Bribe]

If you look at WarChasers, they initialize their group array by setting to the variable "Last created group". This was done before you were allowed you use raw custom script. It is also easy to use "Last created group" to move a bunch of newly created units.

 

[Troll-Brain]

Well, this was before vJass (globals declaration directly in script).
And again i'm just talking about random users.

But nevermind, this will never end.
I find that useless and ugly, you find it useful, amen.

 

[ALTELMA]

Summary, bj_LastCreatedGroup is better? I want to know, because I ever read tutorials pick unit group ... so never use this.

 

[mckill2009]

if you want instant action, its OK but if you enumerate your units using ForGroup for latter use then no, depends really...

 

[ALTELMA]

OK Thanks.