Text Placement Fix

[Dark-Zalor]

It works really well. Super easy to use.
Really a good system

function setMessagePlacementOnScreen takes nothing returns nothing
    local framehandle m = BlzGetOriginFrame(ORIGIN_FRAME_UNIT_MSG, 0)
    local framehandle c = BlzGetOriginFrame(ORIGIN_FRAME_CHAT_MSG, 0)
    local real screenRatio = I2R(BlzGetLocalClientWidth()) / I2R(BlzGetLocalClientHeight())

    call BlzFrameClearAllPoints(m)
    call BlzFrameClearAllPoints(c)

    if screenRatio > 1.61 then
        call BlzFrameSetAbsPoint(m, FRAMEPOINT_BOTTOMLEFT, -0.125, 0.235)
        call BlzFrameSetAbsPoint(m, FRAMEPOINT_TOPRIGHT, 0.5, 0.435)
        call BlzFrameSetAbsPoint(c, FRAMEPOINT_BOTTOMLEFT, 0.05, 0.1625)
        call BlzFrameSetAbsPoint(c, FRAMEPOINT_TOPRIGHT, 0.6, 0.4)
    elseif screenRatio  > 1.4 then
        call BlzFrameSetAbsPoint(m, FRAMEPOINT_BOTTOMLEFT, -0.0625, 0.235)
        call BlzFrameSetAbsPoint(m, FRAMEPOINT_TOPRIGHT, 0.50625, 0.435)
        call BlzFrameSetAbsPoint(c, FRAMEPOINT_BOTTOMLEFT, 0.175, 0.1625)
        call BlzFrameSetAbsPoint(c, FRAMEPOINT_TOPRIGHT, 0.725, 0.4)
    else
        call BlzFrameSetAbsPoint(m, FRAMEPOINT_BOTTOMLEFT, 0.01, 0.235)
        call BlzFrameSetAbsPoint(m, FRAMEPOINT_TOPRIGHT, 0.626, 0.435)
        call BlzFrameSetAbsPoint(c, FRAMEPOINT_BOTTOMLEFT, 0.175, 0.1625)
        call BlzFrameSetAbsPoint(c, FRAMEPOINT_TOPRIGHT, 0.725, 0.4)
    endif

    call BJDebugMsg("Thanks doom_sheep :D")

endfunction

should be good like that no? What do you think?
Do you think framehandle variables should be nullified?

 

[Wrda]

Perhaps this could be in the snippets since it's so short.
Still, pretty much useful.

 

[Dark-Zalor]

Hello man,

Your piece of code is really good
I got a bug today, on the right side. the multiboard moved when a timer window get destroyed.

I'm jut initializing the code at the beginning of the map, then I don't change it. Do you think it can reset by itself?

here is my settings

function setScreenWidth takes nothing returns nothing
    local framehandle m = BlzGetOriginFrame(ORIGIN_FRAME_UNIT_MSG, 0)
    local framehandle c = BlzGetOriginFrame(ORIGIN_FRAME_CHAT_MSG, 0)
    local real screenRatio = I2R(BlzGetLocalClientWidth()) / I2R(BlzGetLocalClientHeight())

    call BlzFrameClearAllPoints(m)
    call BlzFrameClearAllPoints(c)

    if screenRatio > 1.61 then
    call BlzFrameSetAbsPoint(m, FRAMEPOINT_BOTTOMLEFT, -0.08, 0.235)
        call BlzFrameSetAbsPoint(m, FRAMEPOINT_TOPRIGHT, 0.5, 0.435)
    call BlzFrameSetAbsPoint(c, FRAMEPOINT_BOTTOMLEFT, 0, 0.17)
        call BlzFrameSetAbsPoint(c, FRAMEPOINT_TOPRIGHT, 0.6, 0.4)
    elseif screenRatio  > 1.4 then
        call BlzFrameSetAbsPoint(m, FRAMEPOINT_BOTTOMLEFT, -0.0625, 0.235)
        call BlzFrameSetAbsPoint(m, FRAMEPOINT_TOPRIGHT, 0.50625, 0.435)
        call BlzFrameSetAbsPoint(c, FRAMEPOINT_BOTTOMLEFT, 0.175, 0.1625)
        call BlzFrameSetAbsPoint(c, FRAMEPOINT_TOPRIGHT, 0.725, 0.4)
    else
        call BlzFrameSetAbsPoint(m, FRAMEPOINT_BOTTOMLEFT, 0.01, 0.235)
        call BlzFrameSetAbsPoint(m, FRAMEPOINT_TOPRIGHT, 0.626, 0.435)
        call BlzFrameSetAbsPoint(c, FRAMEPOINT_BOTTOMLEFT, 0.175, 0.1625)
        call BlzFrameSetAbsPoint(c, FRAMEPOINT_TOPRIGHT, 0.725, 0.4)
    endif

    set m = null
    set c = null

endfunction

Do you think your piece of code did that? Do you think how I can fix it?

Thank you man

 

[doom_sheep]

Do you think your piece of code did that? Do you think how I can fix it?

I don't see how it would but I'm not an expert on frame weirdness. if anyone knows it's probably @Tasyen

 

[erfaned]

Good. I needed something like this for my map.

 

[MyPad]

This is certainly one of those simple fixes that makes one wonder why wasn't
this implemented in the first place. Splendid work.

Would it be possible to adjust the script such that it becomes available to
pre-reforged versions (v.1.31)? Even if not, this does not degrade from
the usefulness of the script that much.

Approved

 

[maddeem]

I2R(BlzGetLocalClientWidth()) / I2R(BlzGetLocalClientHeight())

This ^ will cause a thread crash if the player is alt-tabbed (0 division), leading to bugs (best case scenario) or desyncs (most likely scenario). Considering you have it on a 3 second timer, chances are it will be in it's own thread, so the thread crash should be fine, but it might not be.

Just do

BlzGetLocalClientHeight() != 0 and ....

to ensure 0 division doesn't occur.