[System] [Needs work] Unit Movement

[Nestharus]

This resource has moved here.

--

gone

 

[Bribe]

GetMovingUnitById & IsUnitMovingById. Common sense tells you that a unit should be the return/parameter property, not an integer.

 

[Nestharus]

Changed all functions to ById

 

[Nestharus]

Improved algorithm for checking if a unit was natively moving =). Should work pretty decently on things like platforms now.

 

[Switch33]

Couldn't this just work 100% of the time if you had a boolean that set for units that told if they were natively moving or not? Like in triggers you set that boolean to false for a second when that unit is being moved by triggers for an knockback etc. and then when ur done moving the unit set it to true? I mean that seems like the more sane approach at least. 1 boolean per unit would eliminate the point of some of these timers.

 

[Nestharus]

But then u'd have to configure all spells to work with this system >.>.


That's not really an acceptable approach.

 

[Switch33]

Adding 2 lines to a spell or wtever for whenever a triggered movement takes place isn't actually that much to ask for a user of the system. It's just an alternative way of doing all of this-- I mean it's really not asking that much considering there are other systems out there that require a whole lot more lines of code added on like damage systems etc.

Also I kinda consider this kind of useless if it isn't even true 100% of the time. Most people don't pause units during movement and use SetUnitX() and SetUnitY() so anything like this would have issues detecting movement based on unit movement speed versus small periodic SetUnitX() and SetUnitY().

 

[Nestharus]

If you moved a unit that was standing still, it wouldn't pick up as a natural movement. If you moved a unit that was in the middle of fighting, that would pick up as natural movement.


This looks at the target of the unit and the unit's current order. That's the only good way to do it ; |.

 

[Switch33]

Yeah, I guess thats true. Thinking about it theres even ways that booleans in periodic type triggers for natively moving units will mess up. The only way to get 100% true native movement would be to have all triggered native movement which seems like a mess for lots and lots of units, so this seems like the most reasonable approach at least.

 

[Bribe]

While I haven't had time to test this out in-game yet I have spotted a single area it could improve on, by using RegisterPlayerUnitEvent (I think UnitEvent requires it already, so it wouldn't even add a library requirement). And it could use the unit-argument wrappers for the ById functions.

 

[Nestharus]

And it could use the unit-argument wrappers for the ById functions.

????

 

[Bribe]

* function IsUnitStationaryById takes integer whichUnit returns boolean
* function IsUnitMovingById takes integer whichUnit returns boolean
* function IsUnitNativelyMovingById takes integer whichUnit returns boolean
* function CanUnitMoveById takes integer whichUnit returns boolean
* function GetMovingUnitById takes nothing returns integer

-> Add wrappers for each of these - also GetMovingUnitById doesn't make sense it should be just GetMovingUnitId.

 

[Magtheridon96]

Status report?