[Snippet] [Needs work] Get Learned Abilities

[Nestharus]

This resource has moved here.

--

gone

 

[PurgeandFire]

You should add a comment to explain what the index stands for. Is it the order of their learning or what?

Otherwise, nice snippet.

 

[Nestharus]

Not necessarily order learned. Just think of it like an ability array on the unit and index accesses that array. Count gets the count of that array.

edit
Sadly, this isn't useful for save/load ; P.


I actually made it for my custom xp script thingie as part of the fix to fix levels (UnitStripHeroLevel).

 

[Magtheridon96]

Looks good

set Table(abils[i])[c[i]]=GetLearnedSkill()
set Table(marked[i]).boolean[GetLearnedSkill()]=true

->

set Table(abils[i])[c[i]]=GetLearnedSkill()
set Table(marked[i]).boolean[Table(abils[i])[c[i]]]=true

 

[Bribe]

Table(abils)[c] will take longer to process than GetLearnedSkill()

 

[Magtheridon96]

Well, how about this:

private function Ability takes nothing returns boolean
        local integer i = GetUnitUserData(GetTriggerUnit())
        if (not Table(marked[i]).boolean.has(GetLearnedSkill())) then
            set Table(abils[i])[c[i]]=GetLearnedSkill()
            set Table(marked[i]).boolean[GetLearnedSkill()]=true
            set c[i]=c[i]+1
        endif
        return false
    endfunction

->

    private function Ability takes nothing returns boolean
        local integer i = GetUnitUserData(GetTriggerUnit())
        local integer a = GetLearnedSkill()
        if (not Table(marked[i]).boolean.has(a)) then
            set Table(abils[i])[c[i]]=a
            set Table(marked[i]).boolean[a]=true
            set c[i]=c[i]+1
        endif
        return false
    endfunction

After all, it returns an integer, so creating a local here would be ok

 

[Bribe]

I prefer setting big chunks of text like that to locals anyway,
just to improve readability.

 

[Bribe]

You don't have to typecast "Table(abils[GetIndexedUnitId()])"

The way Table is set up is the return type is already a Table, not an integer.

 

[Bribe]

Will this bug with things like Purge's Libram?

 

[Nestharus]

Uh, added abilities won't pop up. This will only catch regularly learned abilities.

 

[Bribe]

Ok, so suppose you are using Libram with hero abilities, and so you could have multiple layers of different hero abilities (of course you'd learn them along the way and some paradigms will display 0 abilities until you learn them)... will this still work?

Also, you still don't need the typecasting for the Tables, since they are already typecasted as Tables when you load them.

 

[Nestharus]

As long as the hero actually learns the abilities and actually levels them up =).

 

[Bribe]

Well it looks like you deallocate the learned ability if the ability was removed from the hero when you do the "count" method, and it would return 0 even for abilities that are potentially there just temporarily "removed" by Libram. I don't really see the point in checking if the ability was removed... I'm sure you have a reason though. Care to elaborate?

 

[Nestharus]

If a hero lost some levels or an ability was removed with UnitRemoveAbility >.>.

If Libram removes abilities, then yea, it'll return 0. The way to fix it is by hooking UnitAddAbility and UnitRemoveAbility, but that's a bit of overhead. This is only supposed to be for wc3 regular abilities, heh.


I could have a boolean option for hooking though ; )

 

[Bribe]

Or a boolean option to ignore if the ability was removed.

 

[Nestharus]

uhhh, that wouldn't work Bribe -.-. A unit that loses levels or conditions to have an ability >.>.

 

[Bribe]

Well then this just wouldn't work with Libram at all.

 

[Nestharus]

Yup, Libram doesn't work with this.


Really, the only way to do the Libram stuff is to code it straight into there. The reason is because when an ability was removed, you don't know whether it was done by the user, by Libram, or by wc3.


It is impossible to do GetLearnedAbilities outside of the Libram lib =).

 

[PurgeandFire]

I think Libram could use an update. I'll get around to it later on and try to make it compatible if it isn't already. Libram won't remove abilities aside from passives (unless you explicitly tell it to do so), it just disables them, so there shouldn't be a problem there as far as I know. (GetUnitAbilityLevel() will still != 0) But I will need to test it out for passives, ofc, since they are removed.

It actually should work fine with most learned abilities, but I haven't tested it yet. I'll test it sometime this weekend or something.

 

[Bribe]

You could still elimate all the "Table()" typecasting and this needs a better description how to use it and why to use it.

 

[Nestharus]

You could still elimate all the "Table()" typecasting and this needs a better description how to use it and why to use it.

Eh, no real need to remove the table typecasting. It's just extra work for me with no benefit ; P.

why to use it

I'm not going to write something on that. You use it when you have a need for it, end of story -.-. I wrote it because I ended up having a need for it.

how to use it

I'll add that it's an indexed array of abilities ; )

 

[Bribe]

Then your resource suffers obscurity. I can't really think of a reason for it other than the reason you already supported for your other resource, and with that in mind I feel it better to just inline it directly into that other resource. I know how much you hate to couple resources but I feel without any real purpose of this system aside from that one other library it kind of doesn't belong on its own. I think it was troll-brain who said "Cool!=Useful" and I agree with that here --

1. Get learned abilities
2. ???
3. Profit!! (but what kind of profit?)

 

[Nestharus]

Then your resource suffers obscurity. I can't really think of a reason for it other than the reason you already supported for your other resource, and with that in mind I feel it better to just inline it directly into that other resource. I know how much you hate to couple resources but I feel without any real purpose of this system aside from that one other library it kind of doesn't belong on its own. I think it was troll-brain who said "Cool!=Useful" and I agree with that here --

You know that almost no matter what, I refuse to couple. I will never couple 2 resources together for modularity purposes ; ).


And obviously gy'ing this will require gy'ing Hero Reward, which is an extremely useful lib.

 

[Bribe]

I'm not gonna graveyard it so long as it's not inlined but sometimes with JASS you gotta do some ugly stuff inside your code.

With your normal programming you have other rules that help to support modularity but in this case I just don't see the point in adding a requirement that's only going to ever be used for one resource.

 

[Magtheridon96]

1. Get learned abilities
2. ???
3. Profit!! (but what kind of profit?)

Works for me

I guess one way to save this resource is by making another one that requires it. (lol)

 

[Bribe]

I think Magtheridon96 has hit the nail on the head. And since such a useful library is requiring it and "somehow, some mysterious way" it could be used in another system, and it works, it should get promoted.

 

[Magtheridon96]

Well, I don't see why this resource shouldn't be approved:

Minimal Criteria:

- It's working
- It fulfills its purpose
- It's efficient

It gets approved if it's useful.
I'm already using it to display ability icons in a multiboard.
I'm also using it for an ability tree.

 

[Bribe]

Mag thanks for sharing. That makes me feel better about it when I approve it in the next few days.

 

[Nestharus]

This needs one update. The [] should check to make sure that the ability in question is still on the hero.

 

[Bribe]

This version has the updates I have been looking for:

library GetLearnedAbilities /* v1.1.0.0
*************************************************************************************
*
*   Allows one to retrieve all currently learned abilities of a unit
*
*************************************************************************************
*
*   */ requires /*
*
*       */ UnitIndexer /*             hiveworkshop.com/forums/showthread.php?t=172090
*       */ Table /*                   hiveworkshop.com/forums/showthread.php?t=188084
*       */ RegisterPlayerUnitEvent /* hiveworkshop.com/forums/showthread.php?t=203338
*
************************************************************************************
*
*   struct LearnedAbilities extends array
*
*       static method operator [] takes unit u returns LearnedAbilities
*       method operator [] takes integer index returns integer abilityId
*
*       method operator count takes nothing returns integer abilityCount
*
***********************************************************************************/
    globals
        private Table abils
        private Table marked
        private integer array c
    endglobals
    private function Index takes nothing returns boolean
        set abils[GetIndexedUnitId()] = Table.create()
        set marked[GetIndexedUnitId()] = Table.create()
        return false
    endfunction
    private function Deindex takes nothing returns boolean
        call abils[GetIndexedUnitId()].destroy()
        call marked[GetIndexedUnitId()].destroy()
        set c[GetIndexedUnitId()] = 0
        return false
    endfunction
    private function Ability takes nothing returns nothing
        local integer i = GetUnitUserData(GetTriggerUnit())
        if (not marked[i].boolean.has(GetLearnedSkill())) then
            set abils[i][c[i]] = GetLearnedSkill()
            set marked[i].boolean[GetLearnedSkill()] = true
            set c[i] = c[i] + 1
        endif
    endfunction
    private module M
        private static method onInit takes nothing returns nothing
            set abils = Table.create()
            set marked = Table.create()
            call RegisterUnitIndexEvent(Filter(function Index), UnitIndexer.INDEX)
            call RegisterUnitIndexEvent(Filter(function Deindex), UnitIndexer.DEINDEX)
            call RegisterPlayerUnitEvent(EVENT_PLAYER_HERO_SKILL, function Ability)
        endmethod
    endmodule
    struct LearnedAbilities extends array
        static method operator [] takes unit u returns LearnedAbilities
            return GetUnitUserData(u)
        endmethod
        method operator [] takes integer index returns integer
            return abils[this][index]
        endmethod
        method operator count takes nothing returns integer
            local integer i = c[this]
            local integer m
            loop
                exitwhen i == 0
                set i = i - 1
                set m = abils[this][i]
                if GetUnitAbilityLevel(GetUnitById(this), m) == 0 then
                    call marked[this].remove(m)
                    set c[this] = c[this] - 1
                    set abils[this][i] = abils[this][c[this]]
                    call abils[this].remove(c[this])
                endif
            endloop
            return c[this]
        endmethod
        implement M
    endstruct
endlibrary

 

[Nestharus]

What exactly did you change??

And this
exitwhen i == 0

is slower than this
exitwhen 0 == i

at least on my pc

 

[Bribe]

I added the requirement of RegisterPlayerUnitEvent, and deleted all the useless Table() wrappers you put in there.

 

[Nestharus]

You also changed spacing and what not ; P.


I'll update this myself to remove the table wrappers and add RegisterPlayerUnitEvent, kk : ).

 

[Bribe]

oh the joy of properly spacing the code it is like music to my eyes if ever there was such a thing.

 

[Magtheridon96]

Nes, CnP Bribe's code into the first post so I can approve it on the basis that both Bribe and I agree on approving it :L

 

[Anachron]

Nes, when will you learn that uses is depricated and should not be used anymore?

 

[Nestharus]

Nes, when will you learn that uses is depricated and should not be used anymore?

what are you on about now?

edit
@mag

I don't like some of the stuff in his code, and the [] should still check to see if the ability is still on the hero : o.

 

[Anachron]

3 or 4 years ago Vex told me (on wc3c.net) the "use" keyword is depricated and you should use requires instead.

 

[Nestharus]

not like he's ever going to update it again

both do the same thing and uses is shorter than requires

also uses is closer to more standard languages like c++ (using namespace)

 

[Anachron]

Okay whatever. A few letters don't hurt.

 

[Magtheridon96]

So...
Something like:

method operator [] takes integer index returns integer
    if index < c[this] then
        return abils[this][index]
    endif
    return 0
endmethod

 

[Nestharus]

nop

and like I said, Bribe didn't just add in RegisterPlayerUnitEvent. If that was the only thing that he did, I'd be ok with it. I'd have to implement it myself : \.