Star v1.4

[Moderator]

Approved. Everything looks ok. The triggering is good.
I suggest you move on to JASS since you're using that many custom scripts.

 

[-Derp-]

Well, I'd like to know what lightning type looks best with this spell, I provided the option to change to lightning type accordingly.

Type - ingame to change the lightning type.


========

Here are earlier versions of the spell, showing that I did use the custom script to make the spell more efficient, and not bypass JASS moderation.


Absolute2 is the map original map I was going to upload.
Absolute is a version before Absolute2. This contains most of the original triggering.
Star was the first version uploaded.

 

[Magtheridon96]

Since most of this spell is written using Custom script, you should've done it in Jass
Using that many custom scripts would give the moderators the right to moderate it as if it were a Jass resource.
You could easily change it to Jass by the way. (Convert it, fix the InitTrig function)

Over here:

• Or - Any (Conditions) are true
• Conditions
• AbsolLoop Equal to 2
• AbsolLoop Equal to 4
• AbsolLoop Equal to 6
• AbsolLoop Equal to 8
• AbsolLoop Equal to 10
• AbsolLoop Equal to 12

You could check if the integer is greater than 0, less than 13 and if it's even (x%2==0 -> it's even)

Btw, you remind me of -Berz- (The 2 dashes at the beginning and the end of your name and the user title )

edit

• Custom script: call SetUnitExploded( udg_AbsolCast, true )

This line isn't enough if you want to explode a unit.
Add this below it:

• Custom script: call RemoveUnit(udg_AbsolCast)

----

Over here:

• Or - Any (Conditions) are true
• Conditions
• AbsolLoop Equal to 1
• AbsolLoop Equal to 3
• AbsolLoop Equal to 5
• AbsolLoop Equal to 7
• AbsolLoop Equal to 9
• AbsolLoop Equal to 11

You could check if the variable is odd (x%2==1), greater than 0 and less than 12.

-------

• Custom script: call UnitDamageTarget (udg_AbsolDummy, udg_AbsolCast, udg_AH3, true, true, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_FIRE, WEAPON_TYPE_WHOKNOWS)
  • Custom script: call DestroyEffect(AddSpecialEffect( "Abilities\\Spells\\Human\\Thunderclap\\ThunderClapCaster.mdl", GetUnitX(udg_AbsolCast), GetUnitY(udg_AbsolCast) ))

Over here, instead of WEAPON_TYPE_WHOKNOWS, use "null"


----------

edit
Oh and you need to improve your description a bit.

 

[-Derp-]

Magtheridon96's Post

Since most of this spell is written using Custom script, you should've done it in Jass
Using that many custom scripts would give the moderators the right to moderate it as if it were a Jass resource.
You could easily change it to Jass by the way. (Convert it, fix the InitTrig function)#1

Over here:

• Or - Any (Conditions) are true
• Conditions
• AbsolLoop Equal to 2
• AbsolLoop Equal to 4
• AbsolLoop Equal to 6
• AbsolLoop Equal to 8
• AbsolLoop Equal to 10
• AbsolLoop Equal to 12

You could check if the integer is greater than 0, less than 13 and if it's even (x%2==0 -> it's even)#2

Btw, you remind me of -Berz- (The 2 dashes at the beginning and the end of your name and the user title )#3

edit

• Custom script: call SetUnitExploded( udg_AbsolCast, true )

This line isn't enough if you want to explode a unit.
Add this below it:

• Custom script: call RemoveUnit(udg_AbsolCast)

#4


----

Over here:

• Or - Any (Conditions) are true
• Conditions
• AbsolLoop Equal to 1
• AbsolLoop Equal to 3
• AbsolLoop Equal to 5
• AbsolLoop Equal to 7
• AbsolLoop Equal to 9
• AbsolLoop Equal to 11

You could check if the variable is odd (x%2==1), greater than 0 and less than 12.#2

-------

• Custom script: call UnitDamageTarget (udg_AbsolDummy, udg_AbsolCast, udg_AH3, true, true, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_FIRE, WEAPON_TYPE_WHOKNOWS)
  • Custom script: call DestroyEffect(AddSpecialEffect( "Abilities\\Spells\\Human\\Thunderclap\\ThunderClapCaster.mdl", GetUnitX(udg_AbsolCast), GetUnitY(udg_AbsolCast) ))

Over here, instead of WEAPON_TYPE_WHOKNOWS, use "null"
#5
----------

edit
Oh and you need to improve your description a bit.#6

#1 - I do not plan on making the spell JASS. I would have to remove all of the globals, and replace them with locals. Which is painful. I am aware of the number of custom scripts used in this spell; I am merely making the spell more efficient by removing a number of BJ's from the script. I know of a few spells that are on the site that use this; notably Belhammer and Divine Protection. However, that spellmaker did not use Custom Script to the extent that I did.

#2 - Please elaborate. I do not understand the formula you are using.

#3 - Who?

#4 - (If I am correct) I am applying an expiration timer to the dummy unit; it will explode.

#5 - Simple mistake, I actually have 'null' for the other time I damage the unit. Thank you for pointing that out.

#6 - Done. There... honestly isn't much to describe.

 

[Magtheridon96]

@-Derp-:

#1 - Now that I think about it, you should keep it this way
Most GUIers don't even bother implementing Jass script

#2 -

if (x - (x/2) * 2 == 0) then x is even
if (x - (x/2) * 2 == 1) then x is odd


#3 - Nevermind

#4 - Oh. I can't believe I missed that

#5 - ^^

#6 - K Then

 

[Jazztastic]

Btw, you remind me of -Berz- (The 2 dashes at the beginning and the end of your name and the user title )

I see what you did there

EDIT: Magtheridon is right. You remind me a -Berz-, also, you should just write this in jass because like 80% of the actions are custom script. You also seem to know a lot about triggering for someone who only has 2 posts. You use a lot of BB codes well, and if I had to guess, it would be that you aren't a noobie to this site.

 

[Magtheridon96]

lol Beef

Btw, this spell is way too efficient for GUI :3
If I was a mod, I'd wait until you fix those things I pointed out, then I'd approve this spell and give it 4 starts :3

You're only using about 12 BJs in the loop, 3 BJs in the cast trigger, and no BJs in the init ^^

edit

You also seem to know a lot about triggering for someone who only has 2 posts. You use a lot of BB codes well, and if I had to guess, it would be that you aren't a noobie to this site.

He's not the first actually
And he doesn't HAVE to write it in Jass, if he does, 60% of GUIers wouldn't use it (Being discouraged by the Jass script )

 

[Jazztastic]

edit


He's not the first actually
And he doesn't HAVE to right it in Jass, if he does, 60% of GUIers wouldn't use it (Being discouraged by the Jass script )

Yeeeah, i was just thinking maybe -berz- was trying to pull one over us. And it's spelled write, not right

And not writing it in jass does make sense. At the same time, he could immediately jump to JASS if he felt like it. I just know that if it was me, I would pick JASS.

Off Topic

You definitely gave me 1 more rep than I gave you. Curses my low post/rep count!

 

[Magtheridon96]

And it's spelled write, not right

Then I'd better go to sleep

He has shown me some of his work in Jass, he just needs a little more practice, and in maybe a week or so, you'd find him posting vJass systems in the Jass section and extremely efficient spells here

offtopic

Your post/rep ratio is 177/34 -> about 6 That's actually pretty good ^^
There's this guy that has a post/rep ratio of 9/120 :O

 

[Jazztastic]

Must be late wherever you live (Don't you live somewhere in Asia?), cause its 5 pm in America. And if he's pwning the spells this hard on his first submission, I'm terrified to see what will be next. But terrified in a good way. Mag pointed out a few small things in the spell, but once he fixes those 4-6 things he should be fine for approval.

 

[Magtheridon96]

It was 3 AM when I made that post
I gave this a 5/5 cause it's too awesome
It's the most efficient GUI spell I've ever seen
He even avoided using ModuloInteger ^^

 

[Jazztastic]

Lol even after almost a month since this was originally uploaded, I still don't understand like any of it.

 

[Ketsuno Anson]

Needs comments in trigger for GUI noobs...

 

[Jazztastic]

Needs comments in trigger for GUI noobs...

That wouldnt help in the slightest

 

[Ketsuno Anson]

Then are those map maker without GUI knowledge implant this into their map?

 

[-Derp-]

Then are those map maker without GUI knowledge implant this into their map?

If you have no knowledge of coding, how do you make a game?



Anyhow, I've updated the spell so that is has a decent description describing whats going on.

 

[Ketsuno Anson]

Why not? Radiansh0t made one even without knowledge of coding,it's pretty fun too,but let's not get off topic here

 

[Jazztastic]

Then are those map maker without GUI knowledge implant this into their map?

You copy the folder containing the triggers and make sure "automatically create unkown variables" is ticked.

 

[Ketsuno Anson]

I meant about configuring the spell...people have to fix the damage to balance it in their game etc

 

[Jazztastic]

Init trigger

 

[Ketsuno Anson]

Not everything is configurable there,besides I said NO GUI knowledge,so how the hell are they suppose to know that?

 

[Jazztastic]

People with no gui knowledge couldnt edit any other spell anyways lol

 

[Ketsuno Anson]

Lets say...This is your first time to beef park,you are lost without any help. But someone came and gave you a map,you easily found your way out

 

[Jazztastic]

Thread hijackers! Btw Derp i think your post count is permanently stuck at 9, I havent seen it go higher in like a month

 

[Magtheridon96]

-Derp- is already moving on to Jass
Good Luck bro ^^

 

[Jazztastic]

Submit one resource in one form, on to the next

 

[Kam]

Undeclared variable udg_HashAbsol

Also how exactly do you configure damage?

In the map you also reference a unit with ID h001 that does not exist.

 

[Doom_AngeaL]

the top left star image looks like a marijuana leaf..

on topic:

Aye,

4/5. I like it, but comments show there are problems. when fixed, 5/5.
~~DooM

 

[-Derp-]

the top left star image looks like a marijuana leaf..

on topic:

Aye,

4/5. I like it, but comments show there are problems. when fixed, 5/5.
~~DooM

Check the triggers, I've fixed the 'problems', it works without any errors. You should test it yourself; tell me if you see any problems...

 

[Doom_AngeaL]

Check the triggers, I've fixed the 'problems', it works without any errors. You should test it yourself; tell me if you see any problems...

Aye,

Okay, re-rated 5/5.
..still looks like a mari-leaf.
~~DooM

 

[Zegaroth]

+rep for your work and because your a friend.