Spiritual Disrupt v1.1

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

22:40, 6th Jul 2014
PurgeandFire: Review:
http://www.hiveworkshop.com/forums/2552191-post8.html

 

[deathismyfriend]

This is in your else block so it leaks if the else is not run.

• Custom script: call RemoveLocation(udg_spr_dummy_point[udg_spr_current_index])

Don't use 2 unit groups. Put the ITE from the second group into the first and get rid of the second unit group.

This leaks a unit group.

• (spr_picked2 is in (Units within spr_range[spr_level[spr_current_index]] of spr_dummy_point[spr_current_index])) Equal to spr_condition[5]

You also use an old and very inefficient method of indexing. Look at my tutorial Things You Should Know When Using Triggers / GUI on how to properly index / de-index.

 

[pOke]

Instead of the dummy removed trigger, just go to the OE and set the death type to Can't Raise Does not Decay

 

[enterprise]

• (spr_picked2 is in (Units within spr_range[spr_level[spr_current_index]] of spr_dummy_point[spr_current_index])) Equal to spr_condition[5]

Use variable to create unit group for check instead

 

[deathismyfriend]

• (spr_picked2 is in (Units within spr_range[spr_level[spr_current_index]] of spr_dummy_point[spr_current_index])) Equal to spr_condition[5]

Use variable to create unit group for check instead

A variable is not needed. This can be used instead.

• Custom script: set bj_wantDestroyGroup = true

As long as that is set before the unit group creation it will destroy the unit group.

 

[nhocklanhox6]

A variable is not needed. This can be used instead.

• Custom script: set bj_wantDestroyGroup = true

As long as that is set before the unit group creation it will destroy the unit group.

Yes, It doesn't need variable. But set bj_wantDestroyGroup = true is unsafe and drop fps faster than call DestroyGroup(). You can test it by yourself.

----

@BUP: If you use variables array, you need to limit array size of those variables.

• spr Config
  • Events
  • Conditions
  • Actions
    • Set global_interval = 0.03
    • Trigger - Add to spr Loop <gen> the event (Time - Every global_interval seconds of game time)

If you use this way, you should use timer instead of the trigger timer because timer faster than trigger timer.

• Animation - Change spr_dummy[spr_current_index]'s size to (spr_dummy_size[spr_level[spr_current_index]]%, spr_dummy_size[spr_level[spr_current_index]]%, spr_dummy_size[spr_level[spr_current_index]]%) of its original size

=>

• Animation - Change spr_dummy[spr_current_index]'s size to (spr_dummy_size[spr_level[spr_current_index]]%, 0.00%, 0.00%) of its original size

Fix this:

• spr Loop
  • Events
  • Conditions
  • Actions
    • For each (Integer spr_loop) from 0 to (spr_index_listener (- 1 ??????)), do (Actions)
      • Loop - Actions

Saves udg_spr_angle[udg_spr_current_index] * bj_DEGTORAD

udg_spr_speed[udg_spr_level[udg_spr_current_index]] * Cos(constantVar) udg_spr_speed[udg_spr_level[udg_spr_current_index]] * Sin(constantVar)

into variable since they are constant variables.

You've leaked this location I guess since you forgoted to clean the first location.

• For each (Integer spr_loop) from 0 to (spr_index_listener - 1), do (Actions)
  • Loop - Actions
    • Set spr_current_index = spr_index_container[spr_loop]
    • -------- ---------INDEXING ENDS---------- --------
    • Set spr_dummy_point[spr_current_index] = (Position of spr_dummy[spr_current_index])
    • Set spr_distance[spr_current_index] = (Distance between spr_caster_point[spr_current_index] and spr_dummy_point[spr_current_index])

• Else - Actions
  • Set spr_dummy_point[spr_current_index] = (Position of spr_dummy[spr_current_index])
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • spr_timer[spr_current_index] Greater than 0.00
  • Then - Actions
    • Set spr_timer[spr_current_index] = (spr_timer[spr_current_index] - global_interval)
  • Else - Actions
    • Set spr_timer[spr_current_index] = spr_Howl_Interval
    • Special Effect - Create a special effect at spr_dummy_point[spr_current_index] using spr_effect_model[1]
    • Special Effect - Destroy (Last created special effect)

In my memory leaks checker, you've leaked location and group 0.0...

And as pOke said too ^_^..

 

[BUP]

Yes, It doesn't need variable. But set bj_wantDestroyGroup = true is unsafe and drop fps faster than call DestroyGroup(). You can test it by yourself.

----

@BUP: If you use variables array, you need to limit array size of those variables.

• spr Config
  • Events
  • Conditions
  • Actions
    • Set global_interval = 0.03
    • Trigger - Add to spr Loop <gen> the event (Time - Every global_interval seconds of game time)

If you use this way, you should use timer instead of the trigger timer because timer faster than trigger timer.

• Animation - Change spr_dummy[spr_current_index]'s size to (spr_dummy_size[spr_level[spr_current_index]]%, spr_dummy_size[spr_level[spr_current_index]]%, spr_dummy_size[spr_level[spr_current_index]]%) of its original size

=>

• Animation - Change spr_dummy[spr_current_index]'s size to (spr_dummy_size[spr_level[spr_current_index]]%, 0.00%, 0.00%) of its original size

Fix this:

• spr Loop
  • Events
  • Conditions
  • Actions
    • For each (Integer spr_loop) from 0 to (spr_index_listener (- 1 ??????)), do (Actions)
      • Loop - Actions

Saves udg_spr_angle[udg_spr_current_index] * bj_DEGTORAD

udg_spr_speed[udg_spr_level[udg_spr_current_index]] * Cos(constantVar) udg_spr_speed[udg_spr_level[udg_spr_current_index]] * Sin(constantVar)

into variable since they are constant variables.

You leak this location I guess since you forgoted to cleaned the first location.

• For each (Integer spr_loop) from 0 to (spr_index_listener - 1), do (Actions)
  • Loop - Actions
    • Set spr_current_index = spr_index_container[spr_loop]
    • -------- ---------INDEXING ENDS---------- --------
    • Set spr_dummy_point[spr_current_index] = (Position of spr_dummy[spr_current_index])
    • Set spr_distance[spr_current_index] = (Distance between spr_caster_point[spr_current_index] and spr_dummy_point[spr_current_index])

• Else - Actions
  • Set spr_dummy_point[spr_current_index] = (Position of spr_dummy[spr_current_index])
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • spr_timer[spr_current_index] Greater than 0.00
  • Then - Actions
    • Set spr_timer[spr_current_index] = (spr_timer[spr_current_index] - global_interval)
  • Else - Actions
    • Set spr_timer[spr_current_index] = spr_Howl_Interval
    • Special Effect - Create a special effect at spr_dummy_point[spr_current_index] using spr_effect_model[1]
    • Special Effect - Destroy (Last created special effect)

In my memory leaks checker, you've leaked location and group 0.0...

And as pOke said too ^_^..

@nhocklanhox6 ,@deathismyfriend , @poke and @enterprise
Thanks for the advices.
I'll be uploading a fixed version of this spell soon

 

[PurgeandFire]

Review:

• Fix the leaks as deathismyfriend described (the location and unit group).
• See what pOke said. Change it to can't raise, doesn't decay.
• And fix what nhocklanhox6 said.

Hehe. Thanks guys for helping out with the review.

 

[GywGod133]

i recommend you use 0.03125 instead using 0.03

 

[Vinz]

Nice, we don't see much Taurens using spiritual powers.

However you may choose to not include the last trigger, and set Dummies in the OE properly.