Spiritual Charge V1.1b

[Moderator]

16:40, 29th Sep 2010
The_Reborn_Devil:

You're not recycling correctly, but as long as the spell isn't casted 8192 times after each other without letting the last cast end then there won't be a problem.


Status: Approved
Rating: Useful

 

[Prince.Zero]

looks original at some extent
which makes me give it a 4/5 rating and give you some cookies!

 

[illegalpie]

You messed up at the dummy creation, you create it for player 1 red, unless you don't care, usually I either create it for neutral passive or the owner of the casting unit

 

[Sandbox Rpg]

You messed up at the dummy creation, you create it for player 1 red, unless you don't care, usually I either create it for neutral passive or the owner of the casting unit

Oh yes! I forgot about that, thanks for spotting it. Updated map and description.

looks original at some extent
which makes me give it a 4/5 rating and give you some cookies!

Thanks !

 

[x3GlikE]

Wow nice good work
3.9/5
Only thing is that it damages your self??
And i think that it would lagg if you had more than 4 people casing it ??

Anyway good job +rep

 

[Sandbox Rpg]

The fact that it damages allied units as well is done on purpose, as this was made with the intention of it being some kind of initiating spell. If you think it's better off not damaging allied units I'll change it.

Edit: Also, how many spells does a spellpack have to have?

 

[D4RK_G4ND4LF]

damage circular area is said to kill mac users so you should not use it

instead of disabeling collision you should make the dummy fly so he will run the shortest path and not the longest if it is more pathable as the shortest way

you also should remove the timer and make a real variable and increase it

• (Elapsed time for SC_Timer[SC_Index[3]]) Equal to 0.24

should be

• (SC_Duration[SC_Index[3]] mod 0.24) Equal to 0.00

or you could just count from 0 to 0.24 and reset it to 0 if it was 0.24

array variables are a little bit slower than normal ones so it will speed things up if you use Index1, Index2, Index3, etc. and not Index[1], Index[2],... if the variable is used often

also you shoud give credits to JetFangInferno for his model in both your map and in this thread
http://www.hiveworkshop.com/forums/models-530/fire-nova-50408/

 

[Adiktuz]

The fact that it damages allied units as well is done on purpose, as this was made with the intention of it being some kind of initiating spell. If you think it's better off not damaging allied units I'll change it.

Edit: Also, how many spells does a spellpack have to have?

IDK, but I think at least 2 spells...

on your spell, looks good but maybe just add the option to whether damage allies or not.

 

[Sandbox Rpg]

To D4RK_G4ND4LF: Updated map with real variable and given credits. Thanks for reminding me about credits and for the real variable method.

To Adiktuz:

Off-topic

2 spells? good, I'm making one with 3 at the moment.

On-topic, well considering what D4RK_G4ND4LF said about circle killing mac users, I'll just make it damage enemies.

 

[Sandbox Rpg]

This spell is far away from MUI, it's not even SUI.
MUI = Multi Unit Instancibility.
SUI = Single unit instancibility.

Hmm... must of been a problem after changing a couple of things. I'l check to see if i can fix it.

Edit: Ok i've figured out the problem. D4RK_G4ND4LF, can you tell me exactly how using a real variable + modulo works? Because that seems to be the source of the problem, as it's also causing another spell of mine that i'm making not work, and they both have the same problem. Until then I'll switch back to timer variable.

 

[D4RK_G4ND4LF]

http://www.mappedia.de/wiki/Jass:ModuloReal

it will divide a number by another one until it can't be divided by it anymore
now as I am thinking about it it will stop at 0.24 so either you have to * it by 100 or just make another counter variable as you did already

 

[Sandbox Rpg]

This is not 100% MUI yet.
I spammed the spell, a lot - and some dummies remained.

Well I don't know what problems yours has, but after casting the spell 50 times per blademaster in a row, there were still no dummies left.

 

[Sandbox Rpg]

I can send you examble map.

Here: View attachment 88046

It seems that after 99 casts in a row, like in that map, the second part of the trigger, the one after, and including,

• SC_EchoingFinale[SC_Index[3]] Equal to True

just stops working. Now I'm afraid I don't know what happens in that case. I looked through it, and I just can't tell what the problem is...

Edit: The only thing I can think of is that if an array is skipped, but don't see how that would work.

 

[Sandbox Rpg]

You'r triggering is so messy that I can't find the cause =/

Gee, thanks -.- real ego-booster there.

Anyway, whatever the cause is, it doesn't seem to be very severe, as after some further testing I realized it just, effectively, reduces the number of arrays by 1. I set the number of arrays for each variable to 200, doubled the number of times he casts SC, and lo and behold, only 1 dummy was left.

Edit: In fact, after putting a 25 sec delay between 2 waves of 100 casts with the variable array set to 200, no dummies were left.

 

[Sandbox Rpg]

99 was OK; afterall- Could any map have so many loops on one spell?

Well, not any real map no.

So that little bug is ok?

 

[Noobsmoke]

nice job

 

[xDeathKnightx]

I like it, 4/5.

 

[Sandbox Rpg]

Can this get approved?

 

[MortAr]

Please do not use array variables for the indexing.

 

[Sandbox Rpg]

Please do not use array variables for the indexing.

Fixed, can it get approved? I THINK I've made all the changes.

 

[Bankde]

Really great ideas and also coding. Not sure that this have been fixed in rare problem of indexing or not but as I use the spell, it work really well and MUI.

I think from this code you may use only 1 If/then/else with "AND" function.

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • SC_EchoingFinale[SC_Index3] Equal to True
  • Then - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Elapsed time for SC_Timer[SC_Index3]) Greater than or equal to (0.24 x (Real(SC_Counter[SC_Index3])))
      • Then - Actions
        • .............................................

And can't you change "Player" , too ? I have seen many people saying this.

• Unit - Create 1 Dummy Spirit for Player 1 (Red) at SC_CasterLoc[SC_Index2] facing (Angle from SC_CasterLoc[SC_Index2] to SC_TargetLoc[SC_Index2]) degrees

A little smaller of ending effect model would be great.
+rep and 5/5 Great update.

 

[Sandbox Rpg]

Really great ideas and also coding.

What were you saying OffGraphic?

And can't you change "Player" , too ? I have seen many people saying this.

• Unit - Create 1 Dummy Spirit for Player 1 (Red) at SC_CasterLoc[SC_Index2] facing (Angle from SC_CasterLoc[SC_Index2] to SC_TargetLoc[SC_Index2]) degrees

Must of missed that one. Thanks for vote, rep and spotting the mistake.

 

[HaniBon]

You use imported models, makes the effects look good, but using imported models makes import of the spell harder = not good. Just so you know.

 

[Sandbox Rpg]

This spell cannot be approved, as it is not MUI at all.

Picture of Non-MUI'ness.
View attachment 90210


Your spell will go with this:

And yet when I use this spell it always works fine.... You seem to be the only one who keeps complaining that it's not working for you. Also, are you sure your not just going over the index loop limit?

 

[Bankde]

And yet when I use this spell it always works fine.... You seem to be the only one who keeps complaining that it's not working for you. Also, are you sure your not just going over the index loop limit?

For me, it's ok to have some non-MUI problem when using INDEX. I've also encountered one and it's impossible to change code because all the code is already correct and that problem is really really rare to occur once. If you really want COMPLETE-MUI, use hashtable or Jass.

 

[Bankde]

Everything i've made is fully MUI.
I use indexing. - Hashtables are for babies.

Same with Jass.
I use Jass. - vJass/Zinc/cJass is for babies.

I've seen your spell. Some are really great like Fireball (I love that !! +rep)



But for other spell like Time stop and Hydrogen ball, it isn't MUI at all when testing it (Special Effect is MUI but not its damage/effect)

You are LYING, you didn't really use Indexing. You use "Pick every units in unit group" which is the basic of using Hashtables.

Basic of indexing is starting with "For each integer" not "Pick every units".

 

[Sandbox Rpg]

The fact is Offgraphic, you are the only one saying that your stuff.

Also "Pick every unit in unit group" is pretty much the basis of the loop parts of hashtable spells... check Spells in Hashtables if you don't believe me, all the of the loops first action is "Pick every unit in unit group", so your claim that "Pick every unit in unit group" has nothing to do with hashtables is simply false.

Also, this is my first spell ever, just like your hydrogen bomb. Except that I'm not claiming that fact means it's ok to be bad.

And your "Drown" spell is still under work after 3 months!

So you know, shut up about my spells, and work on your own spells please.....

 

[Sandbox Rpg]

"Pick every unit in a unit group" is a group function. It has nothing to do with hashtables.
It can tho, be used in anything you want.

I know, but you were saying that it has nothing at all to do with hashtables, which isn't true.

And you do realize, that user made content has nothing to do with blizzard's functions?

How has that got anything to do with what is said?

 

[Sandbox Rpg]

About the the spellpack, I was referring to the fact that any spell using hashtables will almost always use "Pick every unit in unit group".

And yes, I can take criticisms. What I can't take, is someone constantly berating me that my spell isn't perfect when his spells aren't any better.

Also, I can't help but notice you ignored my mentioning of Drown.

 

[Cihparg]

- Thread cleared of my posts. -

EDIT: Posting a report of how many times this spell actually supports to be cast.
EDIT: Appears that you are overusing effects/dummies. Use less, improve your triggering a lot.
I could do this spell way better, but cannot - As you are doing it.

 

[DarthDeath]

sandbox, why the dummy is the hero?