Lotus Ice v1.1b

[Moderator]

19:55, 2nd Mar 2014
Magtheridon96: The code is practically flawless in terms of efficiency and readability. The spell is also wonderfully configurable. This is 5/5 material, so I'll just go ahead and give you the rating.

A tiny improvement would be to check GetUnitTypeId(other) != 0 inside the conditionFunc to assure a better death check.

Good job.

 

[Malhorne]

local unit f = null -> local unit f

Use call TimerStart(TIMER, PERIODIC, true, function thistype.onPeriodic) and call PauseTimer(TIMER) instead of starting the timer each time.

For the onCast method do something like this :

local ...
local ...
if GetSpellAbilityId() == SPELL_ID then
    Spell core
endif
return false

            set gx = tx
            set gy = ty

Error PJASS variables gx non declared

At last I suggest to always work in radian instead of writing each time the value of bj_DEGTORAD ^^

 

[nhocklanhox6]

local unit f = null -> local unit f

Use call TimerStart(TIMER, PERIODIC, true, function thistype.onPeriodic) and call PauseTimer(TIMER) instead of starting the timer each time.

For the onCast method do something like this :

local ...
local ...
if GetSpellAbilityId() == SPELL_ID then
    Spell core
endif
return false

            set gx = tx
            set gy = ty

Error PJASS variables gx non declared

At last I suggest to always work in radian instead of writing each time the value of bj_DEGTORAD ^^

local unit FoG=null //We initially declare an empty unit handler

if GetSpellAbilityId() == SPELL_ID then
    Spell core
endif
return false

I don't like this way

Use call TimerStart(TIMER, PERIODIC, true, function thistype.onPeriodic) and call PauseTimer(TIMER) instead of starting the timer each time.

You didn't read my code carefully

 

[gorillabull]

call it ice lotus

 

[zv27]

cool spell for ult

 

[Malhorne]

It is pretty useless to declare the local unit u to null ^^...

if GetSpellAbilityId() != SPELL_ID then
                set caster = null
                return false
            endif

->

if GetSpellAbilityId() != SPELL_ID then
                //No need of this line if you want to keep this : set caster = null
                return false
            endif

 

[Cokemonkey11]

Yes, the initial null isn't strictly necessary (I ususally don't declare it), but if you use/check that variable beyond the scope of your FoG loop, it might be useful to have it initialized as null. The performance difference is also negligible, and if it's easier for you to read/understand it then keep it

Spell in the video looks good, don't really have time to check the code though.

 

[deathismyfriend]

Yes, the initial null isn't strictly necessary (I ususally don't declare it), but if you use/check that variable beyond the scope of your FoG loop, it might be useful to have it initialized as null. The performance difference is also negligible, and if it's easier for you to read/understand it then keep it

Spell in the video looks good, don't really have time to check the code though.

I thought that all locals and globals were initialized to null?

 

[Malhorne]

It is pointless

 

[Cokemonkey11]

scope test initializer i
	private function i takes nothing returns nothing
		local unit q
		call BJDebugMsg("hello world")
		if q==null then
			call BJDebugMsg("was null")
		endif
		if q!=null then
			call BJDebugMsg("was not null")
		endif
		call BJDebugMsg("test")
	endfunction
endscope

Go ahead, try it.

 

[Malhorne]

It isn't initialized to null.
Just said it is pointless to init it to nulll.

 

[Cokemonkey11]

Malhorne, I think you have some form of http://en.wikipedia.org/wiki/Selective_auditory_attention

Yes, the initial null isn't strictly necessary (I ususally don't declare it), but if you use/check that variable beyond the scope of your FoG loop, it might be useful to have it initialized as null. The performance difference is also negligible, and if it's easier for you to read/understand it then keep it

 

[Malhorne]

Ya a bit sorry ....

What do you mean by the : "if you use/check that variable beyond the scope of your FoG loop, it might be useful to have it initialized as null" ?

 

[Cokemonkey11]

If you re-use the variable for more than the application mentioned in the tutorial, it could be useful to initialize it as null -> The FoG loop doesn't necessitate null initialization, but other applications may.

 

[Adiktuz]

the visuals look really nice

 

[Malhorne]

@CokeMonkey -> Ok and sorry for my fail before >_<

 

[Heinvers]

WoW. Impressive. I like that extreme frozen feel. A perfect 5/5 or should I say 10/10?