Spinner Trigger

[ImBamboo]

I was wondering if there was a more efficient way of creating a trigger like this. Or if anyone could see a potential leak or problem in it. It creates an effect that circles the unit. When finished it will damage units the spinner comes into contact with; I'm unsure of the most efficient way to do this. Right now I'd likely pick units within range of temp_point. I might make the loop run less often but I'm really not sure right now.

I've attached a couple images of it also since my description is likely terrible.

• Spin Me
  • Events
    • Time - Every 0.05 seconds of game time
  • Conditions
  • Actions
    • Set Spin_Real = (Spin_Real + 10.00)
    • For each (Integer A) from 1 to 8, do (Actions)
      • Loop - Actions
        • Set Temp_Real = (Temp_Real + 15.00)
        • Set Temp_Point = ((Position of Guy) offset by (50.00 x (Real((Integer A)))) towards (Spin_Real - Temp_Real) degrees)
        • Special Effect - Create a special effect at Temp_Point using Abilities\Spells\Items\AIco\CrownOfCmndTarget.mdl
        • Special Effect - Destroy (Last created special effect)
    • Custom script: set udg_Temp_Real = 0.00

 

[HamzahA]

there is a leak : Temp_Point
You should use a small wait in the loop if you want it to look something near the image or do something like that
know that waits in for each integer X loops doesnt skip actions.

 

[RED BARON]

and you can always use a leak checker or an optimizer

 

[Need_O2]

You leak about 2 locations
and yes there are very much efficient wayz in jass ofc

 

[Huurka]

You leak 8 locations every 0.05 seconds :/

 

[RED BARON]

You leak 8 locations every 0.05 seconds :/

lol first he leaks 1 place, then 2 and now 8

 

[GhostWolf]

8 leaks every 0.05 seconds and "nulling" a global, and a REAL at that, for no reason (just confirming since everybody is telling something else).

 

[Eleandor]

lol first he leaks 1 place, then 2 and now 8

He leaks 16 points xD

Set Temp_Point = ((Position of Guy) offset by (50.00 x (Real((Integer A)))) towards (Spin_Real - Temp_Real) degrees)

Position of Guy is point 1. Temp_Point itself is point 2, since its never removed using RemoveLocation. 2 * 8 = 16

(next guy should probably say 32 points or something)

 

[NoNZealot]

32! 32! 32! 32!

Remember to set the other reals/integers to 0 and remove locations, ImBamboo...

And yes, there're a lot more efficient ways to do what you've done there. You might want to check thehelper forums to see some good examples.

 

[GhostWolf]

He leaks 16 points xD

Nah, 64.3 leaks.
Anyway, pwnt. Didn't notice he used a location inside the location.

Remember to set the other reals/integers to 0 and remove locations, ImBamboo...

The hell are you talking about ? You do not need to set any globals to zero/null and even further - you do not need to null any primitive type (int, boolean, float (AKA in warcraft: real), etc) -,-

 

[Need_O2]

ah yea forgive me yes he leaks 16 at every 0.05 secs

 

[RED BARON]

Yea the leaks just keep stacking

 

[Razorbrain]

16 x 20 = 320 leaks per Second :O