[Snippet] GetUnitCount

[edo494]

library GetUnitCount uses UnitIndexer/*
by edo494 v1.2
    
    requires - UnitIndexer: http://www.hiveworkshop.com/forums/jass-resources-412/system-unit-indexer-172090/

    API:
        
        function GetUnitCount takes nothing returns integer
            - returns current number of indexed units on the map
        
*/
private struct UnitCount extends array
    readonly static integer count = 0
   
    private static method onIndex takes nothing returns boolean
        set count = count + 1
        return false
    endmethod
   
    private static method onDeindex takes nothing returns boolean
        set count = count - 1
        return false
    endmethod
   
    private static method onInit takes nothing returns nothing
        call RegisterUnitIndexEvent(Condition(function thistype.onIndex), UnitIndexer.INDEX)
        call RegisterUnitIndexEvent(Condition(function thistype.onDeindex), UnitIndexer.DEINDEX)
    endmethod
endstruct

function GetUnitCount takes nothing returns integer
    return UnitCount.count
endfunction
    
endlibrary

change notes

1.1

• added function GetUnitCountEx, takes:
  • boolean countLocust - whether or not we want to count locust units
  • boolean countDeadUnit - whether or not we want to count dead units
  • boolean countDeadHero - whether or not we want to count dead heroes

1.2

• remade whole code, now fires on INDEX/DEINDEX events

1.3

• rewrote code to mag's version

 

[Nestharus]

Why not just make this really simple and use UnitIndexer?

 

[edo494]

this would be redundant as is if the unitindexer had method/function to get the highest value(the biggest current index) but as I didnt find it, I had to make this for the GetKiller to loop enough times but not too many

 

[Nestharus]

huh??

then why don't you just use UnitList? It has a list of every unit on the map, lol


this just wasn't written very well, if you want a count

onIndex
count + 1

onDeindx
count - 1

: \

if you want to handle dead/alive units, then use UnitEvent as well to detect revival and mag's event player unit thing to detect death

 

[edo494]

remade code

 

[Nestharus]

This will not count units ; )

if GetUnitUserData(GetIndexedUnit()) > unitCount then

is wrong

it should just be

+1 on increment
-1 on decrement

nothing else needed

 

[Magtheridon96]

^You're right.

 

[edo494]

no, GetKiller wont work anymore, because it repeats loop for unitCount times, but if I just made enters: +1, leaves: -1, and I get lets say 20, when 2 units with indexes other than 20, 19 leaves, lets say unit at index 6 and 7 leaves, than it would return 18, but GetKiller needs to loop 20 times because the biggest index of unit is 20, so it would only run 18 times leaving unit [19] and unit [20] without checking
I should change the name but cant find something simple yet normal

 

[Nestharus]

use a linked list then

 

[Chaosy]

Nice simple script you got there but rename the function to "GetUnitCount" it is more jass-ish

 

[Anachron]

I don't see how this can work?

if GetUnitUserData(GetIndexedUnit()) == unitCount then

So if I remove unit with index 0 this will not trigger???
It's as simple as Nes said it. Index = +1, Deindex = -1.

 

[Magtheridon96]

edo, you're not supposed to make the code in this script be interconnected with the script in another resource.

This is a bad software engineering practice.

This should get the unit count on the map, and that's it, meaning that it will return accurate unit counts.
In your other resource, you should use a linked list as Nestharus said. You could use a stack if you want too.

 

[Nestharus]

A stack wouldn't work

Honestly, he could just use UnitList...

 

[Magtheridon96]

For a proper GetUnitCount resource, this would be the code

private struct UnitCount extends array
    readonly static integer count = 0
    
    private static method onIndex takes nothing returns boolean
        set count = count + 1
        return false
    endmethod
    
    private static method onDeindex takes nothing returns boolean
        set count = count - 1
        return false
    endmethod
    
    private static method onInit takes nothing returns nothing
        call RegisterUnitIndexEvent(Condition(function thistype.onIndex), UnitIndexer.INDEX)
        call RegisterUnitIndexEvent(Condition(function thistype.onDeindex), UnitIndexer.DEINDEX)
    endmethod
endstruct

function GetUnitCount takes nothing returns integer
    return UnitCount.count
endfunction

This "GetKiller" resource would have to use its own internal stack or count.
The semantics of this should be intuitive and global :/

 

[edo494]

updated

 

[Magtheridon96]

Approved.

 

[Fingolfin]

Why is this a struct if you only have static methods and no instances? You might aswell just make it a scope.

 

[edo494]

for the lolz

 

[Magtheridon96]

A library is required here.

The reason behind the presence of the struct is simply because of the preferred style of initialization with the onInit struct method. It really doesn't add or remove anything from the resource.

 

[Fingolfin]

Scopes can also have initializers........

 

[edo494]

scopes initializers runs the second from last(only thing that initializes later is InitTrig) and also you cant call function from scope if you are calling it from library(GetUnitCount())

 

[Fingolfin]

Well, why not just do this???

library GetUnitCount uses UnitIndexer initializer Init

    globals
        private integer count = 0
    endglobals
   
    private function onIndex takes nothing returns boolean
        set count = count + 1
        return false
    endfunction
   
    private function onDeindex takes nothing returns boolean
        set count = count - 1
        return false
    endfunction
   
    private function Init takes nothing returns nothing
        call RegisterUnitIndexEvent(Condition(function onIndex), UnitIndexer.INDEX)
        call RegisterUnitIndexEvent(Condition(function onDeindex), UnitIndexer.DEINDEX)
    endfunction

    function GetUnitCount takes nothing returns integer
        return count
    endfunction
    
endlibrary

Cause the struct will create an array which you are not using.

 

[edo494]

you maybe missed the extends array

this only generates the following globals:

constant integer si__GetUnitCount___UnitCount=6
integer s__GetUnitCount___UnitCount_count= 0

I actually went and compiled it to check myself

 

[Fingolfin]

Alright, sure. Then i suppose it makes no difference. Still think it is an improper use of structs though, but whatever works i guess.

 

[edo494]

well yea it was inside private functions before, but meg posted code in structs, I just CnP'ed it in to the resource

 

[Magtheridon96]

CnP what Fingolfin posted, I've grown to believe that the misuse of constructs like structs is just terrible ~.~

I just dismissed any change yesterday because yeah.

 

[Troll-Brain]

The struct has not to be private so then you can use UnitCount.count if you can't live with such syntax.

And it should even exist other ways to abuse vJass and make it much more like a textmacro of jass !

Seriouly, at least there is this useless constant, but i suppose a good script optimizer will get rid of this, such as wc3mapoptimizer.
But still, i would go for the proper way, just for the sake of sense.

Some times using structs even when you don't need instances is neat, just for the "." syntax, but here it doesn't improve anything.

 

[Magtheridon96]

If JASS was more powerful, I'd opt for structs only as PODs and generic functions that operate on concepts like Boundable, Positionable, etc... (All on compile time so errors are not encountered on run-time.)

Only then could we alleviate the terrible design imposed by practically every vJASS resource on this site.

 

[Troll-Brain]

If JASS was more powerful, I'd opt for structs only as PODs and generic functions that operate on concepts like Boundable, Positionable, etc... (All on compile time so errors are not encountered on run-time.)

Only then could we alleviate the terrible design imposed by practically every vJASS resource on this site.

If jass was more powerfull, vJass would not even exist.
The point of vJass is not to make things faster to run, but faster/easier to write.

But here vJass is abused just for the sake of it, not even to win some pointless nano seconds.
Now, i'm not making some drama, just bored of all this shit. *shrugs*

 

[TriggerHappy]

Maybe add support for the common indexers (AutoIndex, AIDS) withstatic if's since Nestharus removed his.