[Wurst] SmartTrack

[Spellbound]

This is the Wurst version of my vJASS library SmartTrack.

Wurstbin - The Wurst & Jass Pastebin

Free paste tool with Wurst and Jass language highlighting. Wurstbin is a website where you can store text online.

bin.wurstlang.org

PS: Would you rather I upload this to wurstbin and link it here instead?
PS2: What tags am I supposed to use for Wurst submissions? Doesn't say anywhere.

 

[Cokemonkey11]

Hey @Spellbound

I didn't see this submission until now

Sorry for the delay

Do you have a github repository in wurst dependency format?

That will make it easier for me to test etc

Best

++ @Frotty

 

[Spellbound]

Lol almost 3 years later. I had forgotten this was even here.

I do have a more recent version but it's using all abstract classes that you need to extend. No closures, so I don't know if I discovered there was something wrong with this version along the way and had to change it...

Do you have a github repository in wurst dependency format?

Nope. How do I do that?

 

[Cokemonkey11]

Check out WurstScript • wurst.build file

It is a pretty simple system. When a dependency is listed, then "installing" a project downloads the dependency as an exact copy into the dependencies folder.

So there's no magic trick to using this but generally you should try to make the library modular.

You can search for examples of dependencies using GitHub - Cokemonkey11/chillup: A wurstscript dependency search tool

 

[Spellbound]

Eh, I can't be bothered to do all that just for a system with zero external dependencies. Maybe I would have committed effort 3 years ago but I'm a bit taken with other stuff these days.

 

[Cokemonkey11]

The useful thing is that other people can use you as a dependency

Okay, I'll review in current form

 

[Spellbound]

Okay, I will consider it for the future.

 

[Cokemonkey11]

Review of code at this snapshot: Wurstbin - The Wurst & Jass Pastebin

Wurstbin - The Wurst & Jass Pastebin

Free paste tool with Wurst and Jass language highlighting. Wurstbin is a website where you can store text online.

bin.wurstlang.org

I believe I've spotted two critical bugs which means this won't compile + is not MUI

 

[Spellbound]

I think the MUI part was the reason I moved away from closures and use extended classes instead.

To answer a few of your questions:

A SmartTrack instance wasn't meant to be a thing. Only the closures are supposed to do anything.

The ignoreOrder variable is used if you want to issue an order that doesn't break tracking, so were meant to:

ignoreOrder = true
// issue order
ignoreOrder = false

I found '.getSource' inside of the EventHelper package:

public function trigger.getSource() returns unit
    return triggerData.loadUnit(GetHandleId(this))

Also why should I not use handle ids inside of HashMaps? Is that a coding convention thing or is there a safety reason behind it?

As for updating the package itself, I've sort of moved away from Warcraft 3 in general so I can't really say when I'll have the time to look into fixing this. If you have a solution ready I'll gladly update the OP with credits to you.

 

[Cokemonkey11]

Thanks @Spellbound . Given the MUI bug, can you upload your newer version? I would review that separately.

Also why should I not use handle ids inside of HashMaps? Is that a coding convention thing or is there a safety reason behind it?

Generics in general are a type constraint tool which aids in correctness. When you type your hashmap as "int" then you expose yourself to accidentally using any other integer-derivable keys. For example, you could accidentally store an item and then try to loadUnit.

You are circumventing the wurst type checker and exposing yourself, yes.

 

[Spellbound]

Thanks @Spellbound . Given the MUI bug, can you upload your newer version? I would review that separately.



Generics in general are a type constraint tool which aids in correctness. When you type your hashmap as "int" then you expose yourself to accidentally using any other integer-derivable keys. For example, you could accidentally store an item and then try to loadUnit.

You are circumventing the wurst type checker and exposing yourself, yes.

I'll upload it to the bin because the bb code here is removing my linebreaks

Wurstbin - The Wurst & Jass Pastebin

Free paste tool with Wurst and Jass language highlighting. Wurstbin is a website where you can store text online.

bin.wurstlang.org

 

[Bribe]

I'll upload it to the bin because the bb code here is removing my linebreaks

Wurstbin - The Wurst & Jass Pastebin

Free paste tool with Wurst and Jass language highlighting. Wurstbin is a website where you can store text online.

bin.wurstlang.org

It does that to me, too, when I paste in code from vsCode.

It also adds twice the number of spaces when I copy code while editing a HiveWorkshop post and paste it somewhere else, but thankfully doesn't have this issue when copying outside of edit mode (on the static post itself).

@Ralle not sure if this is already on your radar.

 

[Ralle]

Does it do the same if you disable WYSIWYG?, the

button.

 

[Bribe]

Does it do the same if you disable WYSIWYG?, the View attachment 413977 button.

I've just tested it, and the copy&paste functionality definitely work normally in this mode:

But in this mode they cause problems:

 

[Ralle]

That's really annoying. It's a XenForo thing and not easy for me to fix.

Which browser are you pasting into?

Could you perhaps record a video?

I'm reminded of this, but that got fixed:

Fixed - Inserting code doubles line breaks

When I try to paste a block of code into the code editor (Insert -> Code), I get double line breaks. This does not happen on my local install (2.0.0 Gold).

xenforo.com

What if you paste from Notepad?

 

[Bribe]

I'm using Edge on Win10. I've just tested it on Firefox and the behavior is the same. If it's a XenForo thing, then I guess there isn't much that can be done about it aside from using Ctrl+Shift+V or toggling the BBcode brackets (though Ctrl+Shift+V only works when pasting into Hive, but not when pasting copied Hive text into a text editor).

 

[Ralle]

Would you try different sources for me? So not only VS Code. VS Code is HTML, Notepad is plain text. That's why I suggested it

 

[Cokemonkey11]

I'll upload it to the bin because the bb code here is removing my linebreaks

Wurstbin - The Wurst & Jass Pastebin

Free paste tool with Wurst and Jass language highlighting. Wurstbin is a website where you can store text online.

bin.wurstlang.org

I didn't spot any major issues with this one -- can you update the original post and I will approve it?

 

[Spellbound]

Done